On 10/30/2012 01:43, Christian Costa wrote:
Try 2:
- Don't use CompareStringEx.
- Add tests
---
dlls/kernel32/kernel32.spec |1 +
dlls/kernel32/locale.c | 28
dlls/kernel32/tests/locale.c | 60 +-
3 files changed
Hiroshi Miura writes:
> +#ifdef SONAME_LIBSSL
> +/* can't connect if we are already connected */
> +if (connection->ssl_s)
> +{
> +ERR("already connected\n");
> +return ERROR_INTERNET_CANNOT_CONNECT;
> +}
> +
> +/* connect with given TLS options */
> +res =
On Mon, Oct 29, 2012 at 10:37 AM, Nikolay Sivov wrote:
> On 10/29/2012 11:33, Frédéric Delanoy wrote:
>>
>> FreeLibrary(temp) can be called twice on error.
>>
>> CID 714004
>> ---
>
>> error:
>> FreeLibrary(lib);
>> -FreeLibrary(temp);
>> +if (temp != NULL) FreeLibrary(temp);
>>
Le 29/10/2012 06:57, Nikolay Sivov a écrit :
On 10/29/2012 00:53, Christian Costa wrote:
---
dlls/kernel32/kernel32.spec |1 +
dlls/kernel32/locale.c |8
2 files changed, 9 insertions(+)
diff --git a/dlls/kernel32/kernel32.spec b/dlls/kernel32/kernel32.spec
index b7efa
Daniel Lehman writes:
> +static void test_istream_peek(void)
> +{
> +unsigned short testus, nextus;
> +basic_stringstream_wchar wss;
> +basic_stringstream_char ss;
> +basic_string_wchar wstr;
> +basic_string_char str;
> +IOSB_iostate state;
> +int i, next, peek;
> +
That was the worst possible defence of this patch, but I think it
should be included.
What it's actually doing is removing the duplicated logic between the
earlier bit of GdipDrawString, where out-of-range sizes are set to 1
<< 23, and this if statement where we only apply a clipping rectangle
if
On Mon, Oct 29, 2012 at 2:20 AM, Rico Schüller wrote:
> On 28.10.2012 16:13, André Hentschel wrote:
>>
>> - lpGData->lpRemoteData = lpNewData;
>> + lpGData->lpRemoteData = HeapAlloc( GetProcessHeap(),
>> HEAP_ZERO_MEMORY, sizeof( dwDataSize ) );
>> + CopyMemory( lpGData->lpRemot
2012/10/29 Christian Costa :
>
>>
>> pixel_format = get_format_info(src_desc.Format);
>> -if (pixel_format->type != FORMAT_ARGB)
>> -{
>> -FIXME("Unsupported pixel format %#x\n", src_desc.Format);
>> -return E_NOTIMPL;
>> -}
>> +if (pixel_format->type == FORMAT_
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=22550
Your paranoid android
>
> pixel_format = get_format_info(src_desc.Format);
> -if (pixel_format->type != FORMAT_ARGB)
> -{
> -FIXME("Unsupported pixel format %#x\n", src_desc.Format);
> -return E_NOTIMPL;
> -}
> +if (pixel_format->type == FORMAT_UNKNOWN) return E_NOTIMPL;
>
>
Doesn'
On 10/29/2012 11:33, Frédéric Delanoy wrote:
FreeLibrary(temp) can be called twice on error.
CID 714004
---
error:
FreeLibrary(lib);
-FreeLibrary(temp);
+if (temp != NULL) FreeLibrary(temp);
SetLastError(TRUST_E_SUBJECT_FORM_UNKNOWN);
return FALSE;
}
This is
On 10/29/12 01:25, Max TenEyck Woodbury wrote:
> On 10/28/2012 12:06 PM, Nikolay Sivov wrote:
>> On 10/28/2012 17:44, Max TenEyck Woodbury wrote:
>>> On 10/28/2012 02:40 AM, Nikolay Sivov wrote:
On 10/28/2012 04:59, m...@mtew.isa-geek.net wrote:
> From: Max TenEyck Woodbury
>
> I
On 28.10.2012 16:13, André Hentschel wrote:
- lpGData->lpRemoteData = lpNewData;
+ lpGData->lpRemoteData = HeapAlloc( GetProcessHeap(), HEAP_ZERO_MEMORY,
sizeof( dwDataSize ) );
+ CopyMemory( lpGData->lpRemoteData, lpData, dwDataSize );
lpGData->dwRemoteDataSize = dwDa
13 matches
Mail list logo
