Re: [PATCH] d3d9/tests: Add test for IDirect3DDevice9_Reset with BackBufferWidth/Height = 0.

2012-11-06 Thread Sam Edwards
On Nov 6, 2012, at 3:45, Henri Verbeet wrote: > Yeah, we'll want a similar test for d3d8. Okay, I'll write that as soon as the d3d9 test is accepted. > You're probably looking for AdjustWindowRect() and SetWindowPos(). Thank you, I didn't know about AdjustWindowRect(), but why SetWindowPos()?

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

2012-11-06 Thread Nikolay Sivov
On 11/7/2012 01:05, Christian Costa wrote: Le 06/11/2012 22:38, Michael Stefaniuc a écrit : On 11/06/2012 08:51 PM, Christian Costa wrote: Le 06/11/2012 20:26, Nikolay Sivov a écrit : On 11/6/2012 20:47, Christian Costa wrote: What I also meant is these names are redundant, something like dire

Re: [PATCH] tools/wine.inf.in: Added UTF8 bom header. (resend)

2012-11-06 Thread Dmitry Timoshkov
Qian Hong wrote: > Added comment as Dan suggested. Thanks Dmitry, Dan and Nikolay for comments > and advice. Also I'm appreciated for any other ideas to resolve Bug 32136. So, how is this supposed to work under Windows? -- Dmitry.

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

2012-11-06 Thread Christian Costa
Le 06/11/2012 22:38, Michael Stefaniuc a écrit : On 11/06/2012 08:51 PM, Christian Costa wrote: Le 06/11/2012 20:26, Nikolay Sivov a écrit : On 11/6/2012 20:47, Christian Costa wrote: What I also meant is these names are redundant, something like directmusicloader_AddRef() is enough, of course

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

2012-11-06 Thread Michael Stefaniuc
On 11/06/2012 08:51 PM, Christian Costa wrote: > Le 06/11/2012 20:26, Nikolay Sivov a écrit : >> On 11/6/2012 20:47, Christian Costa wrote: >> What I also meant is these names are redundant, something like >> directmusicloader_AddRef() is enough, of course you could use mixed >> casing in names if

Re: shell32: initialize fAnyOperationsAborted in SHFileOperation (try 2)

2012-11-06 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22786 Your paranoid android

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

2012-11-06 Thread Christian Costa
Le 06/11/2012 20:26, Nikolay Sivov a écrit : On 11/6/2012 20:47, Christian Costa wrote: --- dlls/dmloader/dmloader_private.h | 16 +++--- dlls/dmloader/loader.c | 107 +++--- 2 files changed, 73 insertions(+), 50 deletions(-) diff --git a/dlls/

Re: shell32: initialize fAnyOperationsAborted in SHFileOperation

2012-11-06 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22785 Your paranoid android

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

2012-11-06 Thread Nikolay Sivov
On 11/6/2012 20:47, Christian Costa wrote: --- dlls/dmloader/dmloader_private.h | 16 +++--- dlls/dmloader/loader.c | 107 +++--- 2 files changed, 73 insertions(+), 50 deletions(-) diff --git a/dlls/dmloader/dmloader_private.h b/dlls/dmloader/dmlo

Re: iphlapi: Fix some leaks (coverity)

2012-11-06 Thread Juan Lang
Hi Frédéric, thanks for the patch. Allow me to elaborate: On Tue, Nov 6, 2012 at 6:05 AM, Alexandre Julliard wrote: > Frédéric Delanoy writes: > > > @@ -1520,8 +1521,8 @@ DWORD WINAPI GetIpAddrTable(PMIB_IPADDRTABLE > pIpAddrTable, PULONG pdwSize, BOOL > > sizeof(MIB_IPADDRROW), IpA

Re: imm32: use SendMessage not PostMessage for the Default IME winproc

2012-11-06 Thread Henri Verbeet
On 6 November 2012 15:41, Aric Stewart wrote: > > This allows the calling program to properly get the return codes from the > messages when they need them. > Also prevent all of the calls for IME messages in that windproc from falling > back through to DefWindowProc. > > for bug 32101 Can we ha

Re: [1/2] gdiplus: Add support for extra transformation in GdipMeasureDriverString and GdipDrawDriverString. Take 2.

2012-11-06 Thread Vincent Povirk
Series looks good to me, thanks.

Re: iphlapi: Fix some leaks (coverity)

2012-11-06 Thread Alexandre Julliard
Frédéric Delanoy writes: > @@ -1520,8 +1521,8 @@ DWORD WINAPI GetIpAddrTable(PMIB_IPADDRTABLE > pIpAddrTable, PULONG pdwSize, BOOL > sizeof(MIB_IPADDRROW), IpAddrTableSorter); > ret = NO_ERROR; >} > - HeapFree(GetProcessHeap(), 0, table); > } > +HeapFre

Re: msi: Fix some leaks (coverity)

2012-11-06 Thread Alexandre Julliard
Frédéric Delanoy writes: > @@ -151,15 +151,23 @@ static UINT propvar_changetype(PROPVARIANT *changed, > PROPVARIANT *property, VART > { > HRESULT hr; > HMODULE propsys = LoadLibraryA("propsys.dll"); > + > +if (!propsys) > +{ > +ERR("Failed to load propsys.dll: %u\n", G

Re: widl: Ignore -app_mode option

2012-11-06 Thread Alexandre Julliard
Jacek Caban writes: > It also changes getopt_long to getopt_long_only, making argument parsing > less strict. Please also update the man page and the usage message. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH 2/3] dmloader: Display new ref in AddRef and Release.

2012-11-06 Thread Christian Costa
Thanks for spotting. I will send an additional patch for that or do an update. 2012/11/6 Nikolay Sivov > On 11/6/2012 14:09, Alistair Leslie-Hughes wrote: > >> Hi, >> >> On 6/11/2012 7:05 PM, Christian Costa wrote: >> >>static HRESULT WINAPI IDirectMusicLoaderImpl_** >>> IDirectMusicLoader_G

Re: [PATCH 2/3] dmloader: Display new ref in AddRef and Release.

2012-11-06 Thread Nikolay Sivov
On 11/6/2012 14:09, Alistair Leslie-Hughes wrote: Hi, On 6/11/2012 7:05 PM, Christian Costa wrote: static HRESULT WINAPI IDirectMusicLoaderImpl_IDirectMusicLoader_GetObject(LPDIRECTMUSICLOADER8 iface, LPDMUS_OBJECTDESC pDesc, REFIID riid, LPVOID* ppv) @@ -880,7 +884,7 @@ HRESULT WINAPI DMUS

Re: [PATCH 2/3] dmloader: Display new ref in AddRef and Release.

2012-11-06 Thread Alistair Leslie-Hughes
Hi, On 6/11/2012 7:05 PM, Christian Costa wrote: static HRESULT WINAPI IDirectMusicLoaderImpl_IDirectMusicLoader_GetObject(LPDIRECTMUSICLOADER8 iface, LPDMUS_OBJECTDESC pDesc, REFIID riid, LPVOID* ppv) @@ -880,7 +884,7 @@ HRESULT WINAPI DMUSIC_CreateDirectMusicLoaderImpl (LPCGUID lpcGUID,

Re: [PATCH] d3d9/tests: Add test for IDirect3DDevice9_Reset with BackBufferWidth/Height = 0.

2012-11-06 Thread Henri Verbeet
On 6 November 2012 05:01, Sam Edwards wrote: > Perhaps a similar test is necessary in other Direct3D versions, but I > haven't yet looked into it. > Yeah, we'll want a similar test for d3d8. > +/* For resizing the window, we need to know the nonclient area size */ > +ok(GetWindowRect(hwnd

Re: [PATCH 2/4] msvcrt: Improved _atoflt_l precision

2012-11-06 Thread Piotr Caban
On 11/05/12 18:02, Alexandre Julliard wrote: Piotr Caban writes: --- dlls/msvcrt/string.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M msvcr90.dll -T ../../.. -p msvcr90_test.exe.so msvcr90.c && touch msvcr90.ok

Re: [PATCH] tools/wine.inf.in: Added UTF8 bom header.

2012-11-06 Thread Qian Hong
Hi Dmitry, On Tue, Nov 6, 2012 at 3:59 PM, Dmitry Timoshkov wrote: > It should be possible to specify a not localized font name. In general, > wine.inf follows Windows format of .inf files, you should investigate > how unicode is supposed to work inside of .inf files. Thanks for advice! Unfortun

Re: [1/3] gdiplus: Add a test to check transformation order in GdipMeasureDriverString.

2012-11-06 Thread Dmitry Timoshkov
Vincent Povirk wrote: > The approach of rotating and scaling still works, but it requires > drawing text and visually inspecting the output. I've written and > attached a test program that does that (with a matrix that rotates by > 90 degrees and a world transform with a much greater scale on the