Explicit fall-through in switch statements?

2012-11-25 Thread Frédéric Delanoy
For every wine version, static checkers (like coverity) detect cases where a switch case automatically falls-through to the next case. Shouldn't be there a rule that such cases are always marked with a fall-through comment? With the possible exception of case with no statement? like 'case FOO:

Re: Explicit fall-through in switch statements?

2012-11-25 Thread Bruno Jesus
On Sun, Nov 25, 2012 at 9:20 PM, Frédéric Delanoy frederic.dela...@gmail.com wrote: For every wine version, static checkers (like coverity) detect cases where a switch case automatically falls-through to the next case. Shouldn't be there a rule that such cases are always marked with a

Re: [1/2] ole32: Add helper for string table memory freeing

2012-11-25 Thread Nikolay Sivov
On 11/26/2012 01:01, Frédéric Delanoy wrote: --- dlls/ole32/filemoniker.c | 44 ++-- 1 file changed, 18 insertions(+), 26 deletions(-) diff --git a/dlls/ole32/filemoniker.c b/dlls/ole32/filemoniker.c index b3a5cc2..688f6b8 100644 ---