Re: [2/2] gdi32/tests: Added tests for GetFontResourceInfoW

2012-12-13 Thread Dmitry Timoshkov
Stefan Leichter wrote: > > > +pCopyFileW = (void *)GetProcAddress(hkernel32, "CopyFileW"); > > > +pExpandEnvironmentStringsW = (void *)GetProcAddress(hkernel32, > > > "ExpandEnvironmentStringsW"); +pGetCurrentDirectoryW = (void > > > *)GetProcAddress(hkernel32, "GetCurrentDirectoryW")

Re: ole32: fix compilation with mingw32-gcc >= 4.6.0

2012-12-13 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23392 Your paranoid android

Re: [2/2] gdi32/tests: Added tests for GetFontResourceInfoW

2012-12-13 Thread Stefan Leichter
Friday 14 December 2012 Dmitry Timoshkov > Stefan Leichter wrote: > > +pCopyFileW = (void *)GetProcAddress(hkernel32, "CopyFileW"); > > +pExpandEnvironmentStringsW = (void *)GetProcAddress(hkernel32, > > "ExpandEnvironmentStringsW"); +pGetCurrentDirectoryW = (void > > *)GetProcAddress

Re: [PATCH] msxml3: skip a possible BOM in doparse

2012-12-13 Thread Nikolay Sivov
Actually libxml2 is supposed to take care of that. Relevant code from xmlSwitchInputEncodingInt() : --- /* * Specific handling of the Byte Order Mark for * UTF-16 */ if ((handler->name != NULL) && (!strcmp(handler->name

Re: [2/2] gdi32/tests: Added tests for GetFontResourceInfoW

2012-12-13 Thread Dmitry Timoshkov
Stefan Leichter wrote: > +pCopyFileW = (void *)GetProcAddress(hkernel32, "CopyFileW"); > +pExpandEnvironmentStringsW = (void *)GetProcAddress(hkernel32, > "ExpandEnvironmentStringsW"); > +pGetCurrentDirectoryW = (void *)GetProcAddress(hkernel32, > "GetCurrentDirectoryW"); There is

Re: [PATCH 1/3] [cmd] Convert the set /a tests to validate better

2012-12-13 Thread Frédéric Delanoy
On Fri, Dec 14, 2012 at 2:59 AM, Frédéric Delanoy wrote: > On Thu, Dec 13, 2012 at 10:59 PM, Ann and Jason Edmeades > wrote: >> The tests previously set a variable which was not checked until >> the subsequent test completed (as env vars are expanded as the >> line is read, meaning a sequence of

Re: [PATCH 1/3] [cmd] Convert the set /a tests to validate better

2012-12-13 Thread Frédéric Delanoy
On Thu, Dec 13, 2012 at 10:59 PM, Ann and Jason Edmeades wrote: > The tests previously set a variable which was not checked until > the subsequent test completed (as env vars are expanded as the > line is read, meaning a sequence of set /a var=x & echo %var% > echos the contents before the set is

Re: Use software vertex processing instead of mixed?

2012-12-13 Thread Henri Verbeet
On 14 December 2012 00:53, Francois Gouget wrote: > > A lot of tests get skipped on my Windows XP EeePC just because the > Direct3D 9 device creation fails. And apparently that's just because we > ask for mixed vertex processing instead of software vertex processing. > > How important is it to use

Use software vertex processing instead of mixed?

2012-12-13 Thread Francois Gouget
A lot of tests get skipped on my Windows XP EeePC just because the Direct3D 9 device creation fails. And apparently that's just because we ask for mixed vertex processing instead of software vertex processing. How important is it to use mixed mode instead of software, at least for these tests?

Re: msvcrt: implement _ftol in msvcrt instead of forwarding to ntdll (1/2)

2012-12-13 Thread Alexandre Julliard
Austin English writes: > On Wed, Dec 12, 2012 at 5:57 PM, Austin English > wrote: >> From the keeping Focht happy team >> >> This patch series fixes http://bugs.winehq.org/show_bug.cgi?id=13401 >> >> -- >> -Austin > > Only export the symbol on 32-bit. This should be properly integrated with th

Re: [PATCH 1/7] advapi32: Support service objects in GetSecurityInfo (try 4).

2012-12-13 Thread Alexandre Julliard
"Erich E. Hoover" writes: > +/* Test using GetSecurityInfo to obtain security information */ > +SetLastError(0xdeadbeef); > +retval = pGetSecurityInfo(svc_handle, SE_SERVICE, > DACL_SECURITY_INFORMATION, &sidOwner, > + &sid

Re: [PATCH 1/5] [WineHelp]: added basic infrastructure for a new wineconsole mode: line

2012-12-13 Thread Alexandre Julliard
Eric Pouech writes: > +/** > + * WCLINE_SetTitle > + * > + * Sets the title to the wine console > + */ > +static void WCLINE_SetTitle(const struct inner_data* data) > +{ > +WCHAR wbuf[256]; > + > +if (WINECON_Get

Re: msvcrt: implement _ftol in msvcrt instead of forwarding to ntdll (1/2)

2012-12-13 Thread Austin English
On Thu, Dec 13, 2012 at 2:04 AM, Piotr Caban wrote: > On 12/13/12 02:57, Austin English wrote: > + * Based on MSVCRT__ftol in dlls/ntdll/misc.c > + */ > +#if defined(__GNUC__) && defined(__i386__) > +LONGLONG CDECL MSVCRT__ftol(void) > +{ > > +@ cdecl -ret64 _ftol() MSVCRT__ftol > +@ cdecl -ret64

Re: [PATCH 2/4] msvcrt: Support expand_wildcards parameter in __getmainargs function

2012-12-13 Thread Alexandre Julliard
Piotr Caban writes: > @@ -359,6 +360,51 @@ void msvcrt_free_args(void) >HeapFree(GetProcessHeap(), 0, MSVCRT__wenviron); >HeapFree(GetProcessHeap(), 0, MSVCRT__pgmptr); >HeapFree(GetProcessHeap(), 0, MSVCRT__wpgmptr); > + HeapFree(GetProcessHeap(), 0, argv_expand); > +} > + > +static

Re: msvcrt: implement _ftol in msvcrt instead of forwarding to ntdll (1/2)

2012-12-13 Thread Piotr Caban
On 12/13/12 02:57, Austin English wrote: + * Based on MSVCRT__ftol in dlls/ntdll/misc.c + */ +#if defined(__GNUC__) && defined(__i386__) +LONGLONG CDECL MSVCRT__ftol(void) +{ +@ cdecl -ret64 _ftol() MSVCRT__ftol +@ cdecl -ret64 _ftol2() MSVCRT__ftol This will not work on 64-bit build or when __G