Re: [9/9] server: Add support for named pipe message mode.

2012-12-27 Thread Daniel Jelinski
Hello, FWIW, Adam Martinson's named pipe series looks good to me. I tested it with MS SQL Server, which uses message mode pipes, and did not run into any problems. In current git I can't connect to server using named pipes, because as soon as SetNamedPipeHandleState returns false, client applicatio

Re: netstat: Initial implementation

2012-12-27 Thread Alexandre Julliard
André Hentschel writes: > +__ms_va_start(parms, format); > +len = vsprintfW(output_bufW, format, parms); > +__ms_va_end(parms); You can't mix vsprintfW and ms_va_list. -- Alexandre Julliard julli...@winehq.org

Re: [2/2] windowscodecs: Implement ComponentFactory_CreateBitmapFromMemory.

2012-12-27 Thread Vincent Povirk
Looks like I won't be around when this finishes, but I sent a test to testbot: https://testbot.winehq.org/JobDetails.pl?Key=23638 This should succeed if your implementation is correct (data is referenced, not copied).

Re: [2/2] windowscodecs: Implement ComponentFactory_CreateBitmapFromMemory.

2012-12-27 Thread Vincent Povirk
>> I'm pretty sure CreateBitmapFromMemory copies the data rather than >> referencing existing data. > > How do you know that? In any case adding a test case and support for that > behaviour should be pretty trivial once this patch is accepted. I believe it was this stack overflow question that fir

Re: [2/2] windowscodecs: Implement ComponentFactory_CreateBitmapFromMemory.

2012-12-27 Thread Dmitry Timoshkov
Vincent Povirk wrote: > I'm pretty sure CreateBitmapFromMemory copies the data rather than > referencing existing data. How do you know that? In any case adding a test case and support for that behaviour should be pretty trivial once this patch is accepted. -- Dmitry.

Re: netstat: Initial implementation

2012-12-27 Thread André Hentschel
Am 27.12.2012 12:24, schrieb Alexandre Julliard: > André Hentschel writes: > >> +STRINGTABLE >> +{ >> + IDS_TCP_UNKNOWN, "???" >> + IDS_TCP_CLOSED, "CLOSED" >> + IDS_TCP_LISTENING, "LISTENING" >> + IDS_TCP_SYN_SENT,"SYN_SENT" >> + IDS_TCP_SYN_RCVD,"SYN_RCVD" >> + IDS_TCP_

Re: [2/2] windowscodecs: Implement ComponentFactory_CreateBitmapFromMemory.

2012-12-27 Thread Vincent Povirk
I'm pretty sure CreateBitmapFromMemory copies the data rather than referencing existing data. On Thu, Dec 27, 2012 at 3:29 AM, Dmitry Timoshkov wrote: > --- > dlls/windowscodecs/bitmap.c| 31 +-- > dlls/windowscodecs/imgfactory.c| 18 +++---

Re: netstat: Initial implementation

2012-12-27 Thread Alexandre Julliard
André Hentschel writes: > +STRINGTABLE > +{ > + IDS_TCP_UNKNOWN, "???" > + IDS_TCP_CLOSED, "CLOSED" > + IDS_TCP_LISTENING, "LISTENING" > + IDS_TCP_SYN_SENT,"SYN_SENT" > + IDS_TCP_SYN_RCVD,"SYN_RCVD" > + IDS_TCP_ESTABLISHED, "ESTABLISHED" > + IDS_TCP_FIN_WAIT1, "FIN_WAI

Re: msvcrt: Return error in stat function when path is specified with trailing slash character

2012-12-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23632 Your paranoid android