Re: [3/4] windowscodecs: Implement CreateBitmapFromMemory.

2013-01-02 Thread Dmitry Timoshkov
Vincent Povirk wrote: > I guess I prefer to keep interfaces as simple as possible even if it > means writing more code? I'd consider writing a helper function, but > none of the other methods would use it. Is there any hurry with CreateBitmapFromMemory implementation, or you somehow prefer your

Re: [3/4] windowscodecs: Implement CreateBitmapFromMemory.

2013-01-02 Thread Vincent Povirk
On Wed, Jan 2, 2013 at 11:42 PM, Dmitry Timoshkov wrote: > It's better to actually check return value of IWICBitmapLock_GetDataPointer > before memecpy(), or if that's not supposed to fail drop 'hr' assignment. Whoops, good catch. (I don't think it can fail, but I didn't mean to make that assumpt

Re: [3/4] windowscodecs: Implement CreateBitmapFromMemory.

2013-01-02 Thread Dmitry Timoshkov
Vincent Povirk wrote: > +hr = IWICBitmap_Lock(bitmap, NULL, WICBitmapLockWrite, &lock); > +if (SUCCEEDED(hr)) > +{ > +UINT buffersize; > +BYTE *buffer; > + > +hr = IWICBitmapLock_GetDataPointer(lock, &buffersize, &buffer); > + > +

Re: [PATCH] ntdll/tests: Fix SYSTEM_CACHE_INFORMATION failures [try 2]

2013-01-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23718 Your paranoid android

Re: [wine-devel] Re: [SOLVED] wine-1.5.20 regression compared to 1.5.19 and previous; MinGW/gcc 4.7.0 segfaults under wineconsole

2013-01-02 Thread Alan W. Irwin
On 2012-12-28 10:22-0800 Alan W. Irwin wrote: [...Let's] leave it like this. Wine-1.5.20 has introduced an obvious regression for an important Windows app (the MinGW gcc compiler for Windows) that has been working for years for prior Wine versions. Grant communicated to me off list that he was

Re: [2/4] windowscodecs: Test whether CreateBitmapFromMemory stride is stored.

2013-01-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23709 Your paranoid android

Re: [3/4] windowscodecs: Implement CreateBitmapFromMemory.

2013-01-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23710 Your paranoid android

Re: [PATCH] ntdll/tests: Fix SYSTEM_CACHE_INFORMATION failures on WIN64

2013-01-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23712 Your paranoid android

Re: [PATCH] winebuild: Use Clang to assemble if its integrated assembler is being used.

2013-01-02 Thread Charles Davis
On Jan 2, 2013, at 11:23 AM, Per Johansson wrote: > On Wed, Jan 2, 2013 at 5:05 PM, André Hentschel wrote: >> >> Not sure if you can do it like that, as i understand it winebuild should >> always be able to crosscompile something, these ifdefs would destroy that >> feature. Only on Mac OS :).

Re: [website] Are we doing something wrong with our secure connections?

2013-01-02 Thread Juan Lang
Hi André, On Wed, Jan 2, 2013 at 8:08 AM, André Hentschel wrote: > Hi, > FWIW i have just seen: > > > https://www.ssllabs.com/ssltest/analyze.html?d=testbot.winehq.org&hideResults=on > > https://www.ssllabs.com/ssltest/analyze.html?d=test.winehq.org&hideResults=on > > https://www.ssllabs.com/ss

Re: winebuild: Add configure option to use llvm-mc as assembler.

2013-01-02 Thread Charles Davis
On Jan 2, 2013, at 5:35 AM, Per Johansson wrote: > On Wed, Jan 2, 2013 at 3:12 AM, Charles Davis wrote: > >> What kind of undefined symbol errors? Other than the ones I got because >> as(1) from cctools can't grok CFI pseudo-ops (and probably never will >> because of Clang), I don't know of a

Re: [PATCH] winebuild: Use Clang to assemble if its integrated assembler is being used.

2013-01-02 Thread Per Johansson
On Wed, Jan 2, 2013 at 5:05 PM, André Hentschel wrote: > > Not sure if you can do it like that, as i understand it winebuild should > always be able to crosscompile something, these ifdefs would destroy that > feature. I suppose the correct way is to always use clang without target_alias prefix

Re: aclocal: Use -Werror when checking compiler flags.

2013-01-02 Thread Alexandre Julliard
Per Johansson writes: > This makes clang exit with error on unsupported warnings. You'd need to check if -Werror is supported first. -- Alexandre Julliard julli...@winehq.org

[website] Are we doing something wrong with our secure connections?

2013-01-02 Thread André Hentschel
Hi, FWIW i have just seen: https://www.ssllabs.com/ssltest/analyze.html?d=testbot.winehq.org&hideResults=on https://www.ssllabs.com/ssltest/analyze.html?d=test.winehq.org&hideResults=on https://www.ssllabs.com/ssltest/analyze.html?d=winehq.org&hideResults=on&ignoreMismatch=on which tells me we ha

Fwd: Re: netstat: Initial implementation (try 2)

2013-01-02 Thread André Hentschel
Original-Nachricht Betreff: Re: netstat: Initial implementation (try 2) Datum: Sat, 29 Dec 2012 15:39:54 +0100 Von: André Hentschel An: Wine Devel Am 28.12.2012 23:10, schrieb Frédéric Delanoy: > On Thu, Dec 27, 2012 at 7:03 PM, André Hentschel wrote: >> +#define IDS_TCP_UNKNO

Re: [PATCH] winebuild: Use Clang to assemble if its integrated assembler is being used.

2013-01-02 Thread André Hentschel
Am 02.01.2013 02:56, schrieb Charles Davis: > --- a/tools/winebuild/utils.c > +++ b/tools/winebuild/utils.c > @@ -345,10 +345,22 @@ struct strarray *get_as_command(void) > > if (!as_command) > { > +#ifdef CLANG_AS > +/* The native assembler might not support CFI pseudo-ops, > +

Re: [PATCH 2/7] d3dx9: Always set the table = NULL in D3DXGetShaderConstantTableEx(). (try 3)

2013-01-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23691 Your paranoid android

Re: [PATCH 3/7] d3dx9: Handle invalid byte code in D3DXGetShaderConstantTableEx(). (try 3)

2013-01-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23692 Your paranoid android

Re: [PATCH 7/7] d3dcompiler43/tests: Don't use IUnknown_Release(). (try 3)

2013-01-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23693 Your paranoid android

Re: [PATCH 1/7] d3dx9: Handle invalid byte code in D3DXFindShaderComment().

2013-01-02 Thread Jacek Caban
On 01/02/13 14:38, Matteo Bruni wrote: > 2013/1/1 Rico Schüller : >> --- >> dlls/d3dx9_36/shader.c | 16 +++- >> dlls/d3dx9_36/tests/shader.c | 21 + >> 2 Dateien geändert, 32 Zeilen hinzugefügt(+), 5 Zeilen entfernt(-) >> > +static inline BOOL is_valid_byteco

Re: d3dcompiler_43: Avoid signed-unsigned integer comparisons

2013-01-02 Thread Matteo Bruni
2013/1/1 Andrew Talbot : > Changelog: > d3dcompiler_43: Avoid signed-unsigned integer comparisons. > > diff --git a/dlls/d3dcompiler_43/bytecodewriter.c > b/dlls/d3dcompiler_43/bytecodewriter.c > index d10f6bc..17289d2 100644 > --- a/dlls/d3dcompiler_43/bytecodewriter.c > +++ b/dlls/d3dcompile

Re: [PATCH 1/7] d3dx9: Handle invalid byte code in D3DXFindShaderComment().

2013-01-02 Thread Matteo Bruni
2013/1/1 Rico Schüller : > --- > dlls/d3dx9_36/shader.c | 16 +++- > dlls/d3dx9_36/tests/shader.c | 21 + > 2 Dateien geändert, 32 Zeilen hinzugefügt(+), 5 Zeilen entfernt(-) > +static inline BOOL is_valid_bytecode(DWORD token) +{ +token &= 0x; +

Re: [7/7] wmiutils: Add tests. (try 2)

2013-01-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23688 Your paranoid android

Re: winebuild: Add configure option to use llvm-mc as assembler.

2013-01-02 Thread Per Johansson
On Wed, Jan 2, 2013 at 3:12 AM, Charles Davis wrote: > What kind of undefined symbol errors? Other than the ones I got because as(1) > from cctools can't grok CFI pseudo-ops (and probably never will because of > Clang), I don't know of any symbol problems building Wine with Clang on Mac > OS.

Re: [7/7] wmiutils: Add tests.

2013-01-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23686 Your paranoid android

Re: [PATCH] ddraw: Don't discard buffers that haven't been used in draws

2013-01-02 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-01-02 12:42, schrieb Henri Verbeet: > On 2 January 2013 12:26, Stefan Dösinger > wrote: >> Fixes bug 32485. > I'm sure we've had this discussion wrt. commit messages before, > but this tells me just about nothing about what problem this patch

Re: [PATCH] ddraw: Don't discard buffers that haven't been used in draws

2013-01-02 Thread Henri Verbeet
On 2 January 2013 12:26, Stefan Dösinger wrote: > Fixes bug 32485. I'm sure we've had this discussion wrt. commit messages before, but this tells me just about nothing about what problem this patch is supposed to fix, or why this is the correct solution. Also, do you have tests for this?

Re: [11/12] kernel32: Add support for {Get|Set}NamedPipeHandleState().

2013-01-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23681 Your paranoid android