Re: comctl32/listview: support header images

2013-01-05 Thread Nikolay Sivov
On 1/6/2013 02:55, Daniel Jelinski wrote: They are unrelated, except by file modified, and I'm sending them as I create them, but of course I can defer sending them a little. Do you mean message sequence tests or something else? I tested that visually with delphi, but I guess that's not what you'

Re: comctl32/listview: support header images

2013-01-05 Thread Nikolay Sivov
On 1/6/2013 02:25, Daniel Jelinski wrote: This one needs tests. Also even if each patch applies cleanly, please send them in series, it makes it easier to review.

Re: comctl32/listview: fix calculating item height

2013-01-05 Thread Nikolay Sivov
On 1/5/2013 18:56, Daniel Jelinski wrote: Interesting: https://testbot.winehq.org/JobDetails.pl?Key=23746&log_206=1#k206 Looks like testbot tried to do the entire test suite, even though I changed only one test file. 2013/1/5 Marvin : Hi, While running your changed tests on Windows, I think I

Re: msvcrt/tests: Add a trailing '\n' to a win_skip() call.

2013-01-05 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23752 Your paranoid android

Re: Assorted spelling fixes.

2013-01-05 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23747 Your paranoid android

Re: Assorted spelling fixes.

2013-01-05 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23751 Your paranoid android

Re: Assorted spelling fixes.

2013-01-05 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23748 Your paranoid android

Re: Assorted spelling fixes.

2013-01-05 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23750 Your paranoid android

Re: Assorted spelling fixes.

2013-01-05 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23749 Your paranoid android

Re: comctl32/listview: fix calculating item height

2013-01-05 Thread Daniel Jelinski
Interesting: https://testbot.winehq.org/JobDetails.pl?Key=23746&log_206=1#k206 Looks like testbot tried to do the entire test suite, even though I changed only one test file. 2013/1/5 Marvin : > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and al

Re: comctl32/listview: fix calculating item height

2013-01-05 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23746 Your paranoid android

Re: [PATCH 3/5] wined3d: state->user_stream is always FALSE in device_stream_info_from_declaration().

2013-01-05 Thread Stefan Dösinger
Am 04.01.2013 um 12:02 schrieb Henri Verbeet : > Since user pointer draws were removed, state->user_stream will only ever be > set for "strided" draws, and device_stream_info_from_declaration() is never > called for those. I have some patches in my tree that remove draw_primitive_strided and use

Re: [2/2] gdi32/tests: Added tests for GetFontResourceInfoW (try 2)

2013-01-05 Thread Dmitry Timoshkov
Stefan Leichter wrote: > > > First of all: The issues your are pointing out have been in the previous > > > version of the patch too. Why didn't you complain in your first review. > > > To my understanding this is a wast of my time complaining about two > > > issues and keeping the rest secret fo

Re: [2/2] gdi32/tests: Added tests for GetFontResourceInfoW (try 2)

2013-01-05 Thread Stefan Leichter
Saturday 29 December 2012 Dmitry Timoshkov > Stefan Leichter wrote: > > First of all: The issues your are pointing out have been in the previous > > version of the patch too. Why didn't you complain in your first review. > > To my understanding this is a wast of my time complaining about two > >

Re: Patchsets that need review by experienced Wine Developers

2013-01-05 Thread Alexandre Julliard
André Hentschel writes: > We should decide soon if we want to accept that patch, because it > breaks DOSBox compatiblity. So in case we commit it we should change > it in dosbox before they release 0.75 > AJ? No, that would also break compatibility with existing prefixes. -- Alexandre Julliard

Re: [website] Wine 1.5.21 freigegeben

2013-01-05 Thread Frédéric Delanoy
On Fri, Jan 4, 2013 at 10:33 PM, André Hentschel wrote: > --- > news/de/2012122101.xml~ | 17 + Not sure checking in your editor backup file is a good idea ;) Frédéric