Re: iphlpapi: Let C look like C.

Hi Michael, this isn't actually a problem with your patch, just something I spotted: On Wed, Feb 6, 2013 at 3:15 PM, Michael Stefaniuc wrote: > On 02/06/2013 11:16 PM, Austin English wrote: > > On Feb 6, 2013 11:13 PM, "Michael Stefaniuc" > > wrote: > >> > >> --- > >>

Re: iphlpapi: Let C look like C.

On 02/06/2013 11:16 PM, Austin English wrote: > On Feb 6, 2013 11:13 PM, "Michael Stefaniuc" > wrote: >> >> --- >> dlls/iphlpapi/ipstats.c |2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/dlls/iphlpapi/ipstats.c b/dlls/iphlpapi/ipstats.c

Re: iphlpapi: Let C look like C.

On Feb 6, 2013 11:13 PM, "Michael Stefaniuc" wrote: > > --- > dlls/iphlpapi/ipstats.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/iphlpapi/ipstats.c b/dlls/iphlpapi/ipstats.c > index f8191ba..966d24e 100644 > --- a/dlls/iphlpapi/ipstats.c > +++ b/dlls/iphlp

Re: comctl32/tests: drop broken test

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24289 Your paranoid android

Re: [1/4] windowscodecs: Implement IWICColorContext::InitializeFromFilename.

On Wed, 2013-02-06 at 18:10 +0100, Ludger Sprenker wrote: > On Wed, 06 Feb 2013 13:51:32 +0100, Hans Leidekker wrote: > > > + handle = CreateFileW(filename, GENERIC_READ, 0, NULL, > > > OPEN_EXISTING, 0, NULL); > > > + if (handle == INVALID_HANDLE_VALUE) return > > > HRESULT_FROM_WIN32(GetLastE

Re: [4/4] windowscodecs: Implement IWICComponentFactory::CreateDecoderFromFileHandle.

On Wed, 2013-02-06 at 10:25 -0600, Vincent Povirk wrote: > > +hr = map_file(file, &map, &mem, &size); > > +if (FAILED(hr)) return hr; > > + > ... > > + > > +hr = IWICStreamImpl_InitializeFromMemory(stream, mem, size.u.LowPart); > > +if (FAILED(hr)) goto error; > > This makes me sad

kernel32: Use the monotonic counter in GetTickCount64.

Hi, I believe we should use this opportunity and review the usage of timers in Wine. E.g. I have a patch to have CreateTimerqueue use the monotonic timer too that I'll submit after some more testing. Mmdevapi's audio currently depends on the TimerQueue which IMHO erroneously depends on gettimeofd

Re: [1/4] windowscodecs: Implement IWICColorContext::InitializeFromFilename.

On Wed, 06 Feb 2013 13:51:32 +0100, Hans Leidekker wrote: > +handle = CreateFileW(filename, GENERIC_READ, 0, NULL, > OPEN_EXISTING, 0, NULL); > +if (handle == INVALID_HANDLE_VALUE) return > HRESULT_FROM_WIN32(GetLastError()); Hello Hans, I think, you are hiding a fixme for the default col

Re: [4/4] windowscodecs: Implement IWICComponentFactory::CreateDecoderFromFileHandle.

> +hr = map_file(file, &map, &mem, &size); > +if (FAILED(hr)) return hr; > + ... > + > +hr = IWICStreamImpl_InitializeFromMemory(stream, mem, size.u.LowPart); > +if (FAILED(hr)) goto error; This makes me sad. Is this really simpler than implementing Write and Seek for a file handl

Re: kernel32/tests : added tests for copyfileex try7

Patrick Rudolph writes: > +if( !GetTempPathA( MAX_PATH,tmppath ) ) > +{ > +win_skip("GetTempPathA failed\n"); > +return; > +} > + > +/* create a dummy file for copy tests */ > +if( !GetTempFileNameA( tmppath,"IN",0,source_name ) ) > +{ > +win_skip("

Re: [PATCH] Support a protection scheme which reset the GS selector

Alessandro Pignotti writes: > Hi everyone, > > I've found two different games: > > -) Of orcs and men > -) The testament of sherlock holmes > > which are using a protection scheme which reset the GS segment selector, > possibly to confuse virtual machines. Since on linux the GS selector is > used