Re: iphlpapi: Let C look like C.

2013-02-07 Thread Michael Stefaniuc
Thanks Juan, On 02/07/2013 12:54 AM, Juan Lang wrote: Hi Michael, this isn't actually a problem with your patch, just something I spotted: On Wed, Feb 6, 2013 at 3:15 PM, Michael Stefaniuc mstef...@redhat.com mailto:mstef...@redhat.com wrote: On 02/06/2013 11:16 PM, Austin English

Re: [PATCH v2 0/8] Add O_DENY* support for VFS and CIFS/NFS

2013-02-07 Thread Pavel Shilovsky
2013/2/5 J. Bruce Fields bfie...@fieldses.org: On Tue, Feb 05, 2013 at 03:33:21PM +0400, Pavel Shilovsky wrote: 2013/1/31 J. Bruce Fields bfie...@fieldses.org: On Thu, Jan 17, 2013 at 08:52:09PM +0400, Pavel Shilovsky wrote: This patchset adds support of O_DENY* flags for Linux fs layer.

Re: [PATCH v2 3/8] vfs: Add O_DENYREAD/WRITE flags support for open syscall

2013-02-07 Thread Pavel Shilovsky
2013/2/5 J. Bruce Fields bfie...@fieldses.org: On Tue, Feb 05, 2013 at 03:45:31PM +0400, Pavel Shilovsky wrote: 2013/1/31 J. Bruce Fields bfie...@fieldses.org: On Thu, Jan 17, 2013 at 08:52:59PM +0400, Pavel Shilovsky wrote: If O_DENYMAND flag is specified, O_DENYREAD/WRITE/MAND flags are

Re: [PATCH v2 3/8] vfs: Add O_DENYREAD/WRITE flags support for open syscall

2013-02-07 Thread Pavel Shilovsky
2013/2/7 J. Bruce Fields bfie...@fieldses.org: On Thu, Feb 07, 2013 at 01:53:46PM +0400, Pavel Shilovsky wrote: Nothing prevents it. If somebody grabbed a share mode lock on a file before we call deny_lock_file, we simply close this file and return -ETXTBSY. But leave the newly-created file

Re: [PATCH] gdi32/tests: Skip justification tests where Times New Roman is not installed.

2013-02-07 Thread Alexandre Julliard
Akihiro Sagawa sagawa@gmail.com writes: --- dlls/gdi32/tests/font.c |6 ++ 1 file changed, 6 insertions(+) There's no reason to require Times New Roman in that test, it could fall back to some other font. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH v2 3/8] vfs: Add O_DENYREAD/WRITE flags support for open syscall

2013-02-07 Thread Pavel Shilovsky
2013/2/7 J. Bruce Fields bfie...@fieldses.org: On Thu, Feb 07, 2013 at 06:32:38PM +0400, Pavel Shilovsky wrote: 2013/2/7 J. Bruce Fields bfie...@fieldses.org: On Thu, Feb 07, 2013 at 01:53:46PM +0400, Pavel Shilovsky wrote: Nothing prevents it. If somebody grabbed a share mode lock on a file

Re: [PATCH v2 3/8] vfs: Add O_DENYREAD/WRITE flags support for open syscall

2013-02-07 Thread Pavel Shilovsky
2013/2/7 J. Bruce Fields bfie...@fieldses.org: That would be a bug, I think. E.g. man 3posix open: No files shall be created or modified if the function returns -1. Looking at the code... See the references to FILE_CREATED in atomic_open--looks like that's trying to

Re: [PATCH] winebuild: Use $CCAS to assemble if found

2013-02-07 Thread Charles Davis
On Feb 3, 2013, at 9:36 PM, Alexandre Rostovtsev wrote: On Sun, 2013-02-03 at 20:27 -0700, Charles Davis wrote: If the user doesn't set CCAS--which she doesn't the majority of the time--configure will pick up the first of {clang, gas, as} in the PATH. Are you sure that's what you want?