RE: d3dx9 [patch 1/2]: Implement D3DXSHEvalSphericalLight

2013-03-11 Thread Nozomi Kodama
Hello Any problem with the patch http://source.winehq.org/patches/data/94777 and http://source.winehq.org/patches/data/94776 ? Nozomi.

Re: ntdll: Make msync() asynchronous in NtFlushVirtualMemory (resubmit with real name)

2013-03-11 Thread Mathis Beer
On 03/11/13 21:23, Alexandre Julliard wrote: > Mathis Beer writes: > >> diff --git a/dlls/ntdll/virtual.c b/dlls/ntdll/virtual.c >> index a99bca4..e4f2bb6 100644 >> --- a/dlls/ntdll/virtual.c >> +++ b/dlls/ntdll/virtual.c >> @@ -62,6 +62,10 @@ WINE_DECLARE_DEBUG_CHANNEL(module); >> #define MS_SYN

Re: ntdll: Make msync() asynchronous in NtFlushVirtualMemory (resubmit with real name)

2013-03-11 Thread Alexandre Julliard
Mathis Beer writes: > diff --git a/dlls/ntdll/virtual.c b/dlls/ntdll/virtual.c > index a99bca4..e4f2bb6 100644 > --- a/dlls/ntdll/virtual.c > +++ b/dlls/ntdll/virtual.c > @@ -62,6 +62,10 @@ WINE_DECLARE_DEBUG_CHANNEL(module); > #define MS_SYNC 0 > #endif > > +#ifndef MS_ASYNC > +#define MS_AS

Re: msvcp60: Avoid signed-unsigned integer comparisons

2013-03-11 Thread Andrew Talbot
larmbr zhan wrote: > On Sun, Mar 10, 2013 at 5:48 AM, Andrew Talbot > wrote: >> msvcp60: Avoid signed-unsigned integer comparisons. > > > Hi, Andrew Talbot. > > I find that you are working on these "Avoid signed-unsigned integer > comparisons" things recently. > > I DO agree on that using _

Re: [PATCH v3 5/7] CIFS: Translate SHARING_VIOLATION to -ETXTBSY error code for SMB2

2013-03-11 Thread Pavel Shilovsky
2013/3/11 Jeff Layton : > On Thu, 28 Feb 2013 19:25:31 +0400 > Pavel Shilovsky wrote: > >> to make it match CIFS and VFS variants. >> >> Signed-off-by: Pavel Shilovsky >> --- >> fs/cifs/smb2maperror.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/fs/cifs/smb2maperro

Re: [PATCH v3 2/7] vfs: Add O_DENYREAD/WRITE flags support for open syscall

2013-03-11 Thread Pavel Shilovsky
2013/3/11 Jeff Layton : > On Thu, 28 Feb 2013 19:25:28 +0400 > Pavel Shilovsky wrote: > >> If O_DENYMAND flag is specified, O_DENYREAD/WRITE/MAND flags are >> translated to flock's flags: >> >> !O_DENYREAD -> LOCK_READ >> !O_DENYWRITE -> LOCK_WRITE >> O_DENYMAND -> LOCK_MAND >> >> and set throu

Re: [PATCH v3 0/7] Add O_DENY* support for VFS and CIFS/NFS

2013-03-11 Thread Pavel Shilovsky
2013/3/5 Simo : > On 03/05/2013 01:13 PM, J. Bruce Fields wrote: >> >> On Mon, Mar 04, 2013 at 05:49:46PM -0500, Simo wrote: >>> >>> On 03/04/2013 04:19 PM, J. Bruce Fields wrote: I'm a little more worried: these are mandatory locks, and applications that use them are used to the locks be

Re: ntdll: make NtDelayExecution a bit more efficient

2013-03-11 Thread Graham Knap
Francois Gouget wrote: > I think it's really a three patch series and the first one has the > clearer commit message: > > Made NtDelayExecution with a 0 timeout yield the CPU, as it is > supposed to. I agree that this is the correct behaviour for the "zero timeout" case. The comments that

Re: [2/2] wmvcore: Stub implementation of IWMMetadataEditor interface (try2)

2013-03-11 Thread Nikolay Sivov
On 3/11/2013 16:36, Jeff Latimer wrote: +if (!ppv) return E_INVALIDARG; You don't need this most likely. +IUnknown_AddRef((IUnknown*)*ppv); A cleaner way is to AddRef original iface, but that's a matter of taste. +static ULONG WINAPI WMCreateEditor_AddRef(IWMMetadataEditor *iface) +

Re: [1/2] include: Implement part of nserror.h

2013-03-11 Thread Nikolay Sivov
On 3/11/2013 13:41, Jeff Latimer wrote: On 11/03/13 17:43, Nikolay Sivov wrote: On 3/11/2013 10:27, Jeff Latimer wrote: --- include/nserror.h | 226 ++ 1 file changed, 226 insertions(+) create mode 100644 include/nserror.h +#ifndef _NSERR

Re: [1/2] include: Implement part of nserror.h

2013-03-11 Thread Jeff Latimer
On 11/03/13 17:43, Nikolay Sivov wrote: > On 3/11/2013 10:27, Jeff Latimer wrote: >> --- >> include/nserror.h | 226 >> ++ >> 1 file changed, 226 insertions(+) >> create mode 100644 include/nserror.h >> +#ifndef _NSERROR_H >> +#define _NSERRO