Re: [PATCH 1/2] extrac32: Add /D switch support.

2013-04-22 Thread Alexandre Julliard
Sergey Guralnik ser...@etersoft.ru writes: @@ -202,6 +228,9 @@ int PASCAL wWinMain(HINSTANCE hInstance, HINSTANCE prev, LPWSTR cmdline, int sho WCHAR path[MAX_PATH]; LPCWSTR cabfile = NULL; +extr_printf = (void*)GetProcAddress(LoadLibraryA(msvcrt), printf); +

Re: [PATCH 1/3] d3dx9_36: Add support for DIB file in D3DXGetImageInfoFromFileInMemory.

2013-04-22 Thread Alexandre Julliard
Christian Costa titan.co...@gmail.com writes: +if (header_size == sizeof(BITMAPINFOHEADER)) +{ +BITMAPINFOHEADER *header = (BITMAPINFOHEADER*)*data; +ULONG count = header-biClrUsed; + +if (!count header-biBitCount = 8) +count = 1

Application for GSoC 2013 - improve Richedit

2013-04-22 Thread Jactry Zeng
Hi folks, I am Jactry Zeng, a sophomore majoring in Electronic Science from China. My nickname in #winehackers is Jactry. I would like to apply for this year's GSoC to work for wine. I have reported some bugs[1] of wine and submitted a few easy patches[2] for wine. And I feel quite good to study

Re: [PATCH 1/3] d3dx9_36: Add support for DIB file in D3DXGetImageInfoFromFileInMemory.

2013-04-22 Thread Christian Costa
Wich DIB types ? Are you referring to BI_BITFIELDS compression ? I just looked at windows codecs code and there this code to handle color masks: /* if this is a BITMAPINFOHEADER with BI_BITFIELDS compression, we need to read the extra fields */ if (This-bih.bV5Size ==

Re: [PATCH 1/2] wined3d: Remove leftover texture accesses in GLSL shader generation

2013-04-22 Thread Henri Verbeet
On 21 April 2013 16:51, Stefan Dösinger ste...@codeweavers.com wrote: -if (texture texture-target == GL_TEXTURE_RECTANGLE_ARB) -sample_flags |= WINED3D_GLSL_SAMPLE_RECT; +if (priv-cur_ps_args-np2_fixup (1 sampler_idx)) +{ +sample_flags |=

Re: [PATCH 1/2] wined3d: Remove leftover texture accesses in GLSL shader generation

2013-04-22 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-04-22 14:42, schrieb Henri Verbeet: On 21 April 2013 16:51, Stefan Dösinger ste...@codeweavers.com wrote: -if (texture texture-target == GL_TEXTURE_RECTANGLE_ARB) -sample_flags |= WINED3D_GLSL_SAMPLE_RECT; +if

Re: [PATCH 1/2] wined3d: Remove leftover texture accesses in GLSL shader generation

2013-04-22 Thread Henri Verbeet
On 22 April 2013 14:48, Stefan Dösinger ste...@codeweavers.com wrote: Personally I don't like ifs without braces if either the condition or the instruction is spread over more than one line. Well, I do disagree, but note that that reasoning doesn't actually apply here, both are single-line.

Re: [PATCH 1/2] wined3d: Remove leftover texture accesses in GLSL shader generation

2013-04-22 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-04-22 14:54, schrieb Henri Verbeet: On 22 April 2013 14:48, Stefan Dösinger ste...@codeweavers.com wrote: Personally I don't like ifs without braces if either the condition or the instruction is spread over more than one line. Well, I

Re: [user32] Add DECLSPEC_NOINLINE, use it on call_hook_proc()

2013-04-22 Thread Qian Hong
On Sat, Apr 20, 2013 at 1:38 AM, Dan Kegel d...@kegel.com wrote: I tried explicitly add 'inline' to every static functions in hook.c but complie with -O0, to see if the bug can be reproduced in this way, but nothing happen, this make me doubt being inline is not the culprit. call_hook_proc

kernel32/path: Potential off-by-one error, help needed!

2013-04-22 Thread Kirill Smirnov
Hi! While debugging bug #33307 (http://bugs.winehq.org/show_bug.cgi?id=33307) I found a suspicious piece of code, looking like off-by-one error. Unfortunately, I'm not familiar with this part of wine and I don't know how to write corresponding test case. If you familiar with

Re: Application for GSoC 2013 - improve Richedit

2013-04-22 Thread André Hentschel
Am 22.04.2013 12:51, schrieb Jactry Zeng: Hi folks, I am Jactry Zeng, a sophomore majoring in Electronic Science from China. My nickname in #winehackers is Jactry. I would like to apply for this year's GSoC to work for wine. I have reported some bugs[1] of wine and submitted a few easy

Re: Wine History

2013-04-22 Thread Scott Ritchie
On 04/20/2013 05:50 PM, André Hentschel wrote: Hi, meanwhile everyone should know that Wine turns 20 this year. AJ said in this years Keynote we'll need to find a way to celebrate this in June. So i did some research on this and found Wine History mails by Dan Kegel from 2002 and much

Re: user32: add assembly wrapper for calling hook procedures.

2013-04-22 Thread James Eder
Dan, the patch doesn't build for 64-bit Wine. On the #else side you have an unwanted semicolon. -- Jim

Re: user32: add assembly wrapper for calling hook procedures.

2013-04-22 Thread Dan Kegel
Thanks. I saw the 'doesn't apply' status at source.winehq.org/patches, so was going to take another look tonight. On Mon, Apr 22, 2013 at 4:40 PM, James Eder jimpor...@gmail.com wrote: Dan, the patch doesn't build for 64-bit Wine. On the #else side you have an unwanted semicolon. -- Jim

Re: kernel32/path: Potential off-by-one error, help needed!

2013-04-22 Thread Ken Thomases
On Apr 22, 2013, at 1:17 PM, Kirill Smirnov wrote: While debugging bug #33307 (http://bugs.winehq.org/show_bug.cgi?id=33307) I found a suspicious piece of code, looking like off-by-one error. Unfortunately, I'm not familiar with this part of wine and I don't know how to write

Re: [PATCH 2/2] gdi32: Clip font glyphs to fit within text metrics.

2013-04-22 Thread Sam Edwards
On 04/19/2013 10:32 AM, Max TenEyck Woodbury wrote: As I understand it, some fonts deliberately have glyphs larger than their metrics bounding boxes. Clipping them is almost certainly not a good idea. Forgive my disbelief, but can you provide an example? It seems like Windows has the same

Re: [PATCH 2/2] gdi32: Clip font glyphs to fit within text metrics.

2013-04-22 Thread Ken Thomases
On Apr 22, 2013, at 6:40 PM, Sam Edwards wrote: On 04/19/2013 10:32 AM, Max TenEyck Woodbury wrote: As I understand it, some fonts deliberately have glyphs larger than their metrics bounding boxes. Clipping them is almost certainly not a good idea. Forgive my disbelief, but can you