Re: [PATCH] ws2_32: Automatically sets a socket to non-blocking mode when WSAAsyncSelect or WSAEventSelect is called.

2013-05-20 Thread Dmitry Timoshkov
Qian Hong qh...@codeweavers.com wrote: Fixed http://bugs.winehq.org/show_bug.cgi?id=33076 Reference: http://msdn.microsoft.com/en-us/library/windows/desktop/ms741621%28v=vs.85%29.aspx See also comment in WSAIoctl: /* AsyncSelect()'ed sockets are always nonblocking */ This change

Re: [PATCH] ws2_32: Automatically sets a socket to non-blocking mode when WSAAsyncSelect or WSAEventSelect is called.

2013-05-20 Thread Qian Hong
Hi Dmitry, On Mon, May 20, 2013 at 6:13 PM, Dmitry Timoshkov dmi...@baikal.ru wrote: This change requires a test case, MSDN is often wrong, so its claims at least need to be very carefully checked. Thanks for the comment, actually I already guess you will point out it requires a test :) There

Re: [PATCH] ws2_32: Automatically sets a socket to non-blocking mode when WSAAsyncSelect or WSAEventSelect is called.

2013-05-20 Thread Dmitry Timoshkov
Qian Hong qh...@codeweavers.com wrote: Thanks for the comment, actually I already guess you will point out it requires a test :) There is no win32 api to detect whether a socket is blocking or non-blocking, do you have any advice how to test it in our Wine test framework?

Re: [PATCH] ws2_32: Automatically sets a socket to non-blocking mode when WSAAsyncSelect or WSAEventSelect is called.

2013-05-20 Thread Qian Hong
On Mon, May 20, 2013 at 7:02 PM, Dmitry Timoshkov dmi...@baikal.ru wrote: Qian Hong qh...@codeweavers.com wrote: MSDN page you referenced has a hint how this behaviour could be tested: The WSAAsyncSelect or WSAEventSelect routine automatically sets a socket to non-blocking mode. If

Re: [PATCH] ws2_32: Automatically sets a socket to non-blocking mode when WSAAsyncSelect or WSAEventSelect is called.

2013-05-20 Thread Dmitry Timoshkov
Qian Hong qh...@codeweavers.com wrote: The above description implies two behaviors: A: 'The WSAAsyncSelect or WSAEventSelect routine automatically sets a socket to non-blocking mode' B: 'any attempt to use WSAIoctl to set the socket back to blocking mode will fail with WSAEINVAL'

Re: oledb32: Support DBSTATUS_S_ISNULL when converting to VARIANT

2013-05-20 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25629 Your paranoid

Re: [PATCH] ws2_32: Automatically sets a socket to non-blocking mode when WSAAsyncSelect or WSAEventSelect is called.

2013-05-20 Thread Qian Hong
On Mon, May 20, 2013 at 7:53 PM, Dmitry Timoshkov dmi...@baikal.ru wrote: I'd test it like the following: 1. create a socket 2. check that WSAIoctl works 3. call WSAAsyncSelect/WSAEventSelect 4. check that WSAIoctl fails 5. set the socket back to blocking mode using described technique 6.

Re: msvcm80: Remove pre-attach handler for a dll with manifest.

2013-05-20 Thread Alexandre Julliard
Dmitry Timoshkov dmi...@baikal.ru writes: Manifest prevents loading of a native dll anyway. Not if it's installed globally. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH 6/6] d3d9/tests: d3d9ex video memory accounting tests

2013-05-20 Thread Austin English
On Wed, May 15, 2013 at 3:32 AM, Henri Verbeet hverb...@gmail.com wrote: On 14 May 2013 23:46, Stefan Dösinger ste...@codeweavers.com wrote: These tests have the potential to break on Windows when other applications create or release a large number of video memory resources while the test is

Re: [PATCH 6/6] d3d9/tests: d3d9ex video memory accounting tests

2013-05-20 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-05-20 23:03, schrieb Austin English: On Wed, May 15, 2013 at 3:32 AM, Henri Verbeet hverb...@gmail.com wrote: On 14 May 2013 23:46, Stefan Dösinger ste...@codeweavers.com wrote: These tests have the potential to break on Windows when

Re: [PATCH] Tests that prove ntdll has no notion of HKCR.

2013-05-20 Thread Juan Lang
Hi George, static void test_classesroot(void) { +static const WCHAR reg_user[] = { '\\','R','E','G','I','S','T','R','Y','\\','U','S','E','R' }; +static const WCHAR reg_machine[] = { '\\','R','E','G','I','S','T','R','Y','\\','M','A','C','H','I','N','E' }; Almost, but these have to

Re: windowscodecs: Add support for IMILBitmapSource interface.

2013-05-20 Thread Charles Davis
On May 19, 2013, at 9:14 PM, Dmitry Timoshkov wrote: diff --git a/dlls/windowscodecs/bitmap.c b/dlls/windowscodecs/bitmap.c index f8904df..646f3a7 100644 --- a/dlls/windowscodecs/bitmap.c +++ b/dlls/windowscodecs/bitmap.c @@ -446,6 +471,226 @@ static const IWICBitmapVtbl BitmapImpl_Vtbl = {

Re: windowscodecs: Add support for IMILBitmapSource interface.

2013-05-20 Thread Dmitry Timoshkov
Charles Davis cdavi...@gmail.com wrote: You're violating COM rules here: when you QI an object for an interface pointer, the QI must always return the same result no matter what. Here, however, you're returning this interface pointer in response to a query for IUnknown, when the

Re: Alexandre Julliard : msvcrt: Don't bother to clean up at process exit.

2013-05-20 Thread Dmitry Timoshkov
Alexandre Julliard julli...@winehq.org wrote: case DLL_PROCESS_DETACH: -msvcrt_free_popen_data(); msvcrt_free_io(); +if (lpvReserved) break; +msvcrt_free_popen_data(); msvcrt_free_mt_locks(); msvcrt_free_console(); msvcrt_free_args(); Shouldn't

Re: [1/4] server: Add support for console font size, maximum window size, etc.

2013-05-20 Thread Dmitry Timoshkov
Hugh McMaster hugh.mcmas...@masterindexing.com wrote: This patch modifies server/protocol.def and server/console.c to add support for console font size detection and console window size rendering. It also tidies up a few inconsistencies in the repeated usage of aspects of the screen buffer

RE: [1/4] server: Add support for console font size, maximum window size, etc.

2013-05-20 Thread Hugh McMaster
My reasoning was that the order of appearance from the screen buffer struct should be the same each time. The patch adds uniformity, but if that is not wanted, then so be it. Some of the formatting changes are necessary however, because some of the server operations are performed in a specific

Troubles configuring and building wine-1.5.30 on Debian wheezy

2013-05-20 Thread Alan W. Irwin
My use case is building and testing software packages on Wine. My 32-bit build of wine-1.5.19 on x86_64 hardware was fine for this purpose for MinGW/MSYS builds so I stuck with it until today when I attempted to expand my building and testing of software to the Cygwin on Wine platform. I

Re: Troubles configuring and building wine-1.5.30 on Debian wheezy

2013-05-20 Thread Hugh McMaster
On Monday May 20 at 22:24:58, Alan W. Irwin wrote: wine at raven wine64 wine64: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory Hi Alan, This error is caused by a regression in Wine 1.5.30. It is not present in version 1.5.29. The