re: Increment, Decrement, and Assignment Operators

2013-05-28 Thread Dan Kegel
Watch http://source.winehq.org/patches/ for your patch's status (see legend at bottom). It might be rejected since it doesn't actually fix any behavioral problem in Wine. IIRC trivial cleanups in code are frowned upon, especially if they cross many modules. Better to pick some small real problem

Re: gdi32/tests: Do not try to test OS/2 win metrics on non-windows fonts

2013-05-28 Thread Dmitry Timoshkov
Aric Stewart wrote: > +ascent = GET_BE_WORD(tt_os2.usWinAscent); > +descent = GET_BE_WORD(tt_os2.usWinDescent); > +cell_height = ascent + descent; > +ok(ntm->ntmCellHeight == cell_height, "%s: ntmCellHeight %u != %u, > os2.usWinAscent/os2.usWinDescent %u/%u\n", >

Re: [PATCH] winhttp: initialize schemes (Coverity) (resubmit)

2013-05-28 Thread Hans Leidekker
On Tue, 2013-05-28 at 22:46 +0200, Marcus Meissner wrote: > 1020943 Uninitialized scalar variable > > schemes is |= in the called function, but not > initialized before. > > Was submitted 2 weeks ago already, I think it is good. It's good but query_auth_schemes is called from more places, so i

Re: [PATCH] dsound: Copy SetFormat format more directly if we're not in PRIMARYWRITE mode

2013-05-28 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25741 Your paranoid android

Re: [5/5] kernel32: Don't move fixed memory area in GlobalReAlloc. (try 2)

2013-05-28 Thread Alexandre Julliard
Akihiro Sagawa writes: > This closes bug 14819. > > try 2: > * tests/heap.c was updated to avoid dependency on heap reallocation > strategies. > * Use HeapAlloc instead of LocalAlloc in some places. In those cases, > they want large memory blocks, not pinned memory addresses. They are using LM

Re: dxgi, directx 11 and code duplication

2013-05-28 Thread Henri Verbeet
On 28 May 2013 00:36, John Yani wrote: > Hi. I'm trying to set up a minimal implementation that will allow to run > Assasin's Creed III. It's somewhat unlikely that you'll be able to make the game work just by implementing these functions, your best chance in that regard may be to disable dxgi in