riched20: ITextDocument implementation

2013-06-26 Thread Tiger Soldier
As bug 17042 [1] reported, the IUnknown object returned by CreateTextServices() does not support ITextDocument. I believe that's the root cause of some apps crash. richole.c has a very limited implementation of ITextDocument for IRichEditOle, which is totally unreusable. I'm trying to implement

Re: [PATCH] wined3d: Implement per-stage constant in glsl fixed fonction pipeline.

2013-06-26 Thread Henri Verbeet
On 25 June 2013 18:26, Stefan Dösinger stefandoesin...@gmail.com wrote: While I agree with Henri's statement to some extend - patch reviewing is a terribly exhausting task - I think the statement was a bit harsh to say to someone who donates his personal time to the project. Well, I could try

Re: wined3d: print the architecture when showing driver problems

2013-06-26 Thread Henri Verbeet
On 26 June 2013 03:53, Austin English austinengl...@gmail.com wrote: My understanding was that using the _WIN64 macro was preferred. I can certainly do that instead. How's this? I could probably live with that, though perhaps make it a helper function, and I'm not entirely sure this will print

Re: riched20: ITextDocument implementation

2013-06-26 Thread Qian Hong
Hi, Welcome again :) On Wed, Jun 26, 2013 at 3:11 PM, Tiger Soldier tigerso...@gmail.com wrote: This is my first time to develop WINE. Any comments/suggestions? [1] http://bugs.winehq.org/show_bug.cgi?id=17042 Improving Rich Edit is great appreciated! Interesting, one of GSoC2013 students

Re: po: Update Ukrainian translation

2013-06-26 Thread Nikolay Sivov
On 6/26/2013 13:10, Микола wrote: Hi, please resubmit this patch with your full name transliterated in English.

Re: server: Update German translation of manpage.

2013-06-26 Thread Julian Rüger
Am Dienstag, den 25.06.2013, 19:41 +0200 schrieb Alexandre Julliard: Julian Rüger j...@gmx.net writes: I'm unsure about the second line. Is that supposed to be the last modified date of the manpage, the wineserver or what? The English version says October 2005. In general, it would be

Re: [PATCH] wined3d: Implement per-stage constant in glsl fixed fonction pipeline.

2013-06-26 Thread Christian Costa
Le 26/06/2013 09:10, Henri Verbeet a écrit : On 25 June 2013 18:26, Stefan Dösinger stefandoesin...@gmail.com wrote: While I agree with Henri's statement to some extend - patch reviewing is a terribly exhausting task - I think the statement was a bit harsh to say to someone who donates his

Re: widl: Do not generate C structure for empty interfaces.

2013-06-26 Thread André Hentschel
Hi, The whitespace changes are bad, please don't do that.

Re: widl: Do not generate C structure for empty interfaces.

2013-06-26 Thread Thomas Faber
On 2013-06-26 21:47, André Hentschel wrote: The whitespace changes are bad, please don't do that. Ok, I can take them out no problem. Why's it bad though? I thought the rule was fix it while you're working on it anyway.

Re: widl: Do not generate C structure for empty interfaces.

2013-06-26 Thread André Hentschel
On 26.06.2013 22:06, Thomas Faber wrote: On 2013-06-26 21:47, André Hentschel wrote: The whitespace changes are bad, please don't do that. Ok, I can take them out no problem. Why's it bad though? I thought the rule was fix it while you're working on it anyway. Mostly because you mess up

Re: widl: Do not generate C structure for empty interfaces.

2013-06-26 Thread Michael Stefaniuc
On 06/26/2013 10:06 PM, Thomas Faber wrote: On 2013-06-26 21:47, André Hentschel wrote: The whitespace changes are bad, please don't do that. Ok, I can take them out no problem. Why's it bad though? I thought the rule was fix it while you're working on it anyway. Sure, fix the lines you

Re: Bug 24018 which appears to be a showstopper for running Cygwin on Wine

2013-06-26 Thread Hin-Tak Leung
--- On Tue, 25/6/13, Alan W. Irwin ir...@beluga.phys.uvic.ca wrote: snipped I currently have no experience with Cygwin and my only real interest in Cygwin on Wine is it theoretically provides an alternative build platform to my present successful work with the combination of MinGW, MSYS,

Re: oleaut32/tests: Use bool instead of int when appropriate

2013-06-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26136 Your paranoid

Re: oleaut32/tests: Use bool instead of int when appropriate

2013-06-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26136 Your paranoid

Re: Bug 24018 which appears to be a showstopper for running Cygwin on Wine

2013-06-26 Thread Alan W. Irwin
On 2013-06-26 23:43+0100 Hin-Tak Leung wrote: --- On Tue, 25/6/13, Alan W. Irwin ir...@beluga.phys.uvic.ca wrote: snipped I currently have no experience with Cygwin and my only real interest in Cygwin on Wine is it theoretically provides an alternative build platform to my present successful

Re: widl: Do not generate C structure for empty interfaces.

2013-06-26 Thread Thomas Faber
On 2013-06-26 22:49, André Hentschel wrote: On 26.06.2013 22:06, Thomas Faber wrote: On 2013-06-26 21:47, André Hentschel wrote: The whitespace changes are bad, please don't do that. Ok, I can take them out no problem. Why's it bad though? I thought the rule was fix it while you're working