Re: Re: apphelp: Implement SdbTagToString.

2013-08-01 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26567 Your paranoid

Re: oledb32: Add IDataSourceLocator support

2013-08-01 Thread Alistair Leslie-Hughes
Ignore this patch On 1/08/2013 6:36 PM, Alistair Leslie-Hughes wrote: Hi, Changelog: oledb32: Add IDataSourceLocator support Best Regards Alistair Leslie-Hughes

Re: windowscodecs: Workaround libtiff bug when it defines toff_t as 32-bit for 32-bit builds. Take 3.

2013-08-01 Thread Alexandre Julliard
Dmitry Timoshkov dmi...@baikal.ru writes: @@ -208,9 +233,22 @@ static TIFF* tiff_open_stream(IStream *stream, const char *mode) zero.QuadPart = 0; IStream_Seek(stream, zero, STREAM_SEEK_SET, NULL); +/* Workaround for broken libtiff 4.x headers on some 64-bit hosts which +

RE: Possibility of adding a new patch status

2013-08-01 Thread Hugh McMaster
* The patch is difficult to review, and he's putting it off. There are some statuses (e.g. 'needs splitting) to counteract this. But patches are/can be difficult to review. Again, a status such as 'Not yet reviewed' would help. * He's travelling and does not have access to a machine

Re: [PATCH 2/2] ddraw: Fix double to float conversion warnings

2013-08-01 Thread Henri Verbeet
On 1 August 2013 12:25, Stefan Dösinger ste...@codeweavers.com wrote: diff --git a/dlls/ddraw/executebuffer.c b/dlls/ddraw/executebuffer.c index 2925cfa..5c12272 100644 --- a/dlls/ddraw/executebuffer.c +++ b/dlls/ddraw/executebuffer.c @@ -382,10 +382,10 @@ HRESULT

reg.exe: Add query function

2013-08-01 Thread Hugh McMaster
This patch significantly builds on the query function stub in programs/reg.exe. The patch includes recursion for subkeys. Some examples of usage: wine reg.exe query HKCU wine reg.exe query HKCU\Console wine reg.exe query HKCU\Console /v ScreenSize wine reg.exe query HKCU\Software /s ---

Re: reg.exe: Add query function

2013-08-01 Thread Bruno Jesus
On Thu, Aug 1, 2013 at 10:39 AM, Hugh McMaster hugh.mcmas...@masterindexing.com wrote: This patch significantly builds on the query function stub in programs/reg.exe. The patch includes recursion for subkeys. The patch was sent to wine-devel. Some examples of usage: wine reg.exe query HKCU

RE: reg.exe: Add query function

2013-08-01 Thread Hugh McMaster
On Thursday, 1 August 2013 11:43 PM, Bruno Jesus wrote: The patch was sent to wine-devel. Yes, you're right. Apologies for that. I've now submitted the patch to wine-patches.

Re: reg.exe: Add query function

2013-08-01 Thread Nikolay Sivov
On 8/1/2013 17:44, Hugh McMaster wrote: This patch builds significantly on the query function stub in programs/reg.exe. The patch includes recursion for subkeys. Some examples of usage: wine reg.exe query HKCU wine reg.exe query HKCU\Console wine reg.exe query HKCU\Console /v ScreenSize wine

Re: [PATCH 1/4] d3dx9: Track ID3DXEffect::Begin/End().

2013-08-01 Thread Bruno Jesus
On Thu, Aug 1, 2013 at 9:14 AM, Rico Schüller kgbric...@web.de wrote: --- dlls/d3dx9_36/effect.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) +if (!This-started) +return D3D_OK; + +This-started = FALSE; + +return D3D_OK; Sorry to bother but

Re: [PATCH 4/5] d3dx9/tests: Add ID3DXConstantTable struct test.

2013-08-01 Thread Matteo Bruni
2013/8/1 Rico Schüller kgbric...@web.de: On 31.07.2013 00:14, Matteo Bruni wrote: 2013/7/30 Rico Schüller kgbric...@web.de: Hi Matteo, please see the attached patch. On 25.07.2013 16:13, Matteo Bruni wrote: 2013/7/24 Rico Schüller kgbric...@web.de: ---

Re: [PATCH 1/11] apphelp: Add definitions.

2013-08-01 Thread Alexandre Julliard
Mislav Blazevic krofnica...@gmail.com writes: @@ -25,6 +26,209 @@ extern C { BOOL WINAPI ApphelpCheckShellObject(REFCLSID, BOOL, ULONGLONG *); +typedef enum _PATH_TYPE { +DOS_PATH, +NT_PATH +} PATH_TYPE; + +typedef struct _DB { +HANDLE file; +DWORD size; +PBYTE

Re: d3dx9 [patch 1/2]: Implement D3DXCreatePolygon

2013-08-01 Thread Matteo Bruni
2013/8/1 Nozomi Kodama nozomi.kod...@yahoo.com: +vertices = HeapAlloc(GetProcessHeap(), 0, 2 * (sides + 1) * sizeof(D3DXVECTOR3)); +if (!vertices) +{ +TRACE(Not memory enough for vertex buffer\n); +polygon-lpVtbl-Release(polygon); +return E_OUTOFMEMORY; +}

Re: [PATCH 1/4] d3dx9: Track ID3DXEffect::Begin/End().

2013-08-01 Thread Rico Schüller
On 01.08.2013 15:58, Bruno Jesus wrote: On Thu, Aug 1, 2013 at 9:14 AM, Rico Schüller kgbric...@web.de wrote: --- dlls/d3dx9_36/effect.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) +if (!This-started) +return D3D_OK; + +This-started = FALSE; + +

Re: [11/11] apphelp: Add tests.

2013-08-01 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26579 Your paranoid

Clang warns on wrong header guard in config.h

2013-08-01 Thread Charles Davis
Hi, I've been building Wine with Clang, and it (apparently, unlike GCC) produces warnings like this: ../../include/config.h:4:9: warning: 'WINE_CROSSTEST' is used as a header guard here, followed by #define of a different macro [-Wheader-guard] #ifndef WINE_CROSSTEST