2012/12/6 Alexandre Julliard :
> If you can't think of anything to test beyond the handful of cases you
> already have, then you shouldn't be implementing that function. There's
> no hope that your code will be able to cope with invalid input if you
> can't even imagine what invalid input could loo
2012/12/5 Alexandre Julliard :
> You have nowhere near enough tests to make such a claim. When I said to
> write more tests, I didn't mean one or two more. You'd probably need at
> least 100 tests to have decent coverage of all the interesting cases.
It's not as much of a technical problem as it i
Correction: Item 3 should have been "Put the code in kernel32."
-Alex
2012/12/4 Alexandre Julliard :
> Alex Henrie writes:
>
>> My implementation is modeled after Windows XP (Wine's default target
>> Windows version), which encodes and decodes arbitrary character
>> sequences without normalization. I saw that my submission has already
&
2012/12/4 Frédéric Delanoy :
> The above MSDN comment indicates pre-Vista versions are buggy, so it's
> probably not a good idea to match that behaviour.
I think encoding and decoding in UTF-7 arbitrary binary data was
considered a "feature" in Windows XP. As MSDN said, "Code written in
earlier ve
2012/12/2 Dmitry Timoshkov :
> Why don't you put it in libs/wine where other unicode conversion routines
> are implemented?
Before I started this project I asked where to put the functions:
http://www.winehq.org/pipermail/wine-devel/2012-January/093705.html
I received no reply, so I put them in l
2012/9/3 Alexandre Julliard :
> You don't have a single test with an explicit source length, so
> obviously you are not going to find problems in that area. Like I said,
> you need a lot more tests.
example_2 already tests an explicit source length. In all the other
examples srclen = strlen(src) +
Correction: I meant to write that try 4 exits the loop slightly faster when
ending a base64 sequence, it has nothing to do with escaped plus signs
which are handled a few lines earlier.
-Alex
To use serial ports on Linux, your user must be a member of the "dialout"
group.
-Alex
2012/7/23 Austin English :
> Judging by similar recent commits
> (http://source.winehq.org/git/wine.git/commitdiff/f320f6cf4843eab3d22b60674808e4e3de964b5a),
> 1 seems to be the way to go.
Thanks for the answer. What makes me uneasy about this approach is
that if I want to duplicate the tests for
Dear Wine developers,
Bug 24389 documents an application crash due to the unimplemented
function msvcr90._wtoi_l. I have been looking into how to resolve this
problem. I see three workable options:
1. Implement msvcr90._wtoi_l by copying the code from ntdll._wtoi to
msvcrt, ignoring the locale pa
2012/7/19 Austin English :
> Why didn't you include the tests in the patch?
The "tests" I wrote always fail in order to output the result of the
function to the console for comparison by hand. ICU_ESCAPE is clearly
not meant to be used with InternetCanonicalizeUrl, so I'm not sure a
test for it is
2012/6/25 Erich E. Hoover :
> I know that for a while there were some packaging problems that meant that
> upgrading to 12.04 made compiling 32-bit Wine on a 64-bit PC extremely
> difficult. Is this still the case?
I've spent several hours on this over the past few days and rewrote
the wiki page
Here is an example:
http://www.winehq.org/pipermail/wine-patches/2011-December/109805.html
http://www.winehq.org/pipermail/wine-devel/2011-December/093517.html
http://source.winehq.org/git/wine.git/commitdiff/6e5bba1b60f97fce34415ea30ebecd5bd20dae20
-Alex
Hello,
This patch was marked committed yesterday--thank you for accepting
it!--but it still isn't showing up in Git. Maybe it was accidentally
skipped? It needs to be committed before I can submit the UTF-7
implementation I wrote that builds on it.
-Alex
2012/5/10 Juan Lang :
> Hi Alex,
> first, thanks for taking the time to respond to feedback. Showing
> responsiveness helps a great deal.
You're welcome :-)
> These helpers don't really gain you anything here, there's really not
> enough code to be worth using helpers. Please just copy/paste th
2012/5/10 Nikolay Sivov :
>> Which file should I have used?
>
> codepage.c, you could search all test files for a thing you're trying to
> add.
Okay, I've moved the tests to codepage.c in try 4. Thanks for the tip,
I'll keep that in mind from now on.
> Nothing really changed in try3, test helpers
2012/5/9 Nikolay Sivov :
> Does any application depend on that?
Probably. Better safe than sorry, and Wine's current behavior
definitely doesn't match what MSDN says nor what Windows actually
does.
>> dlls/kernel32/locale.c | 38 ++---
>> dlls/kernel32/tests/locale.c | 94
>
2012/5/8 Alexandre Julliard :
> That code is hopelessly ugly, and broken in various ways. You are
> probably better off starting from scratch.
Okay. Could we use the POSIX iconv functions? Why doesn't Wine use
iconv for UTF-8 already?
-Alex
2012/5/7 Ben Klein :
> Without being a regular contributor, here are a few tips from a cursory
> glance:
> 1) Whitespace change on at least one line
The only change to whitespace I made was:
- if( flags)
+ if (flags)
I don't think this is a big deal.
> 2) Why the change from ERRO
Hi all,
Could I get some feedback on
http://source.winehq.org/patches/data/85898 ? It was marked "Rejected"
a week ago without explanation.
Most of the code was authored by Katayama Hirofumi, whose patches have
been accepted into Wine before. He gave permission to use his code
under the LGPL at h
#: ieframe.rc:68 winhlp32.rc:66
msgid "Print..."
-msgstr "Imprimeix"
+msgstr "Imprimeix..."
I intentionally left the ellipse off of the word "Imprimeix" in
Internet Explorer so that the text would fit on the toolbar button.
Any suggestions?
-Alex
Hello,
I have been thinking about implementing UTF-7 support in
MultiByteToWideChar and WideCharToMultiByte. The guts of the code that
needs to be added have already been posted to bug 27388. What more
needs to be done? Should a libs/wine/utf7.c file be created for the
new functions, similar to li
2011/12/20 Marvin :
> === TEST64_W7SP1 (32 bit filedlg) ===
> filedlg: unhandled exception c005 at 75AF1AC3
I submitted the exact same patch to Marvin 15 minutes before and no
errors were reported:
http://testbot.winehq.org/JobDetails.pl?Key=16076
I think this is a problem with Marvin, not my
Thanks for the feedback. It looks like Alexandre widened the buffer to
64 characters when he committed the patch.
-Alex
I took a closer look at Windows Notepad and discovered that while the
Find and Replace dialogs do not have system menu icons, they do have
system menus accessible by Alt+Space. So these two patches aren't the
solution after all.
I came up with a new patch that seems to fix the problem properly and
Does anyone have an idea of what could be causing
http://bugs.winehq.org/show_bug.cgi?id=29027 ?
-Alex
Hello,
Last week I submitted a patch to make kernel32 output an error message
in UTF-8 rather than the current codepage. This fixed a bug in which
the command "wine /." would produce a garbled error message in
languages other than English. However, thinking about this some more,
I'm not sure that
2011/9/29 David Kiefer :
> A possible solution is to have MapColor call GetNearestIndex as a last
> resort instead. This both fixes the problem and results in acceptable
> performance.
Thanks for the tip. I've submitted a new patch which uses this
solution instead, and it works better.
2011/9/29
2011/9/28 Alex Henrie
> I figured that it didn't work because I wasn't subscribed to wine-devel
>
I meant to say, it didn't work because I wasn't subscribed to
wine-patches...
-Alex
2011/9/28 Frédéric Delanoy
> Please do not include bug number in commit message summary line.
> Put something like 'fixes bug 123 in the commit header
>
> See http://wiki.winehq.org/SubmittingPatches for more info (e.g.
> "subject line" and "include a description" sections)
>
Thanks for the info
31 matches
Mail list logo
