Thanks a lot for your hints, Reece and Dmitry. I didn't realize the
difference between WndProcs and DlgProcs.
I send a new try and hope everything is okay now :)
http://www.winehq.org/pipermail/wine-patches/2008-December/066762.html
--
Andre
2008/12/27 Dmitry Timoshkov dmi...@codeweavers.com:
Andre Wisplinghoff andre.wisplingh...@gmail.com wrote:
+INT_PTR CALLBACK
+comboedit_wndproc (HWND hEdit, UINT uMsg, WPARAM wParam, LPARAM lParam)
INT_PTR is wrong return value type for a window proc.
so it should be HRESULT? INT_PTR
/interviews/interview_12.xml |2 +-
wwn/en/interviews/interview_14.xml |2 +-
wwn/en/interviews/interview_15.xml |2 +-
wwn/en/interviews/interview_6.xml |2 +-
wwn/en/interviews/interview_9.xml |2 +-
7 files changed, 7 insertions(+), 7 deletions(-)
--
Andre Wisplinghoff
--- a/wwn
Hi all,
i need some feedback for my submitted patch (winecfg: Add a dll
override instead of closing the dialog on pressing
return in the combobox at 'libraries' tab):
http://www.winehq.org/pipermail/wine-patches/2008-December/066619.html
Thank you and Happy Holidays!!
-- Andre Wisplinghoff
Paul Vriens wrote:
Just some things that caught my attention:
Could you trim the length for some of the lines somewhat? I also don't think
you
need all those comments in the first call to ToUnicode.
There is a C++ comment in the patch, should be avoided.
And as a last one, is it
Nikolay Sivov wrote:
You should use dynamic linking here (GetProcAddress).
Is this necessary even though the function is there on 9x - returning
unimplemented - as Paul wrote? I think you would need to do this if the
function weren't there at all on some systems.
Best Regards
-- Andre
Hallo,
thanks for your help. I just resend my patch, with these issues
considered. The standard MessageBox function is now used. The localized
message is read in framewnd.c and errors treated the same way as it was
with the messagebox function in edit.c.
Best Regards
- Andre Wisplinghoff
Hallo,
my patch [1] wasn't applied. Can anyone give me a hint what wasn't OK with
it?
Thanks for your time.
Best Regards
- Andre Wisplinghoff
[1] http://www.winehq.org/pipermail/wine-patches/2008-July/057227.html