unsubscribe banana67

2004-03-09 Thread Andrew de Quincey

Re: menu: Fix for menu tracking problem version 2

2003-12-12 Thread Andrew de Quincey
On Friday 12 December 2003 06:03, Alexandre Julliard wrote: > Andrew de Quincey <[EMAIL PROTECTED]> writes: > > Do you think such a thing should be implemented in wineserver or in the > > user32 DLL? To me, it would go in wineserver 'cos it has all the > > in

Re: shlexec: Fixes for buffer overrun problems

2003-12-12 Thread Andrew de Quincey
On Friday 12 December 2003 04:23, Alexandre Julliard wrote: > Andrew de Quincey <[EMAIL PROTECTED]> writes: > > Hi, this is a cleanup of shell32/shlexec.c to remove potential buffer > > overruns. I've also tried to make parts of the code a little easier to > &g

Re: comctl32/toolbar: Potential fix for button redraw in TBSTYLE_FLAT toolbars

2003-12-11 Thread Andrew de Quincey
On Thursday 11 December 2003 23:30, Dimitrie O. Paun wrote: > On December 11, 2003 06:07 pm, Andrew de Quincey wrote: > > On second thoughts, that method would need multiple changes in the file > > to ensure the correct value was passed to InvalidateRect(). Whereas the > > m

Re: comctl32/toolbar: Potential fix for button redraw in TBSTYLE_FLAT toolbars

2003-12-11 Thread Andrew de Quincey
On Thursday 11 December 2003 23:00, Andrew de Quincey wrote: > On Thursday 11 December 2003 22:45, Dimitrie O. Paun wrote: > > On December 11, 2003 04:32 pm, Andrew de Quincey wrote: > > > I have concluded that the WM_ERASEBKGND is sent from within WM_PAINT > > > when t

Re: comctl32/toolbar: Potential fix for button redraw in TBSTYLE_FLAT toolbars

2003-12-11 Thread Andrew de Quincey
On Thursday 11 December 2003 22:45, Dimitrie O. Paun wrote: > On December 11, 2003 04:32 pm, Andrew de Quincey wrote: > > I have concluded that the WM_ERASEBKGND is sent from within WM_PAINT when > > the toolbar detects that the mouse has moved off a button and wants to >

Re: menu: Fix for menu tracking problem version 2

2003-12-11 Thread Andrew de Quincey
On Thursday 11 December 2003 19:48, Andrew de Quincey wrote: > On Saturday 06 December 2003 19:46, Alexandre Julliard wrote: > > Andrew de Quincey <[EMAIL PROTECTED]> writes: > > > I wrote a program in windows which had owner drawn menu items. Whenever > > > I

Re: menu: Fix for menu tracking problem version 2

2003-12-11 Thread Andrew de Quincey
On Saturday 06 December 2003 19:46, Alexandre Julliard wrote: > Andrew de Quincey <[EMAIL PROTECTED]> writes: > > I wrote a program in windows which had owner drawn menu items. Whenever I > > received the WM_DRAWITEM message: > > > > 1) I called GetCapture(), and

Re: winefile can't launch any apps!

2003-12-10 Thread Andrew de Quincey
On Wednesday 10 December 2003 07:50, Dan Kegel wrote: > Trying to launch any app, e.g. wine's notepad, by double-clicking on > the .exe in 'winefile' crashes wine, like this: > > 0x42079c30 (NTDLL.DLL.strcpy+0x20): movzbl 0x0(%edx),%eax > Wine-dbg>bt > Backtrace: > =>0 0x42079c30 (NTDLL.DLL.st

Re: Issues in typelib.c with installshield 7

2003-12-09 Thread Andrew de Quincey
On Tuesday 09 December 2003 20:02, Mike Hearn wrote: > On Tue, 09 Dec 2003 18:22:04 +0000, Andrew de Quincey wrote: > > Next up is some reference count problem; the ITypeLib interface seems to > > get destroyed too early. > > Hmmm. I seem to recall posting a patch that fixed

Re: Issues in typelib.c with installshield 7

2003-12-09 Thread Andrew de Quincey
On Monday 08 December 2003 21:22, Marcus Meissner wrote: > On Mon, Dec 08, 2003 at 10:39:54AM +0000, Andrew de Quincey wrote: > > > > e.g. in ITypeInfo_fnGetIDsOfNames, I have changed it to > > > > if(This->TypeAttr.cImplTypes && > > > >

Re: Issues in typelib.c with installshield 7

2003-12-08 Thread Andrew de Quincey
> > e.g. in ITypeInfo_fnGetIDsOfNames, I have changed it to > > if(This->TypeAttr.cImplTypes && > >(This->TypeAttr.typekind==TKIND_INTERFACE || > > This->TypeAttr.typekind==TKIND_DISPATCH)) { > > Do you have a sample installer for download? Bah, I can't find one thats (a) available ea

Issues in typelib.c with installshield 7

2003-12-07 Thread Andrew de Quincey
Hi, today I've been trying to get an Installshield 7 installer going. I think I've seen reports from other people about having problems as well. The problems I've been having stem from the implementation of ITypeLib/ITypeInfo/etc in oleaut32. The first problem is as follows: Installshield has a

Re: menu: nasty bug in menu tracking

2003-12-04 Thread Andrew de Quincey
On Friday 05 December 2003 00:16, Mike Jackson wrote: > Actually I think the code would work better like this:- > > if ((msg.message >= WM_MOUSEFIRST) && (msg.message <= WM_MOUSELAST)) > { > mt.pt.x = (short)LOWORD(msg.lParam); > mt.pt.y = (short)HIWORD(msg.lParam); >

Who maintains the imagehlp dll?

2003-12-04 Thread Andrew de Quincey
Now that I have IDA nearly sorted, I was wondering.. who maintains the imagehlp dll? It seems kinda empty, and I'm sure it was at one point more complete (I looked into wine some time ago). I ask this because about a year or so ago I got about 3/4 of the way through reverse engineering the Wind

Re: menu: nasty bug in menu tracking

2003-12-04 Thread Andrew de Quincey
On Thursday 04 December 2003 23:34, Alexandre Julliard wrote: > Andrew de Quincey <[EMAIL PROTECTED]> writes: > > OK, I'll keep looking. I've printed out the coordinates I get in the > > tracking loop. As soon as the popup menu is displayed, they are > > imm

Re: menu: nasty bug in menu tracking

2003-12-04 Thread Andrew de Quincey
On Thursday 04 December 2003 22:59, Alexandre Julliard wrote: > Andrew de Quincey <[EMAIL PROTECTED]> writes: > > The problem is that MSG.lParam is NOT necessarily in screen coordinates > > (even though the comment I have removed says they are). As I can't trust > &g

Re: Question about simple profiling implementation

2003-12-03 Thread Andrew de Quincey
On Tuesday 02 December 2003 22:56, Mike McCormack wrote: > I've been maintaining Charles's wine profiler patch in my Wine tree, but > haven't tested it for a while. Here's roughly what I have at the > moment... I'm in a bit of a rush right now, so it may be incomplete and > I'll check it again ton

IDA speed problem analysis

2003-12-02 Thread Andrew de Quincey
Hi, I've been doing some more work on this, and I think I've found the culprit (my apologies to everyone for the crap I've been talking recently). Whenever IDA opens the Save box.. and in fact when it does a lot of operations, it seems to completely regenerate its menus. It uses an MDI interfac

Re: Question about simple profiling implementation

2003-12-02 Thread Andrew de Quincey
On Tuesday 02 December 2003 18:21, Shachar Shemesh wrote: > Dimitrie O. Paun wrote: > >On December 2, 2003 08:52 am, Andrew de Quincey wrote: > >>As you say, relay debugging adds a huge overhead... however, would you > >> say that this overhead would be fairly c

Re: Question about simple profiling implementation

2003-12-02 Thread Andrew de Quincey
On Tuesday 02 December 2003 04:13, Alexandre Julliard wrote: > Andrew de Quincey <[EMAIL PROTECTED]> writes: > > However, if no one minds, I think I'll still implement the stuff I was > > doing. I found being able to examine the call tree with ballpark figures > &g

Re: Question about simple profiling implementation

2003-12-02 Thread Andrew de Quincey
On Tuesday 02 December 2003 04:13, Alexandre Julliard wrote: > Andrew de Quincey <[EMAIL PROTECTED]> writes: > > However, if no one minds, I think I'll still implement the stuff I was > > doing. I found being able to examine the call tree with ballpark figures > &g

Re: Question about simple profiling implementation

2003-12-01 Thread Andrew de Quincey
On Monday 01 December 2003 22:35, Andrew de Quincey wrote: > On Monday 01 December 2003 20:16, Mike Hearn wrote: > > On Mon, 2003-12-01 at 12:49, Andrew de Quincey wrote: > > > Hi, the last thing I have to do with the profiling stuff is the > > > trickiest: To dec

Re: Question about simple profiling implementation

2003-12-01 Thread Andrew de Quincey
On Monday 01 December 2003 20:16, Mike Hearn wrote: > On Mon, 2003-12-01 at 12:49, Andrew de Quincey wrote: > > Hi, the last thing I have to do with the profiling stuff is the > > trickiest: To decide what is the best way to determine the times. > > It might be worth using op

Re: shlwapi: optimise path functions

2003-12-01 Thread Andrew de Quincey
On Monday 01 December 2003 20:33, Dimitrie O. Paun wrote: > On December 1, 2003 03:26 pm, Alexandre Julliard wrote: > > That's not possible, such a simple function cannot take 168us, unless > > you have a 1Mhz CPU... How did you measure it? > > I think he measured it across the call: > > start >

Question about simple profiling implementation

2003-12-01 Thread Andrew de Quincey
Hi, the last thing I have to do with the profiling stuff is the trickiest: To decide what is the best way to determine the times. To get times that are useful, I'm using the RDTSC opcode (which returns the number of CPU clock cycles since the machine was powered on).. basically I've added a cou

Re: shlwapi: optimise path functions

2003-12-01 Thread Andrew de Quincey
On Monday 01 December 2003 09:32, Andrew de Quincey wrote: > > In other words, I don't think the patch is acceptable. What I'd suggest: > > -- figure out why the real CharNextA() is slow, and try to fix that > > -- figure out why it takes so long to call CharNext

Re: shlwapi: optimise path functions

2003-12-01 Thread Andrew de Quincey
> In other words, I don't think the patch is acceptable. What I'd suggest: > -- figure out why the real CharNextA() is slow, and try to fix that > -- figure out why it takes so long to call CharNextW() As I said originally, its not that CharNextW/CharNextA are particularly slow, its the numb

Re: shlwapi: optimise path functions

2003-12-01 Thread Andrew de Quincey
On Sunday 30 November 2003 01:23, Dimitrie O. Paun wrote: > On November 29, 2003 06:27 pm, Andrew de Quincey wrote: > > I've replaced the calls to CharNextA()/CharNextW() with array increments > > and a local static function. This knocks 3.5 seconds off the file open > >

Re: sysparams: slight optimisation for IDA 3

2003-11-29 Thread Andrew de Quincey
> Sorry to bother you again, but probably the comparison statement > needs to be reverted... Doh! You're right. Fixed in yet another patch. Gah As for bothering.. no problems! The sooner I know what coding styles etc are acceptable the better.

Re: SystemParametersInfoA very slow

2003-11-29 Thread Andrew de Quincey
On Saturday 29 November 2003 17:32, Peter Berg Larsen wrote: > On Fri, 28 Nov 2003, Andrew de Quincey wrote: > > Initially, I've been trying to get Datarescue IDA working... the actual > > application works fine, but certain operations take a long time to > > complete (e

Re: sysparams: slight optimsation for IDA

2003-11-29 Thread Andrew de Quincey
> 1. the second '+' adds a non-epmty line (and this repeats Done. BTW, there seem to be loads of such cases all over that file; I assume your intention is that no more should creep in? > 2. an unnecessary formatting change (new comment is OK): Fixed. > 3. the whole case for IconTitleFaceName

Re: sysparams: slight optimsation for IDA

2003-11-29 Thread Andrew de Quincey
On Saturday 29 November 2003 15:18, Dmitry Timoshkov wrote: > "Andrew de Quincey" <[EMAIL PROTECTED]> wrote: > > Hi, this patch optimises the SPI_GETNONCLIENTMETRICS and > > SPI_GETICONTITLELOGFONT SystemParameters. These are loaded *continually* > > by IDA Pr

SystemParametersInfoA very slow

2003-11-28 Thread Andrew de Quincey
Hi, as I'm quite new to this project, I thought I'd check before starting to do stuff to avoid duplication/stepping on peoples toes. Initially, I've been trying to get Datarescue IDA working... the actual application works fine, but certain operations take a long time to complete (e.g. the open

Re: [PATCH] [CVS] Fix int21 get disk space call

2003-11-28 Thread Andrew de Quincey
On Friday 28 Nov 2003 13:08, Hannu Valtonen wrote: > Andrew de Quincey wrote: > >Hi, my first patch to WINE ever. > > > >Theres a bug in wine/dlls/winedos/int21.c/INT21_GetFreeDiskSpace() > > I don't want to be negative but, a fix was committed to the CVS on 25.1