Re: ole32: Void functions should not return a value

2007-04-12 Thread Brian Gerst
pcRaiseException(hr); >>> } >>> >>> params->msg = (RPCOLEMESSAGE *)msg; >>> >> You've changed the code paths here. >> > > Hi Rob, > > I'm not quite sure what you mean. Are you implying that I need return > statements after the RpcRaiseException() calls? Can one not just rely on > the fact that RpcRaiseException() does not return to the caller? > > -- Andy. > > > > You completely removed the return from the function at those two points, allowing it to fall through. -- Brian Gerst

Re: [patch] x86: fix ESP corruption CPU bug

2005-03-14 Thread Brian Gerst
even the same stack, BTW). Because even in 16-bit mode (real, vm86 or 16-bit protected) you can use 32-bit instructions, with an operand and/or address size override prefix. Of course this only works on 386 or later. -- Brian Gerst