Patch for AddFontMemResourceEx implemetation in wine

2007-04-17 Thread Byeong-Sik Jeon
2007-04-17, 12:53 +0930, Patrick Eiffe wrote: > Beong-Jik, > Hi, > I have updated your patch from http://bugs.winehq.org/show_bug.cgi?id=5865 > to work with the latest git, and I was going to send it in but I was informed > that it would be much easier for the patch to be added if it was sent b

Re: [1/8] regedit: Remove the _stscanf function dependency.

2007-04-07 Thread Byeong-Sik Jeon
Alexandre Julliard wrote: > Byeong-Sik Jeon <[EMAIL PROTECTED]> writes: > > > _stscanf depends tchar.h > > > > Changelog: > > Remove the _stscanf function dependency. > > You are going about this the wrong way. What you should do is convert &g

Re: notepad: Use the more explicitly UNICODE character type.

2007-04-05 Thread Byeong-Sik Jeon
Dmitry Timoshkov wrote: > "Byeong-Sik Jeon" <[EMAIL PROTECTED]> wrote: > > > Changelog: > >Use the more explicitly UNICODE character type. > > Then you have to simultaneously explicitly start using unicode Win32 APIs. Yes. I agree. > I'

Re: notepad: Fix the wrong '&' operator use.

2007-04-05 Thread Byeong-Sik Jeon
Felix Nawothnig wrote: > Byeong-Sik Jeon wrote: > > FormatMessage( > > FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM, > > NULL, error, 0, > > -(LPTSTR) &lpMsgBuf, 0, NULL); > > +lpMsgBu

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-05 Thread Byeong-Sik Jeon
Robert Shearman wrote: > Byeong-Sik Jeon wrote: > > Hi, > > > > MS-Windows's RegQueryKeyInfo function test result: > > > > 1. MSDN means TCHARS when it says 'character' for this function. > > ==> No. > > 2. why RegQueryInfoKey is

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-05 Thread Byeong-Sik Jeon
Robert Shearman wrote: > Byeong-Sik Jeon wrote: > > Hi, > > > > MS-Windows's RegQueryKeyInfo function test result: > > > > 1. MSDN means TCHARS when it says 'character' for this function. > > ==> No. > > 2. why RegQueryInfoKey is

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-05 Thread Byeong-Sik Jeon
Bill Medland wrote: > I confess that I have not tested this. I think it is sufficiently > counterintuitive that it would be useful if you could submit a test that > would demonstrate it, e.g. put a non-SBCS string into the registry in > Unicode, query and get it back out, demonstrating that the si

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-05 Thread Byeong-Sik Jeon
Alexandre Julliard wrote: > Byeong-Sik Jeon <[EMAIL PROTECTED]> writes: > > > another soultion: > > * we can change the "IDS_NEWKEY, IDS_NEWVALUE" of resource file. > > * define the UNICODE > > but these sulution don't fix the regedit's

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-04 Thread Byeong-Sik Jeon
Hi, MS-Windows's RegQueryKeyInfo function test result: 1. MSDN means TCHARS when it says 'character' for this function. ==> No. 2. why RegQueryInfoKey is returning a number that is too small ==> No. Currently Wine's RegQueryInfoKey set the right values. Thank you.

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-04 Thread Byeong-Sik Jeon
Byeong-Sik Jeon wrote: > Bill Medland wrote: > > On Thu, 2007-05-04 at 06:17 +0900, Byeong-Sik Jeon wrote: > > > Without UNICODE, sizeof(TCHAR) == 1. This is no effect. CJK multibyte > > > character is 2 byte size. > > > > > Yes, but you are getting conf

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-04 Thread Byeong-Sik Jeon
Bill Medland wrote: > On Thu, 2007-05-04 at 06:17 +0900, Byeong-Sik Jeon wrote: > > Without UNICODE, sizeof(TCHAR) == 1. This is no effect. CJK multibyte > > character is 2 byte size. > > > Yes, but you are getting confused by the term 'character'. It is be

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-04 Thread Byeong-Sik Jeon
Bill Medland wrote: > On Thu, 2007-05-04 at 02:18 +0900, Byeong-Sik Jeon wrote: > > Hi, > > > > Currently regedit is not defined "UNICODE". > > > > The point are "max_val_name_len", "valName", "valNameLen". > > Not ma

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-04 Thread Byeong-Sik Jeon
Bill Medland wrote: > On Thu, 2007-05-04 at 02:18 +0900, Byeong-Sik Jeon wrote: > > Hi, > > > > Currently regedit is not defined "UNICODE". > > > > The point are "max_val_name_len", "valName", "valNameLen". > > Not ma

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-04 Thread Byeong-Sik Jeon
egistry key, we can't see any newly created reg value name. Thanks. Detlef Riekenberg wrote: > On Mi, 2007-04-04 at 10:36 +0900, Byeong-Sik Jeon wrote: > > > > +/* convert from WCHAR size to maximum required TCHAR size */ > > +max_val_name_len *= sizeof(WCHAR) / size

Re: [1/2] regedit: Support the REG_MULTI_SZ.

2007-03-30 Thread Byeong-Sik Jeon
oops!!! you are right. Thank you. Juan Lang wrote: > Hi Byeong-Sik, > > +lRet = RegSetValueEx(hKey, valueName, 0, type, > (LPBYTE)stringValueData, j); > > I think that should be j * sizeof(TCHAR), yes? > --Juan

Re: imm32: Change the default IME window to better reflect applications request

2007-03-29 Thread Byeong-Sik Jeon
It looks good to me. Thanks to Aric :) Aric Stewart wrote: > First part of this change was proposed by Byeong-Sik Jeon > <[EMAIL PROTECTED]> > Use a tooltip window instead to avoid stealing focus from the application. > Additionally respect parameters give to us by ImmSetCompos

Re: [2/2] imm32: Fix the unwanted root_context string buffer cleanup code.

2007-03-12 Thread Byeong-Sik Jeon
I'm sorry. This patch don't fix kinput2 case. kinput2 case may be wanted situation. but this patch fix the 'nabi' and 'scim' case. Hmm, I'll stop the my poor patch series. Thank you. Byeong-Sik Jeon worte: > kinput2: Japanese xim. when we press japanes

Re: imm32: Use the PostMessageW for WM_IME_NOTIFY message.

2007-03-12 Thread Byeong-Sik Jeon
Thank you. Aric Stewart wrote: > Hello, > >yes, I think that is a good change. > >I use kinput2 for testing Japanese on linux. > > -aric >

Re: imm32: Use the PostMessageW for WM_IME_NOTIFY message.

2007-03-12 Thread Byeong-Sik Jeon
checked with > Spy++. Additional a number of the applications I am working with hang > when the WM_IME_NOTIFY is sent out of order. > > -aric > > Byeong-Sik Jeon wrote: > > We have to call PostMessage to send WM_IME_NOTIFY message. > > To send WM_IME_CONTROL, we use

Re: imm32: Use the PostMessageW for WM_IME_NOTIFY message.

2007-03-12 Thread Byeong-Sik Jeon
Thanks you. Dmitry Timoshkov wrote: > "Byeong-Sik Jeon" <[EMAIL PROTECTED]> wrote: > > > I think we have to use "PostMessage" to send WM_IME_SETCONTEXT too. > > Using the "SendMessage" change the real WM_IME_* message ordering. It > > c

Re: imm32: Use the PostMessageW for WM_IME_NOTIFY message.

2007-03-12 Thread Byeong-Sik Jeon
. I'll consider this problem when i test on my local git branch. :) Thanks your reply. Dmitry Timoshkov wrote: > "Byeong-Sik Jeon" <[EMAIL PROTECTED]> wrote: > > > We have to call PostMessage to send WM_IME_NOTIFY message. > > To send WM_IME_CONTROL, we use

Re: [1/2] gdi32: Implement AddFontMemResourceEx api.

2007-03-06 Thread Byeong-Sik Jeon
Dmitry Timoshkov wrote: > "Byeong-Sik Jeon" <[EMAIL PROTECTED]> wrote: > > > These patches fix the BUG #5865 > > http://bugs.winehq.org/show_bug.cgi?id=5865. > > > > changelog: > >Implement AddFontMemResourceEx. > > You shouldn

Re: winex11.drv: Bug#6501. XIM problem with XInitThreads().

2006-11-03 Thread Byeong-Sik Jeon
2006-11-03 (Fri), 11:57 +0800, Dmitry Timoshkov wrote: > My impression is that it's an X11 bug, not a Wine one. So a proper place > to send such a request is most likely the Xorg bug tracker. > I think xorg people knows this problem already. https://bugs.freedesktop.org/show_bug.cgi?id=1182 I thi

winex11.drv: Bug#6501. XIM problem with XInitThreads().

2006-11-02 Thread Byeong-Sik Jeon
http://www.winehq.org/pipermail/wine-cvs/2006-October/026680.html > winex11.drv: Give XInitThreads another chance. > > --- > > dlls/winex11.drv/x11drv_main.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dlls/winex11.drv/x11drv_main.c b/dlls/winex11.drv/x11drv_m

Re: [Korean] Use the SUBLANG_NEUTRAL in Korean resources.

2006-10-18 Thread Byeong-Sik Jeon
2006-10-19 (Wed), 07:39 +0900, Byeong-Sik Jeon wrote: > At [use SUBLANG_NEUTRAL in French resources], > 2006-10-18 (Wed), 20:47 +0200, Jonathan Ernst wrote: > > Thanks to Mikolaj Zalewski for spotting it. > > > It's great. > It's important. > This patch so

Re: GDI32: Fix logical error of italic,bold determination

2006-03-16 Thread Byeong-Sik Jeon
2006-03-15 (수), 14:50 +, Huw D M Davies 쓰시길: > On Mon, Mar 13, 2006 at 04:10:04AM +0900, Byeong-Sik Jeon wrote: > > ChangeLog: > > Fix the logical error of the italic, bold determination. > > > >

Re: GDI32: using the embeded bitmap in antialias mode

2006-03-12 Thread Byeong-Sik Jeon
2006-03-13 (월), 04:10 +0900, Byeong-Sik Jeon 쓰시길: > If format == WINE_GGO_GRAY16_BITMAP at the "WineEngGetGlyphOutline()", > set on "FT_LOAD_NO_BITMAP". > I mistake. When format == WINE_GGO_GRAY16_BITMAP, skip that set on "FT_LOAD_NO_BITMAP".

Re: GDI32: [4/5] freetype.c add more font selecting&linking mechanism support.

2006-03-07 Thread Byeong-Sik Jeon
-- I think that create_child_font_list(), WineEngCreateFontInstance() have to this key. and then I can remove "defSystem" in all my patch(4/5 and 5/5). I working. but, create_child_font_list(), WineEngCreateFontInstance() will not create directly this key. I want your advice. Thanks

Re: GDI32: [4/5] freetype.c add more font selecting&linking mechanism support.

2006-03-07 Thread Byeong-Sik Jeon
2006-03-07 (화), 14:34 +, Huw D M Davies 쓰시길: > On Tue, Mar 07, 2006 at 09:29:14PM +0900, Byeong-Sik Jeon wrote: > > ChangeLog: > > Improved create_child_font_list(), get_nearest_charset(), more using > > font-linking mechanism. > > > > If lfCharSet

Re: GDI32: [1/5] freetype.c add more font selecting&linking mechanism support.

2006-03-07 Thread Byeong-Sik Jeon
2006-03-07 (화), 14:22 +, Huw D M Davies 쓰시길: > On Tue, Mar 07, 2006 at 09:10:12PM +0900, Byeong-Sik Jeon wrote: > > ChangeLog: > > init_system_links support .ttc file. > > add "Tahoma" registry value for CJK font link. > > find_face_from_filena

Re: GDI32: freetype.c add more font selecting&linking mechanism support.

2006-03-07 Thread Byeong-Sik Jeon
2006-03-07 (화), 10:45 +, Huw D M Davies 쓰시길: > As Mike has said the patch is too long to review properly, so please > break it down into much smaller pieces. > > On Tue, Mar 07, 2006 at 04:29:04PM +0900, Byeong-Sik Jeon wrote: > > and, I add some basic registry value. &quo

Re: GDI32: freetype.c add more font selecting&linking mechanism support.

2006-03-07 Thread Byeong-Sik Jeon
I resended five splited patches. Thanks advice... 2006-03-07 (화), 16:58 +0900, Mike McCormack 쓰시길: > Byeong-Sik Jeon wrote: > > > ChangeLog: > > - add more font selecting & linking mechanism support. > > Nice work! > > Some comments: > > * Ple

Re: GDI32: freetype.c add more font selecting&linking mechanism support.

2006-03-07 Thread Byeong-Sik Jeon
2006-03-07 (화), 11:33 +, Huw D M Davies 쓰시길: > Right, but even Tahoma is locale dependent - the order of Gulim, MS UI > Gothic etc changes. Yes. but lucky thing... fsCsb[0] information of each font are: Gulim : ANSI, EASTEUROPE, RUSSIAN, GREEK, TURKISH, BALTIC, "HANGEUL" MS UI Gothic: ANSI, AS

Re: GDI32: freetype.c add more font selecting&linking mechanism support.

2006-03-07 Thread Byeong-Sik Jeon
2006-03-07 (화), 10:45 +, Huw D M Davies 쓰시길: > As Mike has said the patch is too long to review properly, so please > break it down into much smaller pieces. Yes. now working... > > and, I add some basic registry value. "Tahoma", "Gulim", "MS UI Gothic", > > "Simsun", "PMingLiU". > > One thin