Dmitry Timoshkov wrote:
> returned_size must be intialized first.
That's what I've already fixed in an updated patch yesterday:
http://www.winehq.org/pipermail/wine-patches/2009-April/072175.html
Best regards,
Colin
Alexandre Julliard wrote:
> It would be cleaner to pass the actual buffer size to the function, it's
> complex enough that it would be easy to inadvertently break the
> guarantee that the allocated space is large enough.
We already pass a length pointer to that
"convert_PCREDENTIALW_to_PCREDENTIA
Jeff Latimer wrote:
> Are you planning to move on to MultiByteToWideChar tests?
No, feel free to go ahead with them.
I mainly wanted to fix http://bugs.winehq.org/show_bug.cgi?id=8598 and a fix
for this bug required a working wide-character to multibyte conversion in
the CRT and Win32.
This is
Dan Kegel wrote:
> your change [...] seems to have triggered some valgrind warnings,
Thanks for providing the valgrind output!
Indeed, I was passing a wrong length to a WideCharToMultiByte call, which
led to the use of uninitialized stack memory.
Fixed here:
http://www.winehq.org/pipermail/wine
Alexandre Julliard wrote:
> There are places in Wine that use a negative dstlen, you have to fix
> them first.
Done here now:
http://www.winehq.org/pipermail/wine-patches/2008-July/058743.html
Best regards,
Colin
Dmitry Timoshkov wrote:
>> -INT CDECL MSVCRT_wctomb( char *dst, MSVCRT_wchar_t ch )
>> +INT CDECL MSVCRT_wctomb(char *mbchar, MSVCRT_wchar_t wchar)
>
> What's the point of the above change?
While rewriting that function, I used the parameter names described on MSDN.
I don't see a point in inventin
Dmitry Timoshkov wrote:
>> -INT CDECL MSVCRT_wctomb( char *dst, MSVCRT_wchar_t ch )
>> +INT CDECL MSVCRT_wctomb(char *mbchar, MSVCRT_wchar_t wchar)
>
> What's the point of the above change?
While rewriting that function, I used the parameter names described on MSDN.
I don't see a point in inventin
Vitaliy Margolen wrote:
> You have to do that in the patch that fixes the test. Each patch have to
> be
> autonomous and have all tests pass before and after it.
Well, I just found out that this test passes now by accident.
And I also marked all my patches as one bunch consisting of 5 patches lik
Dmitry Timoshkov wrote:
> If the test fails in current Wine code you need to use todo_wine
> so that 'make test' still passes.
Ok, I submitted an updated patch:
http://www.winehq.org/pipermail/wine-patches/2008-April/053202.html
Best regards,
Colin Finck
Alexander N. Sørnes wrote:
> As for Norwegian, if you set your locale to the other variant
> (Nynorsk), you
> expect the text to be in Nynorsk instead of Bokmål. Sure
> enough, if you can
> read one you can read the other, but such users will in
> nearly all cases be
> able to use the Englis
translation or the
English one?
The same goes for Chinese and Norwegian users, if we only have one
translation for these languages.
It would be nice if some native Chinese, Norwegian and Portuguese speakers
could share their opinion about this.
Best regards,
Colin Finck
11 matches
Mail list logo
