RFC: HKCR merge implementation

2013-09-11 Thread George Stephanos
handle, tries to reopen previously failed internal handles, gives back HKCU first if available then HKLM close_hkcr: deallocates path and struct, removes struct from table. From 09e5a3c2629ddcc795a69f70b0672f393abd96ed Mon Sep 17 00:00:00 2001 From: George Stephanos gaf.stepha...@gmail.com Date: Sat, 24

RFC: HKCR merge implementation

2013-09-10 Thread George Stephanos
I'm proposing my HKEY_CLASSES_ROOT implementation patches for review. Feel free to comment. So far, I've written code for all functions except for the RegEnum family. General description: HKCR handles are special. All wine handles have the two lowest bits zero'd. HKCR handles are masked. 10b

Re: RFC: HKCR merge implementation

2013-09-10 Thread George Stephanos
a couple bitwise nits in your first patch: +#define HKCR_MASK 2 +#define IS_HKCR(hk) ((UINT_PTR)hk 0 ((UINT_PTR)hk 3) == HKCR_MASK) Typically a mask would define all the bits that could be set, and a flag would be the particular bit you want to test. Something like: #define

[PATCH] advapi32: RegDeleteKey tests for merged view of HKCR

2013-06-30 Thread George Stephanos
http://newtestbot.winehq.org/JobDetails.pl?Key=1403 --- dlls/advapi32/tests/registry.c | 21 + 1 file changed, 21 insertions(+) diff --git a/dlls/advapi32/tests/registry.c b/dlls/advapi32/tests/registry.c index 1784118..4e74a07 100644 --- a/dlls/advapi32/tests/registry.c +++

[PATCH] Tests that prove ntdll has no notion of HKCR.

2013-05-21 Thread George Stephanos
As instructed, I added a few lines to the already written tests that confirm my claim. Part of the research of the registry merging project was to determine where the implementation is going to be written: advapi32, ntdll or the server itself. The server choice was dismissed since HKCR isn't

Re: [PATCH] Tests that prove ntdll has no notion of HKCR.

2013-05-19 Thread George Stephanos
On Sun, May 19, 2013 at 8:20 AM, Dmitry Timoshkov dmi...@baikal.ru wrote: George Stephanos gaf.stepha...@gmail.com wrote: Ah, well, strcmp comes from the C library your compiler uses. wcsncmp can only come from msvcrt. When compiling for Wine, this can result in mixing C runtime

[PATCH] Tests that prove ntdll has no notion of HKCR.

2013-05-19 Thread George Stephanos
As instructed, I added a few lines to the already written tests that confirm my claim. Part of the research of the registry merging project was to determine where the implementation is going to be written: advapi32, ntdll or the server itself. The server choice was dismissed since HKCR isn't

[PATCH] Tests that prove ntdll has no notion of HKCR.

2013-05-19 Thread George Stephanos
As instructed, I added a few lines to the already written tests that confirm my claim. Part of the research of the registry merging project was to determine where the implementation is going to be written: advapi32, ntdll or the server itself. The server choice was dismissed since HKCR isn't

Re: [PATCH] Tests that prove ntdll has no notion of HKCR.

2013-05-18 Thread George Stephanos
On Sat, May 18, 2013 at 11:57 PM, Juan Lang juan.l...@gmail.com wrote: Hi George, (consider subscribing to wine-devel so your emails don't get stuck in moderation.) Hmm but I am already! On Sat, May 11, 2013 at 7:43 AM, George Stephanos gaf.stepha...@gmail.com wrote: As instructed, I

Re: [PATCH] Tests that prove ntdll has no notion of HKCR.

2013-05-18 Thread George Stephanos
On Sun, May 19, 2013 at 2:24 AM, Juan Lang juan.l...@gmail.com wrote: (consider subscribing to wine-devel so your emails don't get stuck in moderation.) Hmm but I am already! Ok, that's strange. Maybe I just got it late. I think Alexandre will object to using msvcrt functions (wcsncmp

Re: GSoC proposal

2013-05-17 Thread George Stephanos
to it? Is there something I'm missing? [1] - http://msdn.microsoft.com/en-us/library/windows/desktop/ms724498(v=vs.85).aspx On Wed, May 8, 2013 at 1:26 AM, George Stephanos gaf.stepha...@gmail.comwrote: I'm done. Sorry for the font massacre. They're not changing :| On Tue, May 7, 2013 at 6:45 PM, Juan Lang

Re: GSoC proposal

2013-05-17 Thread George Stephanos
You're right about RegOpenUserClassesRoot(). It'll just serve as another way to RegOpenKeyEx(HKEY_CLASSES_ROOT) for now because wine doesn't yet support multiple NT users. For the list.. it's very strange. I've tested on my side and it does seem that there's no difference whatsoever. But then

[PATCH] Tests that prove ntdll has no notion of HKCR.

2013-05-17 Thread George Stephanos
As instructed, I added a few lines to the already written tests that confirm my claim. Part of the research of the registry merging project was to determine where the implementation is going to be written: advapi32, ntdll or the server itself. The server choice was dismissed since HKCR isn't

GSoC proposal

2013-05-03 Thread George Stephanos
Hello wine-devel! This is my proposal as a student for Google Summer of Code 2013. I'm George Stephanos from the Arab Academy for Science and Technology situated in Egypt. gsteph on #winehackers I'm currently about to finish my second semester as a BSc in CS. Previous Experience: I haven't

GSoC proposal

2013-05-01 Thread George Stephanos
Hello wine-devel! This is my proposal as a student for Google Summer of Code 2013. I'm George Stephanos from the Arab Academy for Science and Technology situated in Egypt. gsteph on #winehackers I'm currently about to finish my second semester as a BSc in CS. Previous Experience: I haven't