Re: [PATCH 4/8] msi: Fix merging string type checks.

2009-10-20 Thread Hib Eris
On Tue, Oct 20, 2009 at 3:06 PM, Alexandre Julliard wrote: > Hib Eris writes: > >> +static BOOL merge_type_match(LPCWSTR type1, LPCWSTR type2) >> +{ >> +    const WCHAR szl[] = {'l', 0}; >> +    const WCHAR szs[] = {'s', 0}; >> +    const

Re: [PATCH 05/10] msi: Add support for importing binary OBJECTS.

2009-05-26 Thread Hib Eris
Hi Nikolay, Thanks for your reply. Alexandre already pointed me to my mistake, so no need for you anymore to help out. Thanks anyway. Hib > > Hi, Hib. > --- > error: patch failed: dlls/msi/tests/db.c:1966 > error: dlls/msi/tests/db.c: patch does not apply > --- > Post a rebased version please

Re: [PATCH 05/10] msi: Add support for importing binary OBJECTS.

2009-05-26 Thread Hib Eris
On Tue, May 26, 2009 at 8:57 PM, Alexandre Julliard wrote: > Hib Eris writes: > >> I have looked at my new code and it does not seem wrong to me, but >> maybe it is somewhere else. Unfortunately, as I cannot reproduce this >> failure, I have no idea how to debug it.

[PATCH 05/10] msi: Add support for importing binary OBJECTS.

2009-05-26 Thread Hib Eris
r him/her. Hib On Tue, May 26, 2009 at 3:30 PM, Alexandre Julliard wrote: > Hib Eris writes: > >> --- >>  dlls/msi/database.c |   63 >> +++--- >>  dlls/msi/msipriv.h  |    3 +- >>  dlls/msi/record.c  

Re: msi/tests: Test type for INT column.

2009-04-27 Thread Hib Eris
Hi Hans, Sorry for this, but my patch just contained a typo, 'Intvalue' and 'IntValue' are just strings that can be set to anything but should match. I have already sent in new patches for this, but because I am not on the mailinglist they take some time to arrive. However, these patches are alrea

msi/tests: Test type for INT column.

2009-04-27 Thread Hib Eris
regards, Hib Eris