Re: #1 winhttp: Forward WinHttpTime{From, To}SystemTime to their counterparts in wininet.

Hans Leidekker wrote: > I haven't seen a convincing argument for code duplication yet. Then why do you want to add hacks instead of proper implementation? > We may > even be able to achieve 100% by extending wininet a bit. E.g. we could > add a Wine internal INTERNET_OPTION_CALLBACK_WINHTTP if we

Re: [PATCH 2/5] urlmon: Use BSCF_ values passed to report_data to keep track of download state.

Hi Misha, Misha Koshelev wrote: This simplifies the code a bit by getting rid of an enum and a corresponding variable in the IBinding implementation, as we can successfully use the bscf values that are passed to report_data to get all the information. Additionally, the original implementation

Re: #1 winhttp: Forward WinHttpTime{From, To}SystemTime to their counterparts in wininet.

Hans Leidekker wrote: We should be able to implement more than 95% of this dll by wrapping/forwarding to wininet. That's better than many other dlls in Wine and we're already seeing regressions in apps trying to use our stub winhttp. And when we'll find an app (I'm sure we will) that uses th

Re: mshtml #2: Added HTMLWindow's IDispatch methods implementation.

Hi Robert, Thanks for your review. Robert Shearman wrote: Jacek Caban wrote: static HRESULT WINAPI HTMLWindow2_item(IHTMLWindow2 *iface, VARIANT *pvarIndex, VARIANT *pvarResult) diff --git a/dlls/mshtml/main.c b/dlls/mshtml/main.c index 3f8131c..41f32eb 100644 --- a/dlls/mshtml/main.c +++ b

Re: New winetest skipping test for nonexistent dll's

Hi Paul, Paul Vriens wrote: + +dll = LoadLibrary(dllname); +if (!dll) { I think it would be better to call LoadLibraryEx(dllname, LOAD_LIBRARY_AS_DATA_FILE) here to avoid executing DllMain code. Jacek

Re: Add winhttp.dll.

Hi Vijay, Vijay Kiran Kamuju wrote: Hi Jacek, I think you can use the header I sent a while back to wine-patches for this. http://www.winehq.org/pipermail/wine-patches/2005-September/020901.html The original patch: http://www.winehq.org/pipermail/wine-patches/attachments/20050923/790dfab2/winht

Re: Rude hack fixes Run Time Error 445:Object Doesn't Support This Action

Hi David, David Anderson wrote: > What if the above simply returned S_OK with a FIXME instead > of E_NOTIMPL??? Would that be an acceptable hack for the official > source? Sure, that'd be fine in this case. Feel free to send a patch. Thanks, Jacek

Re: working on urlmon HttpProtocol implementation

Hi Misha, Misha Koshelev wrote: > Just wanted to let y'all know (so hopefully I'm not duplicating any > effort) I'm working on an HttpProtocol implementation for urlmon (Vector > NTI has a bug that requires POST to work for url monikers, and I don't > want to submit patches to a function that has

Re: mshtml: Implement HTMLDocument_QueryInterface for IHTMLDOMNode, IHTMLElement and IHTMLElement2.

Robert Shearman wrote: > > I suspect that you'll get different results when you do the same test > on a loaded HTML document, even though this violates COM rules. > No, load state doesn't change anything. I've attached a test. Jacek diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c i

Re: mshtml #14: Added more QueryInterface tests.

Detlef Riekenberg wrote: > On So, 2007-06-24 at 21:10 +0200, Jacek Caban wrote: > >> +ok(qi == NULL, "runnable=%p, ezpected NULL\n", qi) >> > > The Patch is in the Tree, but I suggest to change: > "ezpected" to "expected" in

Re: mshtml: Implement HTMLDocument_QueryInterface for IHTMLDOMNode, IHTMLElement and IHTMLElement2.

Robert Shearman wrote: > Jacek Caban wrote: >> Hi, >> >> I've just sent a test showing that native doesn't implement these >> interfaces so we shouldn't either. It's strange because IDL declaration >> says something else. >>

Re: mshtml: Implement HTMLDocument_QueryInterface for IHTMLDOMNode, IHTMLElement and IHTMLElement2.

Hi, I've just sent a test showing that native doesn't implement these interfaces so we shouldn't either. It's strange because IDL declaration says something else. And BTW. your patch violates COM QueryInterface rules (not that MS always respects these rules...). Thanks, Jacek

Re: mshtml: Implement HTMLElement_get_children.

Hi, > +elem_vector buf = {NULL, 0, 8}; > + > +TRACE("(%p)->(%p)\n", This, p); > + > +buf.buf = mshtml_alloc(buf.size*sizeof(HTMLElement**)); elem_vector is a self-resizable table, but in this case you know the size while creating it from nsIDOMNodeList::GetLength. I'd suggest to use

Re: mshtml #2: Added warning if a wrong Wine Gecko package version was found.

Alexandre Julliard wrote: > One problem with your version scheme is that there's no obvious way of > determining which version is newer, or compatible. A simple string > comparison won't work for that purpose. > >> By coexisting different versions you mean in one Wine prefix? Yes, it >> would be

Re: mshtml #2: Added warning if a wrong Wine Gecko package version was found.

Alexandre Julliard wrote: > Jacek Caban <[EMAIL PROTECTED]> writes: > > >> Yes, that's my plan, but I'm not sure why it's important for this patch. >> Currently Wine downloads always the same Gecko version that was never >> updated, so this che

Re: mshtml #2: Added warning if a wrong Wine Gecko package version was found.

Alexandre Julliard wrote: > Jacek Caban <[EMAIL PROTECTED]> writes: > > >> @@ -212,8 +213,10 @@ static BOOL load_wine_gecko(PRUnichar *gre_path) >> if(res != ERROR_SUCCESS || type != REG_SZ) >> return FALSE; >> >> -if(TRACE_O

Re: New Gecko package

Luke Bratch wrote: > > Perfect, that fixes all regressions that I can find - > and the scroll bars still work in Steam! > Great, thanks. I will wait until tomorrow and then upload it to SourceForge. Some changes in Gecko installer will be needed to support different package versions. Thanks,

Re: New Gecko package

Jacek Caban wrote: > I've attached a hack from Picasa tree that > causes links opening in new window to be opened in winebrowser. I forgot to attach the patch. Here it is. Jacek diff --git a/dlls/shdocvw/navigate.c b/dlls/shdocvw/navigate.c index 161c138..bdd0fdb 100644 --- a/d

Re: New Gecko package

Vitaliy Margolen wrote: > Jacek Caban wrote: > >> Vitaliy Margolen wrote: >> >>>>> BTW why JavaScript doesn't work or any pop-up windows don't open? I know >>>>> this works fine with Firefox. >>>>> >>>&g

Re: New Gecko package

Luke Bratch wrote: > Yup this fixes that problem for me, however I've found > another regression. > > If you view for instance this page in most browsers > including the old wine Gecko, you will see "Buy Now" > buttons: > > http://www.tghost.co.uk/sale.html > > But with the new one, they are render

Re: New Gecko package

Vitaliy Margolen wrote: >>> BTW why JavaScript doesn't work or any pop-up windows don't open? I know >>> this works fine with Firefox. >>> >>> >> It needs some support from Gecko embedder (MSHTML in our case) and I >> haven't worked on it yet (with exception of built in alert pop-up). >>

Re: New Gecko package

Hi Vitaliy, Vitaliy Margolen wrote: > Jacek Caban wrote: > >> Hi all, >> >> It's time to update our Gecko package. I've prepared a new one. I'd like >> to avoid any regression, esp. ones that would require changing the >> package again. That&

Re: New Gecko package

Jacek Caban wrote: >> - Extracting it to install it manually works, as do >> the scroll bars (which work fine) >> - It crashes after submitting more than one form on >> websites. For instance searching for something on >> Google, then searching again will cause a c

Re: New Gecko package

Luke Bratch wrote: >> I'm interested in >> regressions, so just a simple test if app that >> > worked before still works > >> will be fine. >> > > I've given it a test, and found the following: > > - When setting that URL in HKCU\Software\Wine\MSHTML, > it will download but fail to ins

New Gecko package

Hi all, It's time to update our Gecko package. I've prepared a new one. I'd like to avoid any regression, esp. ones that would require changing the package again. That's why I'd like to do a good test. I'm interested in regressions, so just a simple test if app that worked before still works will

New Gecko package

Hi all, It's time to update our Gecko package. I've prepared a new one. I'd like to avoid any regression, esp. ones that would require changing the package again. That's why I'd like to do a good test. I'm interested in regressions, so just a simple test if app that worked before still works will

Re: [PATCH 2/6] msi/tests: automation: Remove unnecessary if (SUCCEEDED(hr)) statements.

Hi Misha, While you are at it, it's worth to directly compare the result to S_OK in tests instead of using SUCCEEDED macro as it's a more strict test. Jacek

Re: [PATCH 3/3] winex11: Use TINN algorithm to speed up colour lookups.

Vitaly Budovski wrote: > Vitaliy Margolen wrote: >> Vitaly Budovski wrote: >> >>> Vitaliy Margolen wrote: >>> Thanks for the tip. Unfortunately in this instance it will not >>> work as I >>> do in fact query more than a < b. See the nearest function in patch 2. >>> >> And what is so spec

Re: mshtml: fix crash when opening help (bug 8077)

Hi Clinton, This patch is wrong, I've added a comment to bug. Thanks, Jacek

Re: Road to 1.0

Hans Leidekker wrote: > On Sunday 25 March 2007 16:39:01 Dan Kegel wrote: > > >> Here's a try at a 1.0 wish list: >> > > I would like to see Wine 1.0 'fake' some suitable version > of Internet Explorer, say 6. > We almost have it. The main missing bit that causes apps not to find our IE

Re: localspl: add Polish translation

Hi Mikołaj, Mikołaj Zalewski wrote: > +IDS_NOTHINGTOCONFIG "Ten port nie ma opcji, kt�re mo�na by skonfigurowa�" > +} > It doesn't sound good to me. How about "Ten port nie ma opcji do skonfigurowania" or just remove "by" from your version? Jacek

Re: HtmlHelp status, winecfg and SoC proposal

Hi Paul, Paul Wise wrote: >> Paul seems to be excited about Wine, so hhm relicensing should sound OK >> for him, IMHO. >> > > I've previously offered to relicence the hhm code for inclusion in both > chmlib and libmspack, but it seems neither project took up this offer. I > don't think the h

Re: shell32: update Polish translation

Hi Mikołaj, Mikołaj Zalewski wrote: > - IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named > '%1'.\n\n"\ > - "If the files in the destination folder have the same names as > files in the\n"\ > - "selected folder they will be replaced. Do you still want to m

Re: wordpad: update Polish translation

Hi Mikołaj, Mikołaj Zalewski wrote: > + > +STRINGTABLE DISCARDABLE > +BEGIN > +STRING_RICHTEXT_FILES_RTF, "Tekst sformatowany - RTF (*.rtf)" > +STRING_TEXT_FILES_TXT, "Document tekstowy (*.txt)" This is a typo, it should be "Dokument". Jacek

HtmlHelp status, winecfg and SoC proposal

Hello. As you may have noticed, I've been working on HtmlHelp lately. Currently it should generally work, but still there is a lot to do. HTML should be correctly displayed and content tab should work. I was thinking about making more use of it in Wine. I think winecfg could benefit from it. W

Re: wininet: Remove the custom thread pool implementation and use QueueUserWorkItem instead.

Robert Shearman wrote: Hi Jacek, Thanks for looking through the patch. Jacek Caban wrote: Why do you copy lpRequest to workRequest? You could use lpRequest in asyncproc and WININET_Release and call HeapFree before return. Then workRequest may be removed. Two reasons: 1. This was how the

Re: wininet: Remove the custom thread pool implementation and use QueueUserWorkItem instead.

Hi Rob, Robert Shearman wrote: --- dlls/wininet/internet.c | 184 +-- dlls/wininet/internet.h |3 - 2 files changed, 19 insertions(+), 168 deletions(-) This also fixes a bug in the old code where starting a new asynchronous operation with mor

Re: mshtml #5: Set default print template in exec_print.

Frank Richter wrote: On 14.12.2006 00:21, Jacek Caban wrote: --- a/dlls/mshtml/resource.h +++ b/dlls/mshtml/resource.h @@ -28,6 +28,9 @@ #define IDS_MESSAGE_BOX_TITLE 2213 +#define IDS_PRINT_HEADER_TEMPLATE 8403 +#define IDS_PRINT_FOOTER_TEMPLATE 8404 + Could it be you forgot

Re: mshtml #1: Added test of CompareUrl.

Paul Vriens wrote: On Tue, 2006-12-12 at 21:52 +0100, Jacek Caban wrote: +hres = IInternetProtocolInfo_CompareUrl(protocol_info, NULL, NULL, 0xdeadbeef); +ok(hres == E_NOTIMPL, "CompareUrl failed: %08x\n", hres); + Will these tests also return E_NOTIMPL on Wi

Re: mshtml #1: Added get_parentWindow implementation.

Hi Detlef, Detlef Riekenberg wrote: Did you mean +#undef HTMLWINDOW2_THIS here? You're right, it was a typo. Thanks, Jacek

Re: mshtml as html parser

Hi Kirill, Kirill K. Smirnov wrote: Hi, all! Just a little question: can wine's current implementation of mshtml.dll be used as html parser? I need to convert html code into a tree without displaying it. I tried to look through the code, but I'm not familiar with OLE. BTW some E_NOIMPL confu

Re: Info about nsURI_Release

Brandon Warhurst wrote: I had a question about nsURI_Release. Is it okay for this function to release multiple references at once or is it supposed to release references one at a time? Of course it's not. nsURI is an implementation of nsIURI interface that is the XPCOM interface and inherits f

Re: When will ie6 registry key be added?

Steven Edwards wrote: > On 11/5/06, *Stefan Dösinger* <[EMAIL PROTECTED] > > wrote: > > Will ie6 still install then? > AFAIR someone found that if we set minor version to less than the recent one, ie6 will install. I've never checked it. > > I wonder if we should add a

Re: [PATCH] fixed NULL ptr crash

Marcus Meissner wrote: > On Sun, Sep 16, 2001 at 10:00:00PM +, Marcus Meissner wrote: > >> Hi, >> >> If nsIWebBrowser_GetContentDOMWindow fails we must >> not deallocate dom_window ... Only after the nsres >> check. >> >> Ciao, Marcus >> >> --- >> >> dlls/mshtml/olecmd.c |2 +- >> 1 fil

Re: small bug in mshtml component

Hi Andrey, Andrey Turkin wrote: > Hi, > > Just found a bug in mshtml component get_body method implementation. If > one call it right after creation of CLSID_HTMLDocument instance, then it > would return success and pass NULL as body object. Native would return > "empty" body object instead. Nativ

Re: shdocvw [3/3]: Add a stub implementation of the IOleCache interface

Hi James, James Hawkins wrote: > Hi, > > Changelog: > * Add a stub implementation of the IOleCache interface. > It's the same situation as in your patch for IRunnableObject. WebBrowser shouldn't implement IOleCache interface. Thanks, Jacek

Re: shdocvw [2/3]: Add a stub implementation of the IRunnableObject interface

Hi James, James Hawkins wrote: > Hi, > > Changelog: > * Add a stub implementation of the IRunnableObject interface. WebBrowser doesn't implement this interface (there is even test which shows that). The bug you try to fix is in OleCreate. OleCreate shouldn't fail if created object doesn't impleme

Re: recent ole32/shdocvw "regression" crashes adobe installers

Hi James, James Hawkins wrote: > Making PersistStorage_InitNew > return S_OK fixes the problem, but I don't know if that is acceptable > or not. The real solution is to implement PersistStorage. What are > people's thoughts on this? Is it OK to return S_OK for now? Yes, it is OK to return S_OK.

Re: shdocvw(2/2): ignore VT_ERROR arguments to WebBrowser_Navigate2

Hi, Juan Lang wrote: >> Ignoring VT_ERROR just masks a previous error. >> > > Hm.. are you sure? These are input arguments, not results. This isn't > the only app that gets further with this patch. See also bug 6166. > > I guess a test case is the only answer. > I've tested it and we re

Re: shdocvw: Make sure BSTR is allocated before calling sink

Hi Cihan, Cihan Altinay wrote: > This fixes bug 6054 and let's MSN Messenger 7 start up. > http://bugs.winehq.org/show_bug.cgi?id=6054 > > --- > dlls/shdocvw/dochost.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/dlls/shdocvw/dochost.c b/dlls/shdocvw/dochost.c >

Re: widl: Write forward declarations for coclass definitions

Dan Hipschman wrote: On Thu, Aug 03, 2006 at 03:44:49PM +0200, Jacek Caban wrote: be used to implement an object. And HTMLDocument is IMO the best name. Also $ grep -w HTMLDocument dlls/mshtml/*.[ch] |wc -l 304 $ grep -w WebBrowser dlls/shdocvw/*.[ch] |wc -l 210 $ grep -w InternetExplorer

Re: widl: Write forward declarations for coclass definitions

Alexandre Julliard wrote: Dan Hipschman <[EMAIL PROTECTED]> writes: diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h index e0c1c3c..262ed37 100644 --- a/dlls/mshtml/mshtml_private.h +++ b/dlls/mshtml/mshtml_private.h @@ -53,7 +53,8 @@ typedef enum { EDITMODE

Re: Name problems with HTMLDocument, InternetExplorer and WebBrowser

Dan Hipschman wrote: Hi all, I'd like to submit a patch which makes widl output forward declarations to the header file for coclass definitions. Currently this is done only if the coclass has its own forward declaration. For example, [ uuid(...) ] coclass Foo; [ uuid(...) ] coclass Bar { ...

Re: VB6 app that embeds a browser window fails on wine; want test case?

Dan Kegel wrote: Piero Proietti wrote a nice demo app in VB6 which embeds a browser window. It doesn't work in Wine. I think Jacek has been committing patches that ought to help this ( e.g. http://winehq.org/pipermail/wine-cvs/2006-July/024993.html ) but it's not quite there yet. Yes, it shoul

Re: shdocvw: Added type library.

Alexandre Julliard wrote: Jacek Caban <[EMAIL PROTECTED]> writes: diff --git a/dlls/shdocvw/shdocvw.idl b/dlls/shdocvw/shdocvw.idl new file mode 100644 index 000..45b9111 --- /dev/null +++ b/dlls/shdocvw/shdocvw.idl You can't name the file shdocvw.idl, otherwise make

Re: Recent problems with shdocvw

Dan Kegel wrote: On 7/26/06, Jacek Caban <[EMAIL PROTECTED]> wrote: I have looked at bugzilla. There is one regression (bug 5630) that needs more widl improvements to work. I have done some work on widl that will help it some time ago, but I've never had time to finish it. Dan H

Re: Recent problems with shdocvw

Vitaliy Margolen wrote: Ever since replacement of Mozilla Active X control with new gecko. And shift of attention to mshtml we have lots of programs that still need shdocvw break. Is this a temporary or intentional? Could author look at related bugs on bugzilla? I have looked at bugzilla. T

Re: winnt32.exe on AMD64

Troy Rollo wrote: On Tuesday 18 July 2006 03:16, Ge van Geldorp wrote: the biggest problem is that the 64-bit calling conventions are different between PE executables and Linux executables. Some more info on the Wine64 wiki page http://wiki.winehq.org/Wine64 This isn't necessarily a hu

Re: oleview: Added skeleton for IDL files generation (1/2)

Hi Piotr, Piotr Caban wrote: Hi, Changelog: - Added skeleton for IDL files generation programs/oleview/main.h|8 programs/oleview/pane.c|9 programs/oleview/typelib.c | 96 +++- 3 files changed, 111 insertions(+), 2 deletion

Re: ole32: Get the threading model value for inproc classes and output a fixme if we should create it in an apartment of another type.

Robert Shearman wrote: Jacek, I have a patch that fixes the crash by validating the conditions on entry to CoGetClassObject (attached). However, this test still fails: err:ole:CoGetClassObject apartment not initialised url.c:768:http test... url.c:424: Test failed: unexpexted code 34 fixme:w

Re: [TOOLS] Re: Gecko installer

Jeremy Newman wrote: This is now live at: http://source.winehq.org/winegecko.php On Sun, 2006-06-25 at 11:40 +0200, Jonathan Ernst wrote: Le samedi 24 juin 2006 à 20:06 +0200, Jacek Caban a écrit : Hi, [...] - We need php script redirecting to SourceForge similar to one

Re: Gecko installer

Hi, Now that Wine Gecko installer is in the tree, we have to enable it. All we have to do on Wine side is set one registry value, but first we need to have wine_gecko.cab file available to download. It means: - Uploading wine_gecko.cab to SourceForge. I don't have an access to do so. Could so

Re: OleView: Removed use of strlenW, strcmpW and strcpyW functions

Hi, Piotr Caban wrote: Hi, Changelog: - Removed use of strlenW, strcmpW, strcpyW functions programs/oleview/details.c | 14 +++--- programs/oleview/tree.c| 16 2 files changed, 15 insertions(+), 15 deletions(-) -- Piotr You should also remove include wi

Re: Gecko installer

Mike Hearn wrote: On 6/14/06, Jacek Caban <[EMAIL PROTECTED]> wrote: See http://www.winehq.org/?issue=285#MSHTML%20Update. I'd really like to use Linux Gecko, but it's impossible because we'd need XEmbed embedder support that's impossible to implement in Wine (perhap

Re: Gecko installer

Mike Hearn wrote: On 6/14/06, Jacek Caban <[EMAIL PROTECTED]> wrote: Last week Wine Gecko was mentioned a few times on this mailing list and I can see that there is no understanding of it. It's not really surprising as it's a big mess ATM. We can still use Mozilla ActiveX c

Re: Gecko installer

Hi Boaz, Boaz Harrosh wrote: Hi Jacek. This would maybe also Address my problem. Please see my posting this week [Wine's Mozilla Control - Very old] I doubt if it's what you need. This implementation replaces windows' DLLs. What you need is something that replaces only the control. Choosing

Gecko installer

Hi. Please consider this mail as: Re: Built-in iexplore Re: acad 2004 licence file bug Re: Broken FC5 packages - stay clear. Last week Wine Gecko was mentioned a few times on this mailing list and I can see that there is no understanding of it. It's not really surprising as it's a big mess AT

Re: urlmon: Use FindMimeFromData to determine MIME type.

Alexandre Julliard wrote: > Jacek Caban <[EMAIL PROTECTED]> writes: > > >> dlls/urlmon/binding.c | 25 - >> 1 files changed, 20 insertions(+), 5 deletions(-) >> > > This breaks the tests: > > ../../../tools/ru

Re: DEVELOPER-HINTS: Some directories are renamed / removed / added

Hi Detlef, Detlef Riekenberg wrote: > Changelog: > > DEVELOPER-HINTS: Some directories are renamed / removed / added > > > @@ -192,11 +194,15 @@ DLLs (under dlls/): > Winelib programs (under programs/): > --- > > - avitools/ - AVI informati

Re: widl: Added an option to set importlib search path.

Alexandre Julliard wrote: > Thanks; my idea is that since we don't want to make widl load a tlb > from a builtin dll, we'll need to ship the raw tlb, and it would make > sense to ship it in the include dir since the lib dir already contains > the builtin dll. And when building Wine itself, we'll ne

Re: shdocvw 2: Added [get|put]_Visible implementation.

Dimi Paun wrote: > On Sun, 2006-04-30 at 23:40 +0200, Jacek Caban wrote: > >> I'll send a patch with comments. I'd prefer to add tests as well, but >> it has to wait for the switch to MSHTML based WebBrowser >> implementation (BTW that seems to be really near)

Re: shdocvw 2: Added [get|put]_Visible implementation.

Dimi Paun wrote: > On Sun, 2006-04-30 at 14:51 +0200, Jacek Caban wrote: > >> I also have tests showing that we do exactly what we should. The same >> applies to a few of my other similar patches. >> > > This is not as obvious to people, it would be be

Re: shdocvw 3: Added get_HWND implementation.

Robert Shearman wrote: > Jacek Caban wrote: > >> static HRESULT WINAPI WebBrowser_get_HWND(IWebBrowser2 *iface, long >> *pHWND) >> { >> WebBrowser *This = WEBBROWSER_THIS(iface); >> -FIXME("(%p)->(%p)\n", This, pHWND); >> -re

Re: shdocvw 2: Added [get|put]_Visible implementation.

Robert Shearman wrote: > Jacek Caban wrote: > >> static HRESULT WINAPI WebBrowser_put_Visible(IWebBrowser2 *iface, >> VARIANT_BOOL Value) >> { >> WebBrowser *This = WEBBROWSER_THIS(iface); >> -FIXME("(%p)->(%x)\n", This, Value);

Re: compile error

Stefan Leichter wrote: Hi, i am getting a compile error on current cvs. Does anyone else seeing this problem e.g. on git ? Does the attached patch help? Jacek diff --git a/tools/widl/parser.y b/tools/widl/parser.y index 9f288bf..4f3ed57 100644 --- a/tools/widl/parser.y +++ b/tools/widl/par

Re: SHDOCVW: Move IOleClientSite to new DocHost object to allow sharing code between WebBrowser and InternetExplorer.

Alexandre Julliard wrote: Jacek Caban <[EMAIL PROTECTED]> writes: ChangeLog: Move IOleClientSite to new DocHost object to allow sharing code between WebBrowser and InternetExplorer. Thanks for sending a series of small patches instead of a big one, but next time can you please

Re: exdisp.idl: Added missing attributes.

Robert Shearman wrote: Are these helpstrings an exact copy of what is in native? If so, I don't think we want them in Wine (and they are only useful to VB programmers anyway). I've added them because I wanted to have shdocvw typelib, that should be generated from exdisp.idl, as near to origin

Re: Prevent the use of windowsx.h with Wine source.

Robert Shearman wrote: > Mike McCormack wrote: > > >> +#ifdef __WINESRC__ >> +/* This file contains macros that cause warnings on gcc 4.1, so avoid it. */ >> +#error Please avoid use of windowsx.h in Wine source code. >> +#endif >> + >> >> > > Why don't we fix the macros as suggested by Fr

Re: shlwapi: Fix compilaction with GCC 4.1.

Robert Shearman wrote: > Jacek Caban wrote: > > >> Without this patch GCC 4.1 fails with message >> string.c:531: undefined reference to `strncmpW' >> >> >> > > That would seem to be a bug in GCC 4.1. I'm no expert on the C spec,

Re: shdocvw: Added get_LocationURL implementation.

Robert Shearman wrote: > > BSTR and LPWSTR are not interchangable. A lot of the time you can get > away with it, but if anything tries to access the length that prefixes > a BSTR on the LPWSTR then bad things will happen. > Right, thanks. I don't know, why I have changed it. I think I passed BSTR i

Re: implemented a couple of forwards from shdocvw to shlwapi.

Eric Pouech wrote: ChangeLog: - implemented a couple of forwards by ordinal from shdocvw to shlwapi dlls/shdocvw/misc.c | 70 + dlls/shdocvw/shdocvw.spec |9 +++--- 2 files changed, 75 insertions(+), 4 deletions(-) -

Re: 'make test' says "err:mshtml:load_gecko Could not load XPCOM: 126"

Dan Kegel wrote: Is the following err expected? No, it's not. MSHTML tried to load Gecko when it was not found. I'll send a patch that fixes it. Thanks for the report. Jacek.

Re: Fwd: dlls/wined3d/device.c GetCreationParameters

Hello. Al Tobey wrote: According to MSDN, this just sets a pointer to the creation parameters.The attached patch makes this function work, but I'm not sure if returning a pointer to the original parameters is the right approach or if they should be copied first. This patch makes a bunch of

Re: Mozilla ActiveX Control -- Browser not in a valid state

Hi. Phil Lodwick wrote: Before I start digging deeper, I was hoping somebody might have some insight to lead me down the correct path. Well, you can't do much with Mozilla ActiveX Control on Wine side... However the plan is to get rid of Wine's dependency on it. Currently MSHTML is implement

Re: URLMON: Removed not used code.

Troy Rollo wrote: Merely removing unused code does not give you any copyright in the file. On related matters, neither does fixing trivial bugs - there must be some substantial additional expression introduced to a file in order to give rise to a copyright claim. "Substantial" in this case mea

Re: SHDOCVW: Added implementation of IConnectionPoint::Advise and Unadvise.

Robert Shearman wrote: I think you need to AddRef disp here and release it appropriately in both Unadvise and on the final release. You're right, I forgot to release it in Unadvise, but I don't have to AddRef disp here as I get it from QueryInterface. I'll send an updated patch. Thanks,

Re: Does the Windows version of Mozilla need to be installed to use the Mozilla ActiveX plugin?

Hello. Aric Cyr wrote: >David D. Hagood aeroflex.com> writes: > > > >>Does the Windows version of Mozilla need to be in place for the Mozilla >>Active X control to work, or is there a way to point the control at my >>Linux install of Mozilla? >> >> Mozilla ActiveX Control doesn't need any

Re: Licensing and technical issues with a Wine package that includes the Mozilla ActiveX Control

Hi Scott, Scott Ritchie wrote: Now, the Mozilla ActiveX control is freely licensed, and we can redistribute it however we please. Unfortunately, to make it work in Wine we also need to use the dlls for the Microsoft Foundation Classes that it's written in such as msvcp70.dll, as Wine does not

Re: ATL creates wrong registry entries

Cihan Altinay wrote: Jacek Caban wrote: @@ -321,7 +321,7 @@ static HRESULT do_process_key(LPCOLESTR break; } -if(key_type != IS_VAL && key_type != DO_DELETE && *iter == '{') { +if(key_type != IS_VAL && key_type != DO_

Re: ATL creates wrong registry entries

Hi Cihan, Cihan Altinay wrote: Ok, I looked into it again and found a solution. The problem was that the '{' character was treated as a separator which is generally correct. But it seems that key names like the one mentioned above are allowed without single quotes around them. The attached patc

Re: ActiveX controls in MSHTML?

Dan Kegel wrote: A systems integrator mentioned that many commercial ERP applications use ActiveX terminal emulator controls embedded in web pages. (I think http://www.zephyrcorp.com/terminal-emulator-activex-document.htm is an example of such an ActiveX control.) Presumably these will run in IE

Re: MSHTML SoC project summary

Dimi Paun wrote: What do we need to do to get there? What is shdocvw using now? Builtin MSHTML works fine with shdocvw. urlmon is a bit worse. It currently fails after BindToStorage call. I didn't try to get it working with current implementation as it's really just a hack and my tests show

Re: MSHTML SoC project summary

Hello. A detailed and explicit TODO listing all the known missing bits on the Wiki page would be golden. Done, except for shdocvs as I don't have clean todo list for this one. Ditto for this one, with maybe a plan of attack (if you have one) and some effort estimate (if you know). I ha

MSHTML SoC project summary

Hello. As Dimi suggested, I'm writing here a summary of my SoC project. I was working on MSHTML implementation. More about what is MSHTML is on the wiki: http://wiki.winehq.org/MozillaIntegration so I won't rewrite it here. MSHTML generally works as HTML is displayed, but there is still a bit to

Re: hhctrl: Load the default Url in the HTML Pane

Hello. James Hawkins wrote: Hi, Changelog * Add the WebBrowser implementation. * Load the default Url in the HTML Pane. ... +static HRESULT STDMETHODCALLTYPE UI_ShowContextMenu(IDocHostUIHandler *iface, DWORD dwID, POINT __RPC_FAR *ppt, IUnknown __RPC_FAR *pcmdtReserved, IDispatch __RP

Re: Multiple defenitions of CLSID_FileProtocol

Hi. Paul Millar wrote: Hi, Cross-compilation is broken again. This time its CLSID_FileProtocol. The GUID is part of the standard MinGW 3.3 release. I can patch MinGW to remove its definition of this GUID, but I'm not sure this is the correct solution. What do people think? Cheers, Pa

Re: Opposite for wine_get_unix_filename()

Hi. Phil Krylov wrote: Hi, What can I use as a function opposite to wine_get_unix_filename() (e.g. to pass a filename to GetSaveFileNameW() dialog)? -- Ph. You may use wine_get_dos_file_name(). Jacek

Re: Theming Support

Stefan Dösinger wrote: Am Sonntag, 28. August 2005 10:28 schrieben Sie: Hello, Now that theming using .msstyle is working quite well, wouldnt'it be possible to use the current used theme in the currently used window manager. Btw, I have a really dumb question: How do I use a .msstyle t

Re: Throwing in an idea (probably it was discussed before though)

John Smith wrote: You can also set it yourselves in in your app. As configuration is in registry, every app can modify it. I like this idea, thanks. There are still 2 issues with such a soultion: a) most likely, it won't work until 2nd start of the application (we will modify it on the first

Re: Throwing in an idea (probably it was discussed before though)

Ivan Leo Puoti wrote: John Smith wrote: Situation is pretty simple. We have an application, which works Ok under WINE, provided that Managed=N specified Then just tell your users to set that in winecfg, AFAIK winecfg allows app specific settings. You can also set it yourselves in in you

<    3   4   5   6   7   8   9   >