Hi, Georgij,
+/*
+ * Copyright 2009 Vincent Povirk for CodeWeavers
+ *
+ * This library is free software; you can redistribute it and/or
Copypaste typo, I suppose.
--
Kirill
Hi Nathan,
+haystack_table_name = NULL;
r = table-ops-get_column_info( table, i, col_name, NULL,
NULL, haystack_table_name );
if( r != ERROR_SUCCESS )
I'm afraid, but this patch silences valgrind only, but does not solves the
Hi,
+int PASCAL wWinMain ( HINSTANCE hInstance, HINSTANCE prev, LPWSTR cmdline,
int show )
+{
extrac32 is a console application, isn't it? Why not wmain() instead? And get
rid of rather complex ParseCmdLine().
+if (!SetupIterateCabinetW( pszCabFile, 0, (PSP_FILE_CALLBACK)
ExtCabCallback,
Hi, Martin,
+ret = select(pipefd + 1, readfds, writefds, errorfds, NULL);
Passing NULL instead of writefds in this case is better, IMO. It is not used
anyway.
...and...
I strongly believe that errorfds parameter os select() is useful for sockets
only, not for stdio (I am not sure
Should I add a
check for sys/select.h in the configure script and conditionally included
it, surrounded by HAVE_SYS_SELECT_H? Or would sys/time.h, sys/types.h and
unistd.h be enough to consider it reasonably compatible?
Ideally - should. But...
1) There isn't any 'select.h' substring in whole
Hello
@@ -1802,7 +1802,7 @@ static HRESULT WINAPI
OLEPictureImpl_Load(IPersistStream* iface,IStream*pStm) {
hr=IStream_Read(pStm,header,8,xread);
if (hr || xread!=8) {
ERR(Failure while reading picture header (hr is %x, nread is %d).
\n,hr,xread);
- return hr;
It isn't obvious (your patch fot ret value). Why are you hiding all
codes except E_FAIL? Tests are needed, but I think you're hiding
something by this change.
Please, clarify, what patch are you trying to blame:
(1) [2/3] oleaut32: return correct error code.
or
(2) gdiplus: IPicture_SaveAsFile
Hi, Dan!
ALSA_CheckSetVolume returns right early because hctl is NULL,
but that error is not propagated through dsound properly.
While we should figure out the alsa part, for now, let's at least
propagate the error, and skip tests that can't be done without
sensing volume.
If this patch is
В сообщении от 29 июля 2008 Alexandre Julliard написал(a):
Kirill K. Smirnov [EMAIL PROTECTED] writes:
Hello, Alexandre,
dsound: check error status of waveOutGetVolume() function before using
retrieved values (found by valgrind)
http://www.winehq.org/pipermail/wine-patches/2008-July
Hello, Alexandre,
Is there anything wrong with this couple of patches:
dsound: check error status of waveOutGetVolume() function before using
retrieved values (found by valgrind)
http://www.winehq.org/pipermail/wine-patches/2008-July/058124.html
and
cmd: Do not deceive CompareString() passing
Hello,
According to wine-cvs mailing list, latest patch is
Vladimir Pankratov : hhctrl.ocx: Update Russian translation.,
but it cannot be fetched, after fetch/rebase the following patch is the
latest:
Huw Davies : winmm: Only fill in the MIXERLINEA struct if the call to
mixerGetLineInfoW
В сообщении от Saturday 19 July 2008 14:24:40 Nikolay Sivov написал(а):
This 'missed' commit goes to stable branch.
http://source.winehq.org/git/wine.git/?a=shortlog;h=refs/heads/stable
Thanks, I almost forgot about branches!
Sorry for nuisance.
--
Kirill
Hi,
Wine main page is not updated - there are no link to WWN 349. Partial patch?
--
Kirill
Hi,
+IDS_OPEN Октрыть
Typo.
+IDM_EXPERT,Переключится между режимом эксперт/новичок
ь is missing in word 'Переключится'.
--
Kirill
This doesn't look right. What if it's wineconsole with user backend
(default) and OEM CP (which is different then UNIXCP)? Should probably hack
GetConsoleOutputCP() instead.
this code is only used when no wineconsole is attached, so unixcp is the
right choice
No, this is used in case of
Hi,
+
+hWnd = GetConsoleWindow();
+
+SERVER_START_REQ( get_window_rectangles )
+{
+req-handle = hWnd;
+ret = !wine_server_call_err(req);
+colpix = reply-client.right - reply-client.left;
+linpix = reply-client.bottom - reply-client.top;
+colext
Hi,
nitpick:
+/* Trying to bind to the default hots interface,
using
Typo in word 'host'?
--
Kirill
Hi,
A successful call to fseek() shall clear the end-of-file indicator
for the stream and undo any effects of ungetc() and ungetwc() on
the same stream. After an fseek() call, the next operation on an
update stream may be either input or output.
}
+ /* Clear end of file */
+
Hi,
In the first patch of the series you really implement
SetConsoleDisplayMode() instead of GetConsoleDisplayMode(), don't you?
And it is dangerous to return success in pure stub functions, especially
GetConsoleDisplayMode(). Returning FALSE and setting last error to
Hi,
+LPSTR pBuffer;
+if (FormatMessageA(FORMAT_MESSAGE_FROM_SYSTEM |
+FORMAT_MESSAGE_IGNORE_INSERTS | FORMAT_MESSAGE_ALLOCATE_BUFFER,
+NULL, error, 0, (LPSTR)pBuffer, 0, NULL))
+{
+fputs(pBuffer, stdout);
+LocalFree(pBuffer);
+return
Hi,
Empty patches are attached to every e-mail in this series.
Size: 0 bytes
http://www.winehq.org/pipermail/wine-patches/2008-March/051638.html
http://www.winehq.org/pipermail/wine-patches/2008-March/051651.html
http://www.winehq.org/pipermail/wine-patches/2008-March/051641.html
...
--
Kirill
Kirill K. Smirnov [EMAIL PROTECTED] writes:
diff --git a/dlls/winex11.drv/winex11.drv.spec
b/dlls/winex11.drv/winex11.drv.spec index 36b83d7..126cbc5 100644
--- a/dlls/winex11.drv/winex11.drv.spec
+++ b/dlls/winex11.drv/winex11.drv.spec
@@ -130,6 +130,7 @@ # Desktop
# System tray
We don't want to export such a specific function. Besides, it should
really be setting the window shape.
I've just understood why we cannot rely upon setting window shape to get
transparency. Let's consider almost empty icon or even empty - this may
happen when application flashes icon, e.g.
Please explain better what you are doing, rewrite tooltips support
doesn't say what is changing or why the change is needed (and rewrite
is an exaggeration, you are mostly just moving code around).
The main issue this patch fixes is an attempt to set/modify a tooltip to a
nonexistent
В сообщении от Thursday 07 February 2008 02:58:42 вы написали:
Kirill K. Smirnov wrote:
@@ -71,6 +71,12 @@ struct icon
static struct tray tray;
static BOOL hide_systray;
+static BOOL add_icon(NOTIFYICONDATAW *nid);
+static BOOL modify_icon(NOTIFYICONDATAW *nid);
+static BOOL
I don't get why you need this change. PostMessage should correctly
handle the case where icon-owner has been destroyed and adding a call
to IsWindow just introduces a race condition.
Just a testcase:
1) run any wine app (to be sure that explorer is running), e.g winecfg
2) run taskmgr
3)
The rules are as follows:
* For case insensitive comparisons of 'windows strings', a Windows
function must be used (stricmp() or similar).
and
In this case, KERNEL32 lstrcmpiA() would be more appropriate. In
general, using stricmp() in Win32 code should be discouraged since it
may cause
Hi,
+IDS_INCORRECTPASSWORDTITLE Вход успешно произведён
The translation has opposite meaning than original.
+IDS_INCORRECTPASSWORD Убедитесь, что имя пользоватея\nи пароль
верны.
Typo in word пользоватея
--
Kirill
Still fails:
patching file programs/wineboot/wineboot.rc
patching file programs/wineboot/wineboot_Ru.rc
patch unexpectedly ends in middle of line
patch: malformed patch at line 46:
patch version is 2.5.4
Do you succeed applying this patch on your system?
I noticed that there is no
#include wineboot_Ko.rc
#include wineboot_No.rc
#include wineboot_Sv.rc
+#include wineboot_Ru.rc
\ В конце файла нет новой строки
Malformed patch. Please, rediff.
--
Kirill
Hi,
Is there something wrong with these couple of patches?
http://www.winehq.org/pipermail/wine-patches/2007-December/048436.html
kernel32/console: convert newborn wineserver handle to kernel32 console
handle.
This patch makes screenbuffer handle, returned by CreateConsoleScreenBuffer
-Exec=env WINEPREFIX=${WINEPREFIX:-$HOME/.wine} wine $path $args
+Exec=env WINEPREFIX=${WINEPREFIX:-$HOME/.wine} wine start $path $args
This is not correct. If console needs to be created for those apps and there
isn't one, then Wine should do it when starting an app.
This is correct. wine
Hi,
Is there anything wrong with the following patches?
winhelp: add basic support for ancient win3.0 help files
http://www.winehq.org/pipermail/wine-patches/2007-November/046886.html
and
comctl32: Implemented algorithm is a mergesort, not a quicksort
static void output(const char *message)
{
- DWORD count;
- WriteFile(GetStdHandle(STD_OUTPUT_HANDLE), message, strlen(message),
count, NULL);
+ DWORD count = 0;
+ WCHAR *mesW = NULL;
+ char *mes = NULL;
+ int wlen = 0;
+ int len = 0;
+
+ wlen
I think that will help you GetSystemMetrics() with SM_CXFULLSCREEN and
SM_CYFULLSCREEN but I did not verify it. Sorry if I shall be not right.
It is not what needed, but gives a clue: while reading GetSystemMetrics on
MSDN, I was referred to GetMonitorInfo again, but I was told to use rcWork
Hi,
I want to improve wineconsole a little, max hor and vert console window
dimensions. To achieve this, I need to know maximum available size of window
on the desktop.
The simpliest way I found is to use GetMonitorInfo, but it does not take
into account desktop panels. As the result,
My note is a nitpicking, but...
--- /dev/null 2007-06-28 07:33:44 +0400
+++ programs/net/Ru.rc 2007-07-13 10:05:45 +0400
@@ -0,0 +1,40 @@
+/*
+ * NET.EXE - Wine-compatible net program
+ * English language support
This file supports Russian language, not English
+ *
+ * Copyright (C) 2007
This is my first attempt at submitting a patch to WINE, so please excuse
me if I have broken any conventions or am going through the wrong
channel. As it currently stands, wine is setting the 'MWM_DECOR_BORDER'
hint on managed but undecorated windows, such as iTunes, or Winamp.
This does not
Hi,
I got the following error message during compile fresh git-current wine:
gcc -c -I../../../dlls/winex11.drv -I. -I../../../include -I../../include
-I/usr/X11R6/include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe
-fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings
Hi,
I'm trying to get winamp playlist window to be painted correctly (bug #8300).
The problem is:
0) wine version is git-current.
1) winamp playlist window style is WS_CLIPSIBLINGS
2) winex11 driver converts it to MWM_DECOR_BORDER hint. (window.c:599)
3) This hint behaviour is WM-dependent:
a)
Kirill K. Smirnov [EMAIL PROTECTED] wrote:
I'm trying to get winamp playlist window to be painted correctly (bug
#8300). The problem is:
0) wine version is git-current.
1) winamp playlist window style is WS_CLIPSIBLINGS
2) winex11 driver converts it to MWM_DECOR_BORDER hint. (window.c
Anyway, what is the purpose of setting MWM_DECOR_BORDER to borderless
window (style is WS_CLIPSIBLINGS only)? KDE, XFCE, fluxbox work OK
without it.
If you mean the following line in
dlls/winex11.drv/window.c,X11DRV_set_wm_hints()
else if (!(style (WS_CHILD|WS_POPUP)))
+/*
+ * Wordpad implementation
+ *
+ * Copyright 2007 by Damjan Jovanovic
+ *
It is not wordpad, is it?
+ok = CreateProcessW(exePath, NULL, NULL, NULL, FALSE, 0, NULL,
currentDirectory,
+startupInfo, processInfo);
This code does not run console apps correctly (use CREATE_NEW_CONSOLE
Hi, Alexandre,
Is there something wrong with my patch? Did I miss something important?
I'm not at all convinced that the conversion has to happen at that
point. Do you have a test app that demonstrates this?
I've written test application, which writes control chars and performs
readback
Please, comment, is there something wrong with these two patches? Did I miss
something?
http://www.winehq.org/pipermail/wine-patches/2007-July/041317.html
[Convert net.exe to unicode
Explicitly link against msvcrt]
and
http://www.winehq.org/pipermail/wine-patches/2007-July/041659.html
file: 2 tests executed (0 marked as todo, 0 failures), 0 skipped.
file: 373 tests executed (0 marked as todo, 0 failures), 0 skipped.
These lines are displayed via printf (include/wine/test.h: 391).
msvcrt:file done (0)
And this via xprintf (programs/winetest/main.c: 420), which is wrapper
+int PASCAL wWinMain ( HINSTANCE hInstance, HINSTANCE prev, LPWSTR cmdline,
int show )
Sorry for asking this too late, but what's the point to use WinMain in pure
console application? 'cmd' and 'xcopy' use wmain.
--
Kirill
Hi,
+MODULE= EXTRAC32.exe
It is very unusual to have upper-case name of exe file
WriteConsole(GetStdHandle(STD_OUTPUT_HANDLE),Run Wine Extrac32.
\n,strlen(Run Wine Extrac32.\n),NULL,NULL);
The utility is compiled as UNICODE (EXTRADEFS = -DUNICODE), thus WriteConsoleW
is used, but here
Hi,
I've tried to reproduce, but failed:
a.c:
#include stdio.h
#include stdlib.h
int main(void)
{
system(qqq.exe);
return 0;
}
$ mingw-gcc -mconsole -mno-cygwin a.c
$ wine a.exe
It works.
$ mingw-gcc a.c
$ wine a.exe
It works too.
Executable qqq.exe exists in
I've tried MSVC 6.0 and MSVC 2003. All the same - it works. Please, check your
sources. I have no idea where the bug can be.
Yes, the mingw-gcc case works.
But I use the Visual C++ 7.0 to compile. It still fails.
On 6/26/07, Kirill K. Smirnov [EMAIL PROTECTED] wrote:
Hi,
I've tried
I think original phrase Файл, ассоциированный с
расширением %s,отсутствует\n is better (but there is a typo in it -
missing space after second ,). And word ассоциированный do sounds like
Russian (and has frequent use in books and speech), and I like it more than
less familiar (to me)
+ WCMD_YES, Д
+ WCMD_NO, Н
Answers to Yes/No question should not be translated, should they? All
too.
I think that should translate this answers because in some languages
such as Norwegian,German and Korean it was translated.
I really doesn`t understand why in Russian language this
Hi, Anatoly!
The translation is still very raw. Please, verify it.
+ WCMD_YES, Д
+ WCMD_NO, Н
Answers to Yes/No question should not be translated, should they? All too.
+ WCMD_NOASSOC, Файл, ассоциированный с расширением %s,отсутствует\n
This phrase does not sound Russian. Отсутствует
You probably forget to run 'autoconf'.
I can see nice messages like:
$ autoconf
...
$ ./configure
...
$ make depend
...
$ make
...
CC extrachunk.o
CC factory.o
CC getframe.o
CC icmstream.o
CC regsvr.o
CC tmpfile.o
I get the following (on Slackware 11) while running the make depend
portion of
Hi Jason,
Since German and Korean resource have been updated, this patch is a little
outdated and cannot be applied. Please, rediff.
Other patches may be outdated too.
--
Kirill
В сообщении от 26 мая 2007 21:24 вы написали:
I'll double check later, but are you sure?
When I said I hadn't changed the patches, I meant the contents, but I had
done a git fetch, git rebase origin on the branch (and resolved the german
resource conflict) before resubmitting
I got the
Hi,
Something strange happened to git - fetch fails if uses git:// protocol.
In tcpdump I can see my machine and wine.codeweavers.com chating. Thus
connection is OK.
When I changed protocol to http:// in .git/remotes/origin, I managed to
update local git repo. This is very strange -
Did you happen to update curl/libcurl?
No, I did not update anything for a few weeks. Git stopped to work a couple of
days ago.
Should I update curl? My version is 7.15.3.
+static void test_MultiByteToWideChar(void)
+{
+int i, ret;
+static char src[32];
+static WCHAR dst[32];
+static const WCHAR glyphed_dst[32] = {
+0x, 0x263A, 0x263B, 0x2665, 0x2666, 0x2663, 0x2660, 0x2022,
+0x25D8, 0x25CB, 0x25D9, 0x2642, 0x2640, 0x266A,
Hi,
In my serie of four patches the two has not been applied:
[kernel32/tests: Add tests for console codepages]
http://www.winehq.org/pipermail/wine-patches/2007-May/039092.html
[move codepages to server side]
http://www.winehq.org/pipermail/wine-patches/2007-May/039093.html
Please, comment,
В сообщении от 30 апреля 2007 16:26 вы написали:
Hi,
A week ago I've sent a patch which fixes console input/output codepages
handling.
http://www.winehq.org/pipermail/wine-patches/2007-April/038429.html
It is still not applied, so please, explain, what is wrong with it? It even
fixes 2
just a dummy question... does the different fonts your tests refer to
have all the glyphs required ? (or said differently, isn't this a font
issue about the required glyphs for russian ?)
A+
By default (in 866 OEM codepage) wine console renderer behaves just like
windows does, the difference
+
+/* adds glyphs to the string */
+static inline void add_glyphs( WCHAR *str, unsigned int length )
+{
+unsigned int i;
+for (i=0; i!=length; i++) {
+ if (str[i]0x20) str[i]=glyph_xlat[str[i]];
+}
+}
Page
http://blogs.msdn.com/michkap/archive/2005/02/26/381020.aspx
В сообщении от 23 апреля 2007 16:11 вы написали:
Kirill K. Smirnov [EMAIL PROTECTED] wrote:
The written strings in 866 and 1251 code pages are only readable
when output console code page matches the string encoding.
This is in wine.
In windows only cp866 is readable
Hi,
A week ago I've sent a patch which fixes console input/output codepages
handling.
http://www.winehq.org/pipermail/wine-patches/2007-April/038429.html
It is still not applied, so please, explain, what is wrong with it? It even
fixes 2 tests:
$wine kernel32_test.exe.so process
before:
Now, I am writing tests for this.
Windows crashes if I pass NULL pointer to these function.
Crash can be easily avoided in wine.
Should we crash too?
And how the windows crash can be caught? Or just I should not write such
test-case?
Thanks,
--
Kirill
Hi,
I've sent the patch:
http://www.winehq.com/pipermail/wine-patches/2007-April/038205.html
about a week ago and it has not been applied. Please, explain, what is wrong
with it?
Thanks
--
Kirill
On 4/24/07, Kirill K. Smirnov [EMAIL PROTECTED] wrote:
Hi,
I've sent the patch:
http://www.winehq.com/pipermail/wine-patches/2007-April/038205.html
about a week ago and it has not been applied. Please, explain, what is
wrong with it?
You haven't sent in any tests for this function
For containing backshash. Yes, comment must be better.
A comment that states you're looking for a backslash is superfluous;
the code makes that obvious. A better comment would be 'check for
filename only' or something along those lines.
Maybe, 'MSDN claims that if filename contains
Kirill K. Smirnov [EMAIL PROTECTED] wrote:
WriteConsole uses current console output code page to translate strings.
wine - yes.
windows - no.
See attach.
What makes you think so? Since I tested under Windows only I described
the results I've got under it not under Wine. Wine
Kirill K. Smirnov [EMAIL PROTECTED] wrote:
A question: what make you think that WriteConsole uses current console
output code page to translate strings?
The written strings in 866 and 1251 code pages are only readable
when output console code page matches the string encoding
Kirill K. Smirnov [EMAIL PROTECTED] wrote:
The written strings in 866 and 1251 code pages are only readable
when output console code page matches the string encoding.
This is in wine.
In windows only cp866 is readable regardless of ConsoleOutputCP.
As I said I tested under Windows (XP
Kirill K. Smirnov [EMAIL PROTECTED] wrote:
The written strings in 866 and 1251 code pages are only readable
when output console code page matches the string encoding.
This is in wine.
In windows only cp866 is readable regardless of ConsoleOutputCP.
As I said I tested under
В сообщении от 23 апреля 2007 16:11 вы написали:
Kirill K. Smirnov [EMAIL PROTECTED] wrote:
The written strings in 866 and 1251 code pages are only readable
when output console code page matches the string encoding.
This is in wine.
In windows only cp866 is readable regardless
No, from this point of view the patch is correct.
+/*
=
+ * Output a formatted unicode string. Ideally this will go to the console
+ * and hence required WriteConsoleW to output it, however if file i/o is
+ *
I've just found another bug in the patch:
+ /* Convert to OEM, then output */
+ convertedChars = WideCharToMultiByte(GetConsoleOutputCP(), 0,
output_bufW,
+ len, output_bufA, MAX_WRITECONSOLE_SIZE,
+ ?, usedDefaultChar);
The
+if (strchrW(name, '\\'))
+return TRUE;
What is the point of this? You're returning TRUE no matter what anyway.
+FIXME((%s): stub!\n, debugstr_w(name));
+return TRUE;
ancient patch in attach, sorry.
If FILE_name_AtoW fails, the function fails, so the return value should be
FALSE, shouldn't it ?
TRUE means that current directory '.' should be added to PATH.
FALSE is returned if a special environment variable
NoDefaultCurrentDirectoryInExePath is set.
Of course, default sane value should be
I've tried the test with winelib and got:
$ winegcc test.c
$ ./a.out nya
$ od -x nya
000 3f3f 3f3f 3f3f 3f3f 0066
011
This output differs from previous. I tried this under several locales, the
results are the same.
test.c:
void main() { wprintf(Ltest with wprintf); }
I continued my
I've tried the test with winelib and got:
$ winegcc test.c
$ ./a.out nya
$ od -x nya
000 3f3f 3f3f 3f3f 3f3f 0066
011
This output differs from previous. I tried this under several locales, the
results are the same.
When I applied the patch, EXE version (I used mingw32 instead of VC
Just some thoughts in hope they would help:
There is special utility called 'mode' in Windows.
I can select output locale:
mode con cp prepare ...
mode con cp select ...
I think it would solve many problems if similiar tool will be implemented in
wine.
[bug #8022 comment #7]
--
Kirill
A 209.46.25.134
[jwhite] host www.winehq.org foghorn.codeweavers.com
www.winehq.org A 209.46.25.134
That suggests everything is good here.
But that is still rather freaky; do you suppose someone
is hijacking your DNS records somehow?
Cheers,
Jeremy
Kirill K. Smirnov wrote
Hi,
I've noticed very strange thing today: www.winehq.org resolves to
http://searchportal.information.com/index.mas?epl=00630086VFAXVE0DWlgVVRBeVwtAVw5ZB14NW1YMBAhCUVZRWRQbWxBfHwRsXQUNU1oBVFc
This site claims to be winehq.org.
Winehq.org - What you need, when you need it
I cannot perform git
Hi,
Similar question has been discussed before:
http://www.winehq.org/pipermail/wine-devel/2006-November/052140.html
http://www.winehq.org/pipermail/wine-devel/2006-November/052142.html
http://www.winehq.org/pipermail/wine-devel/2006-November/052143.html
You only need to add an English
Hi,
I've asked before:
What's wrong with them? Maybe, unnecessary PeekMessage in tests???
http://www.winehq.org/pipermail/wine-patches/2007-January/035044.html
http://www.winehq.org/pipermail/wine-patches/2007-January/035043.html
Please, answer! Do not ignore!
--
Kirill
Anything wrong with them again?
http://www.winehq.org/pipermail/wine-patches/2007-January/035044.html
http://www.winehq.org/pipermail/wine-patches/2007-January/035043.html
Thanks,
Kirill
Hi,
these patches
http://www.winehq.org/pipermail/wine-patches/2007-January/035014.html
http://www.winehq.org/pipermail/wine-patches/2007-January/035052.html
totally break qip IM icons. (www.qip.ru).
I suspect the reason is hidden in GetDIBits(...) - resulting AND mask is not
correct. XOR mask
Hi!
While improving rejected tests for WM_SETICON:
http://www.winehq.org/pipermail/wine-patches/2007-January/034949.html
I've noticed, that WinXP sends some mysterious message 0xae, that breaks
tests.
Googling it, I've found few notes indicating to WM_NCUAHDRAWCAPTION
[0xae] message and
Hi,
Traditional questions from rejected patch-sender:
1) What's wrong with the patch:
http://www.winehq.org/pipermail/wine-patches/2007-January/034949.html
2) What can be done to improve it?
-- Kirill
Hi,
Traditional questions from rejected patch-sender:
1) What's wrong with the following patches?
http://www.winehq.org/pipermail/wine-patches/2007-January/034758.html
http://www.winehq.org/pipermail/wine-patches/2007-January/034790.html
2) What can be done to improve them?
Those patches let
It's not transparent,
Hm... Yes, it is not transparent. It is pseudo-transparent. Just for us.
it's painted with what you hope is the same
background as the parent, but there's no guarantee of that.
Xlib thinks opposite.
The window will be painted with the same background as the parent (not
Or I miss something really important? If so, just provide a use-case,
please!!
Well, for instance if the parent is a Wine window, which would be the
case when someone implements systray handling in desktop mode, it
would break since Wine windows are not painted with the background
pixmap.
Kirill K. Smirnov [EMAIL PROTECTED] writes:
Please, explain me, what is wrong with this serie of patches?
What to do to improve them?
As I said, making the background pixmap ParentRelative is just a hack,
it's not real transparency.
Why is it not a real transparency? This is the easiest
.html
http://www.winehq.org/pipermail/wine-patches/2007-January/034412.html
http://www.winehq.org/pipermail/wine-patches/2007-January/034413.html
Regards,
Kirill K. Smirnov
Kirill K. Smirnov [EMAIL PROTECTED] writes:
@@ -366,6 +366,7 @@ static void systray_dock_window( Display
wine_tsx11_lock();
XSendEvent( display, systray_window, False, NoEventMask,
ev );
+XSetWindowBackgroundPixmap(display, data-whole_window
is OK.
Thanks for pointing the path!
-- Kirill K. Smirnov
diff --git a/dlls/winex11.drv/window.c b/dlls/winex11.drv/window.c
index 1430563..f7c34b0 100644
--- a/dlls/winex11.drv/window.c
+++ b/dlls/winex11.drv/window.c
@@ -71,10 +71,10 @@ inline static BOOL is_window_managed( HW
{
DWORD
, should we disable the managed checkbox?
Thanks in advance,
-- Kirill K. Smirnov
diff --git a/dlls/winex11.drv/window.c b/dlls/winex11.drv/window.c
index 1430563..f7c34b0 100644
--- a/dlls/winex11.drv/window.c
+++ b/dlls/winex11.drv/window.c
@@ -71,10 +71,10 @@ inline static BOOL is_window_managed
Hi, all!
Just a little question: can wine's current implementation of mshtml.dll be
used as html parser? I need to convert html code into a tree without
displaying it.
I tried to look through the code, but I'm not familiar with OLE. BTW some
E_NOIMPL confused me.
Thanks in advance
CreateHTMLDocument2(...) but failed.
-- Kirill K. Smirnov
Hi!
Please, tell me what's wrong with the patch?
http://www.winehq.org/pipermail/wine-patches/2006-November/032984.html
-- Kirill K. Smirnov
1 - 100 of 112 matches
Mail list logo
