Google Web Accelerator

2005-05-05 Thread Matthew Mastracci
To indulge my habit of trying the newest Google software releases under Wine, I decided to give the new Google Web Accelerator a shot with the latest CVS. The first issue that I ran into (patches sent to wine-devel!) was the lack of StgCreateStorageEx and StgOpenStorageEx. This seems to be use

Re: dib.c problem, and Solution to winmm deadlocking problem

2005-04-10 Thread Matthew Mastracci
Robert Lunnon wrote: After weeks of searching I have finally found my deadlock problem. Its actually not related to audio at all it's a ddraw problem with poor error handling, the surface wasn't released properly when the error "Application gave us bad source rectangle for Blt." occurs I address

Re: DDRAW: Surface locking patch, take 2

2005-03-26 Thread Matthew Mastracci
Matthew Mastracci wrote: This patch (correctly) fixes the locking problems in SimCity 3000. We now check to see if the blit src and dest are the same surface and, if so, we make sure to lock the surface only once and, in the case of BltFast, re-adjust the surface pointers. This patch also

Re: DDRAW: Surface locking patch, take 2

2005-03-20 Thread Matthew Mastracci
Christian Costa wrote: Hi Matthew, This seems fine. There are some comments though, see below. ... +if (src == iface) { +int pitch; + +UnionRect(&lock_union, &lock_src, &lock_dst); + +/* Lock the union of the two rectangles */ +IDirectDrawSurface7_Lock(iface, &lo

Re: ddraw correctness fixes patch

2005-03-20 Thread Matthew Mastracci
Christian Costa wrote: I think the problem Matthew was talking is how to remap surface pointers. I sent something to Mattew but I forgot to cc wine-devel, sorry. Basically it was : depth = surface_desc.u4.ddpfPixelFormat.u1.dwRGBBitCount; ddesc.lpSurface -= (lock_dst.left - lock_union.left)*(depth+

Re: ddraw correctness fixes patch

2005-03-18 Thread Matthew Mastracci
Thanks for the review - comments inline. Christian Costa wrote: The new locking mechanism is wrong. DDLOCK_xxx are just used for optimization. The thing to do during the blit should be something like that : sdesc.dwSize = sizeof(sdesc); ddesc.dwSize = sizeof(ddesc); if (src == NULL) IDirectDrawSu

Re: Regression (SimCity 3000 is Broke )

2005-03-15 Thread Matthew Mastracci
I tried putting in the patch as you demonstrated and I could not get it to work (get the proper behavior from SimCity 3000). That is why I came back with the patch that I did. It is possible I did not understand your intent so I would be happy to try a real patch from you. I ran the Sim City 300

Re: Regression (SimCity 3000 is Broke )

2005-03-15 Thread Matthew Mastracci
Tony Lambregts wrote: Matthew Mastracci wrote: DDLOCK_NOSYSLOCK prevents DirectDraw from locking "system lock", which is a global 16-bit lock on Windows 9x systems. I don't think this is the right way to fix this. Check out this page here: http://msdn.microsoft.com/library/

Re: Regression (SimCity 3000 is Broke )

2005-03-15 Thread Matthew Mastracci
Mike Hearn wrote: On Tue, 15 Mar 2005 12:28:48 -0700, Matthew Mastracci wrote: This flag has no effect on Windows 2000 or Wine, since they don't have global Win16 locks (AFAIK). Well we have the Win16 syslevel, is that what you mean? Whoops - I guess Wine does have the same system-level

Re: Regression (SimCity 3000 is Broke )

2005-03-15 Thread Matthew Mastracci
2.asp This flag has no effect on Windows 2000 or Wine, since they don't have global Win16 locks (AFAIK). Matt. Tony Lambregts wrote: Matthew Mastracci wrote: (removing Paul from CC) I think the problem is that we lock both the src and dest surfaces, without checking to see if they are the sa

Re: Regression (SimCity 3000 is Broke )

2005-03-15 Thread Matthew Mastracci
(removing Paul from CC) I think the problem is that we lock both the src and dest surfaces, without checking to see if they are the same. I think we then try to lock both surfaces and one of the locks fails. Perhaps this might be a better solution: if (src == iface) { DD_STRUCT_INIT(&

Re: [advpack] Implement RegisterOCX and stub out DelNodeRunDLL32

2005-03-14 Thread Matthew Mastracci
Dmitry Timoshkov wrote: "Matthew Mastracci" <[EMAIL PROTECTED]> wrote: +typedef HRESULT (*DLLREGISTER) (void); Shouldn't it have a WINAPI modifier? Good point, thanks. I'm sending an updated patch to wine-patches with the WINAPI modifier. Note that I co

[advpack] Implement RegisterOCX and stub out DelNodeRunDLL32

2005-03-14 Thread Matthew Mastracci
This patch helps the IE6 installer get past the DLL registration stage. The DelNodeRunDLL32 function is stubbed out, but RegisterOCX will correctly register a COM DLL by calling its DllRegisterServer function. ChangeLog: * dlls/advpack/advpack.c Matthew Mastracci <[EMAIL PROTEC

Re: [PATCH] MapiSendMail() implementation

2005-03-08 Thread Matthew Mastracci
Mike Hearn wrote: On Mon, 2005-03-07 at 20:21 +0100, Michael Stefaniuc wrote: Gnome has the notion of "default email client", i suspect KDE has it too. Unless you use Bonobo+Evolution (and maybe KMail+DCOP) though you can't match the abilities of MAPI, which lets you create arbitrary emails. Mozil

DirectDraw YUV overlays

2005-03-06 Thread Matthew Mastracci
I've been investigating the YUV overlays used by Picasa and it seems like it would be a huge problem to tackle this sort of support without some sort of external YUV conversion library and/or hardware support. SDL has great support for transparent hardware/software YUV support; it might be poss

Re: Picasa2- slideshow mode fixes [patch #1]

2005-03-06 Thread Matthew Mastracci
Mike Hearn wrote: Woo, go Matthew! On Sun, 06 Mar 2005 00:55:29 -0700, Matthew Mastracci wrote: I don't know if I should submit this as part of a patch, since it doesn't implement the functionality. Here is the change, for those interested: No no, please do. Better stubs are

Re: Picasa2- slideshow mode fixes [patch #1]

2005-03-06 Thread Matthew Mastracci
| DDFXCAPS_BLTMIRRORUPDOWN | DDFXCAPS_BLTROTATION90\ Matthew Mastracci wrote: I've been trying to get the slideshow mode in Picasa2 to work, but it seems like it's relying on IDirectDrawSurface->Lock() to return DDERR_SURFACEBUSY if the surface is already locked. If this call does

Picasa2- slideshow mode fixes [patch #1]

2005-03-06 Thread Matthew Mastracci
I've been trying to get the slideshow mode in Picasa2 to work, but it seems like it's relying on IDirectDrawSurface->Lock() to return DDERR_SURFACEBUSY if the surface is already locked. If this call doesn't return the error, it seems to keep hammering the function until it does. It then proce

[SOLVED] Re: Picasa2- works great, one font issue

2005-02-28 Thread Matthew Mastracci
the MAPI stubs that cause it: err:mapi:MAPILogon Stub fixme:seh:EXC_RtlRaiseException call (from 0x53e297) to unimplemented function mapi32.dll.MAPISendMail Thanks, Matt. Matthew Mastracci wrote: I tried out the latest Picasa2 (picasa2-setup-1884.exe) on a whim against the Wine 20050111 package and it works gr