Re: [AVIFIL32] question about ACMStream_fn[AddRef|Release] in acmstream.c

place at the end of the Release function. Can anybody confirm my finding. You are right, the release method is buggy. the comparision must check against one instead of zero or the decrement in the return statement must be moved before this if-statement. Michael Günnewig

Re: acmstream mem leak fix

another discussion about what's wrong or correct. When you don't understand the code feel free to write me as I'm the one who has produced it. Regards Michael Günnewig

Re: [dx88] Cull fix

Jason Edmeades [EMAIL PROTECTED] writes: Michael - See if this helps with your map / figure problems... Sorry, but it doesn't helped. Also the other ones doesn't helped. The fixme's fixme:d3d_surface:IDirect3DSurface8Impl_LockRect fixme:d3d:IDirect3DDevice8Impl_SetRenderTarget

Re: {Heap,Global,Local,}ReAlloc status (take 2)

Dimitrie O. Paun [EMAIL PROTECTED] writes: Hi folks, Oleg has been doing a lot of good work, and we are now down to 73 HeapReAlloc and 73 non-HeapReAlloc entries to review. I'm still not sure how the comctl32.ReAlloc() should behave, any help in getting that resolved would be highly

Re: Misc bugs found by using valgrind

Alexandre Julliard [EMAIL PROTECTED] writes: [EMAIL PROTECTED] (Michael Günnewig) writes: It's a point, so here is the new patch. I don't think we need to check string sizes against MAXINT, that's just a waste of time. Okay you're correct, the check isn't necessary as MAXINT * 2 is MAXUINT

Re: [dx85] vertex blend fixmes

Jason Edmeades [EMAIL PROTECTED] writes: Michael - This will silence those horrible fixmes about worldmatrix(0..255) and vertex blend not being supported - We incorrectly return support since the NVidia drivers dont claim support for it, but DO return a number for the GL_MAX_VERTEX_UNITS_ARB

Re: Bug in the heap management code?

Lionel Ulmer [EMAIL PROTECTED] writes: Yes and no. valgrind still doesn't support many instructions... Well, using any DRI GL libraries or the NVIDIA GL libraries is not really supported by Valgrind right now... Yes, but even with Mesa it bombs. Seems to be that quartz.dll is the problem,

Re: Bug in the heap management code?

[EMAIL PROTECTED] (Michael Günnewig) writes: Mike Hearn [EMAIL PROTECTED] writes: This is very much like a problem I am having with InstallShield. Something, somewhere, is trashing the heap data structures, which causes a crash some time later, often yards away from the original bug. As far

Re: [DXT3] menu in Tribunal now vanishes (regression?)

Stephen Pedrosa Eilert [EMAIL PROTECTED] writes: Weird... how come Morrowind have started working all of a sudden? It crashed for me. I wasn't aware of any patches affecting the problem I was having with it (the original version, but now I have the two expansions available). Time to retest

[DXT3] menu in Tribunal now vanishes (regression?)

Hallo, with the following 2 patches the menu in The Elder Scrolls III: Tribunal Morrowind Expansion Pack version 1.4.1313 german only shows white blocks instead of the menuitems as before. When IDirect3DImpl_CheckDeviceFormat reports that D3DFMT_DXT3 isn't supported the menuitems will draw