that
interim versions that fail tests are frowned upon.
Thank you for looking at the patch nevertheless,
Michael Karcher
Am Montag, den 25.01.2010, 10:47 +0100 schrieb Paul Vriens:
On 01/25/2010 09:37 AM, Michael Karcher wrote:
Am Montag, den 25.01.2010, 15:27 +0800 schrieb Dmitry Timoshkov:
The current code misdetects both Windows XP and Wine as Win9x and skips
some tests due to this. The SetParent tests
by the currently provided binaries (because of the also broken win9x
checks), it wouldn't help.
Regards,
Michael Karcher
Am Montag, den 27.07.2009, 13:24 +0900 schrieb Dmitry Timoshkov:
Michael Karcher w...@mkarcher.dialup.fu-berlin.de wrote:
The meaning of enable is the same in Windows and Wine: it enables the
execute permission, not the data execution prevention.
JFYI, I based my original patch
dlls/ntdll/tests/exception.c
framework.
You are right, I will resubmit the series. I was just grepping for
__TRY in the tests to find a source file to add to, so I didn't find
that stuff because it sets up the handler manually.
Regards,
Michael Karcher
\Windows
\CurrentVersion\Applets\Regedit.
Regards,
Michael Karcher
Am Donnerstag, den 02.07.2009, 09:02 +0200 schrieb Paul Vriens:
There is no need for the RegCloseKey as you are opening a predefined one.
Are you sure? He opens HKCU\Software\Microsoft\Windows\CurrentVersion
\Applets\Regedit
Regards,
Michael Karcher
signature.asc
Description: Dies ist ein
just fixed that bug and your statement:
Color on monochrome bitmap is seldomly used anyway sounded an alarming
bell in my head. This mail was just a warning to not disregard the issue
and no specific problem report.
Regards,
Michael Karcher
decide this behaviour to be a bug, we want it to
be in Wine as Wine should be bug-to-bug compatible.
Regards,
Michael Karcher
variable to
the current location, and then calls a printing function passing and
evaluating the parameters. If one of them changes the global variable
already set, the location printed is wrong, as you see here.
Regards,
Michael Karcher
byte boundary to get the correct data. #4/10 corrects
that problem for both reading and writing.
That's really ugly.
That's only the case if the device has been opened with O_DIRECT. For
buffered read/write, no alignment is needed.
Regards,
Michael Karcher
as that can translate 16 bit assembler code.
Regards,
Michael Karcher
italic transformation was just ignored, so roman characters were
displayed, now WineEngGetGlyphOutline runs into this error case,
breaking applications trying to use MS Sans Serif in italic.
Regards,
Michael Karcher
Am Dienstag, den 17.02.2009, 09:19 +0100 schrieb Michael Karcher:
Should fix bug #17050
Doesn't do. Please ignore.
have to allow your clients to pass it on for free.
From memory, GPL allows you to charge for the cost of delivering the
software (e.g. CD media, postage), but not the binaries themselves.
This just applies to the source code.
Regards,
Michael Karcher
at that point. Just as a hint how to
attack such beasts, if you encounter things like that again.
Regards,
Michael Karcher
Output NULL pointers into proxy table and STUB_FORWARDING_FUNCTION into
stub tables if a local function has no call_as function associated, just
as MIDL does.
try 2: Fix various mistakes (one of them found by Rob Shearman)
try 3: Rebased to current git
---
tools/widl/proxy.c | 51
typdef [wire_marshal(wirefoo)] foo * pfoo;
made widl incorrectly set the RPC_FC_P_DEREF bit for pfoo. But this
declares a user-marshalled pointer, so the RPC runtime must not dereference
it before passing it on to the UserFoo functions.
---
tools/widl/header.h |3 ++-
1 files changed, 2
This matches midl behaviour. In
void test1([out,size_is(x)] char str[], [in] int x);
void test2([size_is(x), out] char* str, [in] int x);
the parameter to test1 is not NULL-checked, but the one to test2 is.
---
tools/widl/client.c|2 +-
tools/widl/proxy.c | 15 ++-
---
tools/widl/header.c | 24
tools/widl/header.h |2 ++
tools/widl/typegen.c | 24
tools/widl/typegen.h |1 -
4 files changed, 26 insertions(+), 25 deletions(-)
diff --git a/tools/widl/header.c b/tools/widl/header.c
index
If we take MIDL 6.00.0366 as reference, the following method type is
legal:
void frobnicate([size_is(x),in,out] int * bar1,
[size_is(*bar1),out] int * bar2,
[in] int x);
Without this patch, size_is(*bar1) would be rejected.
---
get_deref_type yields the type of array elements for arrays or the
pointed-to type of pointers. Most important, it works on anything
is_declptr returns true for.
---
tools/widl/header.h |1 +
tools/widl/typegen.c| 15 +++
tools/widl/write_msft.c |3 +--
3 files
---
tools/widl/typegen.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/widl/typegen.c b/tools/widl/typegen.c
index 2b0e414..7dfa0b2 100644
--- a/tools/widl/typegen.c
+++ b/tools/widl/typegen.c
@@ -3046,7 +3046,7 @@ static void
---
tools/widl/proxy.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/tools/widl/proxy.c b/tools/widl/proxy.c
index 4e69190..bb16b72 100644
--- a/tools/widl/proxy.c
+++ b/tools/widl/proxy.c
@@ -182,6 +182,11 @@ int cant_be_null(const var_t *v)
if
Am Samstag, den 10.01.2009, 22:21 + schrieb Reece Dunn:
2009/1/10 Michael Karcher w...@mkarcher.dialup.fu-berlin.de:
Output NULL pointers into proxy table and STUB_FORWARDING_FUNCTION into
stub tables if a local function has no call_as function associated, just
as MIDL does.
Shouldn't
Am Samstag, den 10.01.2009, 22:32 + schrieb Rob Shearman:
2009/1/10 Michael Karcher w...@mkarcher.dialup.fu-berlin.de:
get_deref_type yields the type of array elements for arrays or the
pointed-to type of pointers. Most important, it works on anything
is_declptr returns true for.
I
Am Samstag, den 10.01.2009, 22:41 + schrieb Rob Shearman:
2009/1/10 Michael Karcher w...@mkarcher.dialup.fu-berlin.de:
If we take MIDL 6.00.0366 as reference, the following method type is
legal:
void frobnicate([size_is(x),in,out] int * bar1,
[size_is
series
tomorrow (and to the right address, of course!)
Regards,
Michael Karcher
RTF_LLINFO later on)
Regards,
Michael Karcher
to rebase and resend these? If not, I can do
this.
They got in:
http://source.winehq.org/git/wine.git?a=commit;h=656de48e4ea5f15b5ecc58923e3a0e2f0c3fae90
http://source.winehq.org/git/wine.git?a=commit;h=5f7886925db80cfe93aea89b4b3d604ab62e1cc8
Regards,
Michael Karcher
and unsigned
small as FC_SMALL.
Like I said, I'm no IDL expert. Does the stuff above make sense to you? Do
you think it would be a good idea to change WIDL to generate the same
encodings as MIDL?
Yes, and in fact Michael Karcher has already sent in a pair of patches
to do this:
http
?
what about
(void)write(*(This-fd), event, sizeof(event));
Does that work to? Seems nicer than the if.
Regards,
Michael Karcher
signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil
Am Sonntag, den 04.01.2009, 00:30 + schrieb Rob Shearman:
2009/1/3 Michael Karcher w...@mkarcher.dialup.fu-berlin.de:
@@ -548,8 +548,9 @@ static int write_proxy_methods(type_t *iface, int skip)
if (iface-funcs) LIST_FOR_EACH_ENTRY( cur, iface-funcs, const func_t,
entry
/widl I'm currently attacking.
Regards,
Michael Karcher
Am Donnerstag, den 01.01.2009, 18:58 + schrieb Rob Shearman:
2009/1/1 Michael Karcher w...@mkarcher.dialup.fu-berlin.de:
+ hr = IPropertyBag_RemoteRead_Proxy(This, pszPropName, outVariant,
pErrorLog,
+ V_VT(pVar), pUnk);
+ if(SUCCEEDED(hr
Am Donnerstag, den 01.01.2009, 18:53 + schrieb Rob Shearman:
2009/1/1 Michael Karcher w...@mkarcher.dialup.fu-berlin.de:
diff --git a/include/oaidl.idl b/include/oaidl.idl
index 1cc166a..4ee3b43 100644
--- a/include/oaidl.idl
+++ b/include/oaidl.idl
@@ -1620,9 +1620,9 @@ interface
Am Donnerstag, den 01.01.2009, 19:09 + schrieb Rob Shearman:
2009/1/1 Michael Karcher w...@mkarcher.dialup.fu-berlin.de:
+[call_as(AddPropertySheetPages)]
+HRESULT RemoteAddPropertySheetPages();
[...]
+[call_as(SendControlMsg)]
+HRESULT RemoteSendControlMsg
Am Donnerstag, den 01.01.2009, 11:22 +0100 schrieb Michael Karcher:
The old behaviour was to emit a half-complete C statement without
any error message.
This patch is bad. Please ignore.
Regards,
Michael Karcher
in the parameter.
Now, that makes sense.
I'm guessing by the
change that you had to make that widl doesn't handle this too well...
Seems so. I don't want to hurt anyone, but I somehow get the impression
that the quality of widl is somewhere around works-for-me.
Regards,
Michael Karcher
Am Freitag, den 26.12.2008, 17:20 + schrieb Rob Shearman:
2008/12/21 Michael Karcher w...@mkarcher.dialup.fu-berlin.de:
This makes widl generate null pointer checks for HWND parameters, as
HXXX is a void pointer without the unique attribute. My question is:
Should widl really add
patching into the testcase (i.e. copy a good tlb,
patch it, and perform some tests with the copy, than delete it)
Which approach would have the highest chance of getting the fix
(including the testcase that tests broken type libraries) included into
Wine?
Regards,
Michael Karcher
checks for handles, or is widl to be fixed instead?
Best regards and thanks for advice,
Michael Karcher
git-add before make_makefiles. If you
don't use git, make_makefiles scans all directories for Makefile.in to
find about buildable directories.
Thank you,
Jörg Höhle
You're welcome,
Michael Karcher
multiplied by the number of
elements. The size of a single element is calculated by
sizeof(foo[anything]), anything being zero by convention.
Regards,
Michael Karcher
1: breaks horribly means in that case: Returns nonsense (if foo[0] is a
structure, usually zero), no compile-time error, no obvious error
,
Michael Karcher
not get other changes
are generally frowned upon and usually reject, so don't feel requested
to fix the tab-n-space mix in the test list as well. Just choose one of
the correct variants, that is 8 spaces or one tab.
Regards,
Michael Karcher
+if(MSSTYLES_GetNextInteger(...)
+MSSTYLES_GetNextInteger(...)
+MSSTYLES_GetNextInteger(...))
+{
Regards,
Michael Karcher
signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil
Am Samstag, den 29.11.2008, 10:52 +0100 schrieb Michael Karcher:
This makes the xmlnode structures kind-of aggregatable COM objects.
The explanation of the new reference management is in the rather verbose
comment at the top of the new node_unk.c file.
For reference, the comment explaining
the version
you are currently working on. If you do a git-commit, git-pull or other
things like that, the target of the alias HEAD is automatically
adjusted.
Regards,
Michael Karcher
, I didn't include the tip but if you want it here it is:
chmod a+x .git/hooks/pre-commit
Great! I didn't know about that. Can we put this somewhere in one of the
Wine development hint pages?
Regards,
Michael Karcher
signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil
of the same line.
Regards,
Michael Karcher
zero. To prevent just this possible mistake, a
patch making the condition obvious was requested.
Regards,
Michael Karcher
Am Dienstag, den 18.11.2008, 08:51 -0800 schrieb Jeremy Drake:
On Tue, 18 Nov 2008, Michael Karcher wrote:
Looks OK to me, but what happened to your finding about
INET_E_RESOURCE_NOT_FOUND? Was it a red herring?
I saw that on XP, but I couldn't reproduce it on Windows 2000. I need
* to do,
but not *how*. Especially for the error case testcases might be
interesting.
Is there anyone out there who
would volunteer to do it if I were to write a description of the
function?
I would do so, if its just some minutes.
Regards,
Michael Karcher
do away with the need to know the
soname during compilation. As it is hardcoded into the executable during
link, hard-coding the soname doesn't hurt that much too, but still it
gets simpler
Regards,
Michael Karcher
to implement it. Thanks for the pointers to MSDN. I didn't know about
the VT_ERROR/DISP_E_PARAMNOTFOUND case yet.
Regards,
Michael Karcher
into the opposite direction. CUPS should provide you
with an PPD file telling you what postscript fragment has to be included
into the job to select the right page size. Also the correct DSC comment
%%PaperSize might help.
Regards,
Michael Karcher
by the vtable
of the IXMLDOMFoo imlementing objects.
Thanks for your input,
Michael Karcher
don't use E_UNEXPECTED instead of the numerical constant?
Regards,
MIchael Karcher
signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil
Am Freitag, den 17.10.2008, 00:46 +0200 schrieb Michael Karcher:
If libxml2 is new enough, it is possible to parse directly from the
stream using xmlReadIO to avoid copying the whole stream contents to
memory.
Testing native, it looks like this is the right approach. Piotr Caban
asked me
(that is most notably x64), full-blown CPU emulation (either
interpreting or a JIT compiler) is used instead. 32 bit protected mode
programs can run natively on x86 and x64, but emulation is also
available as an option in protected mode.
Regards,
Michael Karcher (who already fixed some bugs
and not marked as ways)
julliard: What is wrong with http link here. Copy'n'paste all
responses (recognizable by being from Alexandre or starting with your
nickname) and try to make sense of them later.
Regards,
Michael Karcher
(for example by
'_').
Regards,
Michael Karcher
that
needs a graphics card you don't own), do not send the testcase to
wine-patches, but to wine-devel, and explain briefly why you can't test,
and ask other developers to test it for you. This is usually not a
problem.
Regards,
Michael Karcher
AC_CREATE_STDINT_H
or AX_CREATE_STDINT_H to create wine/stdint.h (which will create a
one-liner including stdint.h on systems where it is available)?
Regards,
Michael Karcher
?
Not necessarily. The problem is that the ATI driver behaves differently
with different stack limits, and the Wine developers have to decide
whether they accept both behaviours as OK.
Regards,
Michael Karcher
statement
might be written as
return (hr == S_OK ? E_FAIL : hr);
Regards,
Michael Karcher
it to be freed when freeing
the orphans and a second time (some lines later) when the document
element is freed.
So, I doubt this patch is correct.
Regards,
Michael Karcher
,
Michael Karcher
.
Thanks in advance for any feedback,
Michael Karcher
diff --git a/dlls/msxml3/domdoc.c b/dlls/msxml3/domdoc.c
index 8ef0db4..969e25e 100644
--- a/dlls/msxml3/domdoc.c
+++ b/dlls/msxml3/domdoc.c
@@ -234,6 +234,29 @@ static inline domdoc *impl_from_IObjectSafety(IObjectSafety *iface)
return
test (as I suggested),
*please* also post the code you used to generate that output.
Regards,
Michael Karcher
should point to the DirectDrawSurface interface, is a NULL value
pointing nowhere instead, which is exactly what we need here.
Regards,
Michael Karcher
Am Dienstag, den 14.10.2008, 13:34 -0700 schrieb chris ahrendt:
Yes if we need to move this off list please let me know
Michael Karcher wrote:
That's why I suggested you to introduce the err2 label. The end of the
function should look like this:
Ya, Ich versteh
Sehr gut.
here
;
| IDirectDrawPalette *palette = NULL;
As they are initialized to NULL, the condition of the if statement is
false if these variables were not yet initialized. So no crash possible
here. Your return statement leaks palette.
Regards,
Michael Karcher
that the testcase should handle that.
Regards,
Michael Karcher
notably, packed 24 bpp true color (D3DFMT_R8G8B8) support
is missing, as most modern cards use 32 bpp true color
(D3DFMT_X8R8G8B8). I would expect NULLREF to fail on a system with
d3dref9.dll available but a 24 bpp framebuffer.
Regards,
Michael Karcher
/412577.aspx
Regards,
Michael Karcher
Am Freitag, den 10.10.2008, 14:26 +0100 schrieb Rob Shearman:
2008/10/8 Michael Karcher [EMAIL PROTECTED]:
In http://www.winehq.org/pipermail/wine-patches/2008-June/056508.html
Peter Urbanec sent a patch I like, that adds timing information to the
log. It has been critized for having
. He did never submit
in that form. I would be happy about any advice.
The indentation-fixed patch is included, although the first two lines
are munged to prevent the patch to get away with the forged
attribution.
Regards,
Michael Karcher
Based-on-From 37a6d97098fa8d4de70b125f6303de5b5fa92357
Am Samstag, den 04.10.2008, 20:44 +0200 schrieb Michael Karcher:
Hello Huw Davies,
it looks like test_removeChild (introduced by you in commit 187ab1c0)
contains a typo.
Ugh. Please disregard the previous mail. The test after fixing the
typo does *not* succeed in WinXP, only in wine
Hello Huw Davies,
it looks like test_removeChild (introduced by you in commit 187ab1c0)
contains a typo. The test passes both ways, but from the code flow I
suspect that node_list2 was obtained for a reason, namely using it.
Regards,
Michael Karcher
This patch fixes the type, if it turn out
[resend, as I used a non-subscribed From: in the first try]
Am Samstag, den 04.10.2008, 20:44 +0200 schrieb Michael Karcher:
Hello Huw Davies,
it looks like test_removeChild (introduced by you in commit 187ab1c0)
contains a typo.
Ugh. Please disregard the previous mail. The test after
Am Samstag, den 04.10.2008, 21:00 +0200 schrieb Michael Karcher:
it looks like test_removeChild (introduced by you in commit 187ab1c0)
contains a typo.
Ugh. Please disregard the previous mail. The test after fixing the
typo does *not* succeed in WinXP, only in wine.
Last followup
:
http://www.winehq.org/pipermail/wine-patches/2008-September/061760.html
In that patch, you are definitely missing the prototype for
MsiSetExternalUIRecord in msi.h. I didn't notice any further problems.
Regards,
Michael Karcher
to everyone: I suppose if the trace above indicates the run
number, these modifications are unneded. Do you agree?
Regards,
Michael Karcher
Am Sonntag, den 21.09.2008, 11:25 +0200 schrieb Alexandre Julliard:
Michael Karcher [EMAIL PROTECTED] writes:
OK. Thanks for the pointer. I have a configure test ready that checks
whether the global -fno-builtin is really needed., and uses separate
flags otherwise. I am planning to submit
Am Sonntag, den 21.09.2008, 13:07 +0200 schrieb Alexandre Julliard:
Michael Karcher [EMAIL PROTECTED] writes:
Sure I can, this was approach b I suggested. But that may be harmful to
performance, as it forbids gcc to use any knowledge about the standard
library (includes inlining of memcpy
Am Sonntag, den 21.09.2008, 13:46 +0200 schrieb Alexandre Julliard:
Michael Karcher [EMAIL PROTECTED] writes:
Am Sonntag, den 21.09.2008, 13:07 +0200 schrieb Alexandre Julliard:
If performance is an issue you most likely don't want to use msvcrt at
all, native Unix libc will always
debug channels (that's
where TRACE messages go to).
Without modifying the test messages, we'll only get
a line number, and no mention of which data caused the test to fail.
You just look some lines upwards to the trace output. It's right next to
the failure message.
Regards,
Michael Karcher
the implementation of glibc's sscanf, and you explicitly have to
forbid it to use this knowledge which does not apply perfectly to
Microsofts sscanf. This (of course) is only applicable to those parts of
wine that link to msvcrt and thus use msvcrt's scanf implementation.
Regards,
Michael Karcher
Am Samstag, den 20.09.2008, 10:50 +0200 schrieb Michael Karcher:
Looks like we need to compile with -fno-builtin-sscanf, because gcc
knows the implementation of glibc's sscanf,
OK, I looked further into it. On Linux, we don't get the warning,
because gcc is called with the sledgehammer option
ready that checks
whether the global -fno-builtin is really needed., and uses separate
flags otherwise. I am planning to submit it in series with a second
patch that checks for whether -fno-builtin-scanf is needed (check for
warning on %P).
Regards,
Michael Karcher
(DependOnGroup) with FALSE, so definitely not a retry.
Peter, are you sure that windows will handle REG_SZ *only* in the
DependOnService case and fail if you have a REG_SZ in DependOnGroup?
Regards,
Michael Karcher
loading behaviour for DependOnService and
DependOnGroup is verified. Just for reference: WinXP SP3 in KVM here.
Regards,
Michael Karcher
are a kind of of Win32 API reference by example. IMHO you
shouldn't include such misleading parameters as the size in the wrong
unit into API usage examples.
Regards,
Michael Karcher
.
In this particular case, I think the crash log does not really indicate
an alignment problem, but a x/i $eip in winedbg on the crash might
help to check further. I suspect a [edx-1] address while edx contains a
NULL pointer.
Regards,
Michael Karcher
signature.asc
Description: Dies ist ein digital
Am Donnerstag, den 11.09.2008, 18:21 +0200 schrieb Martin Profittlich:
In this particular case, I think the crash log does not really indicate
an alignment problem, but a x/i $eip in winedbg on the crash might
help to check further. I suspect a [edx-1] address while edx contains a
NULL
easier. Having MultiByteToWideChar calls
fail in that case seems to make recompilation of most DLLs (that export
A and W functions) with -O0 impossible.
Regards,
Michael Karcher
different places.
Regards,
Michael Karcher
%d:
%d,%d-%d,%d\n,
+width, height, rect.left, rect.top, rect.right, rect.bottom);
These messages contain a copy paste mistake. Please fix the 6x6.
Regards,
Michael Karcher
1 - 100 of 176 matches
Mail list logo
