Re: Re : [4/4] (Try4) msi/tests: Fix package test when run on root drive directory.

2009-04-10 Thread Nicolas Le Cam
2009/4/11 Ben Klein shackl...@gmail.com: 2009/4/11 Nicolas Le Cam niko.le...@gmail.com: 2009/4/11 James Hawkins trui...@gmail.com: Let met explain : Running test on wine in folder C:\test : works (expected C:\test got C:\test) Running test on wine in folder C:\ : works (expected C:\ got C

wininet: Add tests for asynchronous HttpSendRequestEx/HttpEndRequest.

2009-04-10 Thread Nicolas Le Cam
doesn't change anything. After reading a little bit about how this works I don't see anything wrong. Perhaps you will. thanks, Nicolas Le Cam

Re: [urlmon/tests] Fix a test by using a better default registry key

2009-04-06 Thread Nicolas Le Cam
to cope with that, if need be. Should should ? +     */ +    res = RegOpenKeyA(HKEY_CURRENT_USER,             Software\\Microsoft\\Windows\\CurrentVersion\\Internet Settings\\Zones\\3, hkey);     if(res != ERROR_SUCCESS) {         ok(0, Could not open zone key\n); -- Nicolas Le Cam

Re: [2/2] shell32: Define PT_FOLDERW.

2009-04-04 Thread Nicolas Le Cam
2009/4/4 Austin English austinengl...@gmail.com: On Sat, Apr 4, 2009 at 6:59 AM, Nicolas Le Cam niko.le...@gmail.com wrote: Define PT_FOLDERW in pidl.h to complete this series. You're changing the indent of some of the defines. If you're going to change some, change them all to make them

Re: [2/2] shell32: Define PT_FOLDERW.

2009-04-04 Thread Nicolas Le Cam
2009/4/4 Austin English austinengl...@gmail.com: On Sat, Apr 4, 2009 at 11:55 AM, Nicolas Le Cam niko.le...@gmail.com wrote: 2009/4/4 Austin English austinengl...@gmail.com: On Sat, Apr 4, 2009 at 6:59 AM, Nicolas Le Cam niko.le...@gmail.com wrote: Define PT_FOLDERW in pidl.h to complete

Re: shell32/tests: Fix a test on Win2k platform and above.

2009-03-19 Thread Nicolas Le Cam
2009/3/19 Paul Vriens paul.vriens.w...@gmail.com: Nicolas Le Cam wrote: Try2: Follow Vincent Povirk's suggestion of removing calls to SetWindowLongPtr before destroying windows Could someone test this patch on Win9x or WinNT ? On Win2k (and according to test.winehq.org on above platforms

Re: shell32/tests: Fix a test on Win2k platform and above.

2009-03-18 Thread Nicolas Le Cam
2009/3/18 Paul Vriens paul.vriens.w...@gmail.com: Nicolas Le Cam wrote: On Win2k (and according to test.winehq.org on above platforms) an ABN_POSCHANGED message is sent to the last window that is removed. This patch change the ok to a win_skip in this case. Tell me if you have a better

Re: shell32/tests: Fix a test on Win2k platform and above.

2009-03-18 Thread Nicolas Le Cam
2009/3/18 Vincent Povirk madewokherd+8...@gmail.com: On Tue, Mar 17, 2009 at 4:50 PM, Nicolas Le Cam niko.le...@gmail.com wrote: Tell me if you have a better solution. You should add some traces first to find out what window is getting this notification and when. The test data currently

Re: shell32/tests: Fix a test on Win2k platform and above.

2009-03-18 Thread Nicolas Le Cam
2009/3/18 Vincent Povirk madewokherd+8...@gmail.com: On Wed, Mar 18, 2009 at 9:09 AM, Nicolas Le Cam niko.le...@gmail.com wrote: On Win2k after the last SHAppBarMessage(ABM_REMOVE, abd) call, a ABN_POSCHANGED is sent to windows[2].hwnd, but at that time user data has been set to null

Re: shell32/tests: Fix a test on Win2k platform and above.

2009-03-18 Thread Nicolas Le Cam
2009/3/18 Vincent Povirk madewokherd+8...@gmail.com: On Wed, Mar 18, 2009 at 9:39 AM, Nicolas Le Cam niko.le...@gmail.com wrote: I don't think calling SHAppBarMessage with ABM_REMOVE destroy the window and the ABN_POSCHANGED notification is catched between this call and the DestroyWindow one

Re: shell32/tests: Fix a test on Win2k platform and above.

2009-03-18 Thread Nicolas Le Cam
2009/3/18 Vincent Povirk madewokherd+8...@gmail.com: On Wed, Mar 18, 2009 at 11:46 AM, Nicolas Le Cam niko.le...@gmail.com wrote: Message notification comes from appbar3, I've checked hwnd handles. When calling last ABM_REMOVE there's no more appbars so Wine shouldn't send any notifications

Re: shell32/tests: Fix a test on Win2k platform and above.

2009-03-18 Thread Nicolas Le Cam
2009/3/18 Vincent Povirk madewokherd+8...@gmail.com: On Wed, Mar 18, 2009 at 1:34 PM, Nicolas Le Cam niko.le...@gmail.com wrote: Ok, did more testing ... It seems you're right, adding a do_events() call after each DestroyWindow() one seems to fix the test on Win2k. Do you think

Re: [programs/winetest] Extend PATH if we have dll's that only come with .NET (Try2)

2009-02-25 Thread Nicolas Le Cam
logname;  } I did a similar patch yesterday but forget to set PATH around run_ex in get_subtests so it didn't work when I tested on my W2K Pro test platform. Thanks for your work -- Nicolas Le Cam

Re: [programs/winetest] Extend PATH if we have dll's that only come with .NET (Try2)

2009-02-25 Thread Nicolas Le Cam
+ +            /* We have a dll that cannot be found through LoadLibraryExA. This +             * is the case for .NET provided dll's. We will add the directory +             * where the dll resides to the PATH variable when dealing with +             * the tests for this dll. +          

Re: [programs/winetest] Extend PATH if we have dll's that only come with .NET (Try2)

2009-02-25 Thread Nicolas Le Cam
2009/2/25 Paul Vriens paul.vriens.w...@gmail.com: Nicolas Le Cam wrote: + +            /* We have a dll that cannot be found through LoadLibraryExA. This +             * is the case for .NET provided dll's. We will add the directory +             * where the dll resides to the PATH

Re: [programs/winetest] Extend PATH if we have dll's that only come with .NET

2009-02-24 Thread Nicolas Le Cam
); -- 1.6.0.6 What about extending wine_test struct with a path variable that will be set and restored around the CreateProcess call in run_ex if not null ? -- Nicolas Le Cam

Re: [try2] gdiplus/tests: Dynamically load gdiplus.dll.

2009-02-23 Thread Nicolas Le Cam
2009/2/23 Francois Gouget fgou...@free.fr: On Sun, 22 Feb 2009, Nicolas Le Cam wrote: This avoid a messagebox in regression tests on systems that don't have GdiPlus. This seems wrong because winetest.exe is already supposed to check for missing dlls. If I remember correctly this was done

Re: [try2] gdiplus/tests: Dynamically load gdiplus.dll.

2009-02-23 Thread Nicolas Le Cam
2009/2/23 Paul Vriens paul.vriens.w...@gmail.com: Nicolas Le Cam wrote: 2009/2/23 Francois Gouget fgou...@free.fr: On Sun, 22 Feb 2009, Nicolas Le Cam wrote: This avoid a messagebox in regression tests on systems that don't have GdiPlus. This seems wrong because winetest.exe is already

Re: [try2] gdiplus/tests: Dynamically load gdiplus.dll.

2009-02-23 Thread Nicolas Le Cam
2009/2/23 Paul Vriens paul.vriens.w...@gmail.com: Is .NET installed (any version)? -- Cheers, Paul. Can't remember. I will check and report back this evening. Nicolas Le Cam

Re: [try2] gdiplus/tests: Dynamically load gdiplus.dll.

2009-02-23 Thread Nicolas Le Cam
2009/2/23 Paul Vriens paul.vriens.w...@gmail.com: Nicolas Le Cam wrote: 2009/2/23 Paul Vriens paul.vriens.w...@gmail.com: Nicolas Le Cam wrote: 2009/2/23 Francois Gouget fgou...@free.fr: On Sun, 22 Feb 2009, Nicolas Le Cam wrote: This avoid a messagebox in regression tests on systems

Re: fusion/tests: [Patch 1/2] Do not use an hardcoded path for the windows directory

2009-02-21 Thread Nicolas Le Cam
2009/2/21 Detlef Riekenberg wine@web.de: On Do, 2009-02-19 at 16:21 -0800, James Hawkins wrote: On Thu, Feb 19, 2009 at 4:14 PM, Detlef Riekenberg wine@web.de wrote: James: A fixed path is broken by design. A Thanks for spending weeks of your time laboriously testing and implementing

Re: msctf crosstest build failed

2009-02-19 Thread Nicolas Le Cam
2009/2/18 Nikolay Sivov bungleh...@gmail.com: Building today crosstests I've got: i586-mingw32msvc-gcc -c -I. -I. -I../../../include -I../../../include -g -O2 -o inputprocessor.cross.o inputprocessor.c i586-mingw32msvc-gcc -c -I. -I. -I../../../include -I../../../include -g -O2 -o

Re: msctf crosstest build failed

2009-02-19 Thread Nicolas Le Cam
2009/2/19 Nikolay Sivov bungleh...@gmail.com: Nicolas Le Cam wrote: 2009/2/18 Nikolay Sivov bungleh...@gmail.com: Building today crosstests I've got: i586-mingw32msvc-gcc -c -I. -I. -I../../../include -I../../../include -g -O2 -o inputprocessor.cross.o inputprocessor.c i586-mingw32msvc

Re: fusion/tests: Do not use a fixed path to the assembly

2009-02-19 Thread Nicolas Le Cam
2009/2/20 Detlef Riekenberg wine@web.de: James: A fixed path is broken by design. This fix the remaining failure on w2k. The asmcache has more failures on win9x, but a fix for that failures conflict with the patchset from Hans. -- By by ... Detlef Hi Detlef, I've already sent

Re: winspool.drv/tests: Fix a test on all platforms.

2008-11-11 Thread Nicolas Le Cam
2008/11/6 Nicolas Le Cam [EMAIL PROTECTED]: Hi, DeviceCapabilities DC_FIELDS always sets the DM_FORMNAME flag. Mark this test as a todo_wine. Nicolas Le Cam Is there something wrong with this one ? Should I fix wine too ? I didn't because I don't know where to fix it (in winspool.drv

Re: advapi32/tests: Run a test on more platforms (try2)

2008-11-04 Thread Nicolas Le Cam
2008/11/4 Alexandre Julliard [EMAIL PROTECTED]: Nicolas Le Cam [EMAIL PROTECTED] writes: @@ -614,7 +614,9 @@ static void test_enum_provider_types(void) DWORD dwTypeCount; /* actual values */ - DWORD index = 0; + /* the first provider type registry key may not have

Re: advapi32/tests: Run a test on more platforms.

2008-10-27 Thread Nicolas Le Cam
Hi, Should I consider second solution ? Or perhaps adding a comment explaining why we use the second provider type key would be enough ? Original patch is available at [1] for reference. [1] http://www.winehq.org/pipermail/wine-patches/2008-October/063475.html Bye, Nicolas Le Cam 2008/10/20

wine users forum registration issue

2008-10-23 Thread Nicolas Le Cam
2008/10/23 Zachary Goldberg [EMAIL PROTECTED]: Captchas in general are not so good, and there are much better anti-spam techniques out there (Such as asking an actual question. There are phpbb mods which allow you to input a list of questions (with perhaps links to wiki pages with answers)

Re: shlwapi/tests: Make the shlwapi tests load on systems Vista by provid

2008-10-20 Thread Nicolas Le Cam
Sorry for the truncated object, certainly a copy/paste error. It should be: Make the shlwapi tests load on systems Vista by providing a private implementation of RegDeleteTreeW. Regards, Nicolas Le Cam

Re: shlwapi/tests: Make the shlwapi tests load on systems Vista by provid

2008-10-20 Thread Nicolas Le Cam
Hi Paul, I've just seen that. Please ignore my patch. I've followed the same 'trick' that has been used in other tests but I also think Detlef's approach is better. Thanks for your feedback, Nicolas Le Cam 2008/10/20 Paul Vriens [EMAIL PROTECTED]: Nicolas Le Cam wrote: Regards, Nicolas Le

Re: shlwapi/tests: Make the shlwapi tests load on systems Vista by provid

2008-10-20 Thread Nicolas Le Cam
Sorry again, didn't see Detlef has already sent a fix to this one [1]. Please ignore. Regards, Nicolas Le Cam [1] http://www.winehq.org/pipermail/wine-patches/2008-October/063319.html 2008/10/20 Nicolas Le Cam [EMAIL PROTECTED]: Sorry for the truncated object, certainly a copy/paste error

Re: [1/3] netapi32/tests: Add a test for well known account RIDs

2008-10-17 Thread Nicolas Le Cam
Its obvious but don't apply, third patch is missing comment and unused variables cleaning. I will submit a new patch later. regards, Nicolas Le Cam 2008/10/17 Nicolas Le Cam [EMAIL PROTECTED]: Hi, This path series intend to fix a failing test on localized windows version. The first two

Fwd: Testcase - a windows run, please?

2008-09-14 Thread Nicolas Le Cam
(resent as I didn't cc to wine-devel) Tested on win2k sp4 : X:\kernel32_crosstest.exe profile profile: 202 tests executed (0 marked as todo, 0 failures), 0 skipped. 2008/9/14 Erik Inge Bolsø [EMAIL PROTECTED] Could someone run this testcase on native windows for me, please? :)

Re: Recent msi/package tests failures

2008-09-01 Thread Nicolas Le Cam
Same thing here with a 2k box running on VirtualBox. 2008/8/31 Paul Vriens [EMAIL PROTECTED] James Hawkins wrote: On Sat, Aug 30, 2008 at 3:17 PM, Paul Vriens [EMAIL PROTECTED] wrote: Hi, I just sent a few patches that fix the problem with the timeout on my machines. Do you think

Re: kernel32/tests: Fix a failing test in vista

2008-07-21 Thread Nicolas Le Cam
LINGUISTIC_IGNORECASE and other new definitions and try to implement handling of those new flags in CompareString but IMHO it's a different task. 2008/7/21 Dmitry Timoshkov [EMAIL PROTECTED]: Nicolas Le Cam [EMAIL PROTECTED] wrote: Vista introduced new flags for CompareString, as stated in [1

<    1   2