Re: ddraw/tests: New visual back buffer flipping tests. (try 3)

2010-08-26 Thread Oldřich Jedlička
On Wednesday 25 August 2010 12:03:50 Stefan Dösinger wrote: +hr = IDirectDrawSurface_AddAttachedSurface(Primary, Backbuffer); +todo_wine ok(hr == DD_OK || broken(hr == DDERR_CANNOTATTACHSURFACE), + Attaching a back buffer to a front buffer returned %08x\n, hr); The patch

Re: ddraw/tests: New visual back buffer flipping tests. (resend)

2010-08-23 Thread Oldřich Jedlička
On Monday 23 August 2010 23:00:24 Octavian Voicu wrote: 2010/8/23 Oldřich Jedlička oldium@seznam.cz: +// Check it out You have a C++ style comment in this patch and I don't think it's allowed. My mistake, I've mixed up the C and C++ comments. I thought // is the C style

Re: ddraw/tests: New visual back buffer flipping tests. (try 2)

2010-08-23 Thread Oldřich Jedlička
On Tuesday 24 August 2010 00:14:31 Octavian Voicu wrote: 2010/8/24 Oldřich Jedlička oldium@seznam.cz: +ok((GetRValue(color) == 0xFF GetGValue(color) == 0xFF GetBValue(color) == 0xFF) || + broken(GetRValue(color) == 0xFF GetGValue(color) == 0 GetBValue(color) == 0

Re: [PATCH 2/5] ddraw/tests: New visual back buffer flipping tests. (try 5, resend)

2010-08-21 Thread Oldřich Jedlička
] prefix, so don't be confused :-) I will also remove the try 5 and start from the beginning. I will start with this patch, description is unmodified, but the C++ comment is converted to C comment. Oldřich. Am 18.08.2010 um 22:01 schrieb Oldřich Jedlička: --- dlls/ddraw/tests/visual.c | 123

Re: New and subtle ddraw:dsurface test failure

2010-08-09 Thread Oldřich Jedlička
Hi W, On Monday 09 August 2010 12:31:45 wy...@volny.cz wrote: Hi, Do you mean this problem? ddraw:dsurface start ... Nope and nothing about 64bit (there was no change). I was initially talking about changed result from last Friday. To be precise this new information showed up under

Re: New and subtle ddraw:dsurface test failure

2010-08-08 Thread Oldřich Jedlička
Hi W, On Sunday 08 August 2010 11:21:35 wy...@volny.cz wrote: Hi, i just noticed some new and subtle failure in ddraw:dsurface tests. I don't know how closely you watch and study tests results, so i thought it might be a good idea bring it the the light. Sorry if not ;-) Compared WinXP

Re: [PATCH 07/10] ddraw: Allow creating back buffer for DirectX 1 interfaces. (try 3)

2010-08-04 Thread Oldřich Jedlička
On Wednesday 04 August 2010 10:10:17 Stefan Dösinger wrote: Am 03.08.2010 um 21:26 schrieb Oldřich Jedlička: DirectX 1 interface allowed creation of explicit back buffers, so move the restrictive checks to DirectX 2+ implementations. Don't permit creating of primary surface back buffer

Latest version of ddraw/tests plus fixes

2010-08-02 Thread Oldřich Jedlička
Hi Stefan, Roderick, I've sent my latest version of ddraw/tests plus some fixes right now (it takes some time to get to wine-patches ML), one of them fixes bug #9008. Unfortunately I don't have much spare time (and actually I didn't have it the whole time working on patches), my spare time is

Re: [PATCH 04/10] ddraw/tests: New visual back buffer flipping tests. (try 2)

2010-08-02 Thread Oldřich Jedlička
Hi Stefan, On Tuesday 03 August 2010 04:45:57 test...@testbot.winehq.org wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results

Re: [PATCH 3/4] ddraw: Allow creating back buffer for pre-DirectX 7 interfaces. (try 3)

2010-07-29 Thread Oldřich Jedlička
Hi Roderick, On Thursday 22 July 2010 22:26:39 Roderick Colenbrander wrote: On Thu, Jul 22, 2010 at 10:14 PM, Stefan Dösinger stefandoesin...@gmx.at wrote: Am 22.07.2010 um 21:13 schrieb Oldřich Jedlička: DirectX 1 interface allowed creation of explicit back buffers, so move

Re: [PATCH 1/4] ddraw/tests: New CreateSurface for DDSCAPS_BACKBUFFER tests.

2010-07-22 Thread Oldřich Jedlička
Hi Stefan, On Thursday 22 July 2010 22:05:21 Stefan Dösinger wrote: Am 22.07.2010 um 21:13 schrieb Oldřich Jedlička: +hr = IDirectDraw_QueryInterface(lpDD, IID_IDirectDraw, (void **) dd); +ok(SUCCEEDED(hr), IDirectDraw_QueryInterface failed: 0x%08x\n, hr); This is redundant

Re: [PATCH 3/4] ddraw: Allow creating back buffer for pre-DirectX 7 interfaces. (try 3)

2010-07-22 Thread Oldřich Jedlička
Hi Roderick, On Thursday 22 July 2010 22:26:39 Roderick Colenbrander wrote: On Thu, Jul 22, 2010 at 10:14 PM, Stefan Dösinger stefandoesin...@gmx.at wrote: Am 22.07.2010 um 21:13 schrieb Oldřich Jedlička: DirectX 1 interface allowed creation of explicit back buffers, so move

Re: ddraw: Allow creating back buffer for pre-DirectX 7 interfaces. (try 2)

2010-07-21 Thread Oldřich Jedlička
2010 20:51:49 Oldřich Jedlička wrote: Old DirectX interfaces allowed creation of explicit back buffers, so move the restrictive check to DirectX 7 implementation. This fixes bug #9008. --- dlls/ddraw/ddraw.c | 35 --- 1 files changed, 28 insertions(+), 7

Re: ddraw: Allow creating back buffer for pre-DirectX 7 interfaces. (try 2)

2010-07-21 Thread Oldřich Jedlička
of surface descriptor in CreateSurface as the last one. Cheers, Oldrich. Roderick 2010/7/21 Oldřich Jedlička oldium@seznam.cz: Hi all, I've made one discovery - the explicit BACKBUFFER creation (as shown in logs) works only for IID_IDirectDraw interface, not for any newer (on my

Re: ddraw: Allow creating back buffer for pre-DirectX 7 interfaces.

2010-07-20 Thread Oldřich Jedlička
Hi Stefan, On Tuesday 20 July 2010 00:01:13 Stefan Dösinger wrote: Am 19.07.2010 um 21:24 schrieb Oldřich Jedlička: Hi Stefan, On Monday 19 July 2010 20:56:35 Stefan Dösinger wrote: Allowing the creation of the surface is most likely not enough, the backbuffer has to be useable after

Re: ddraw: Allow creating back buffer for pre-DirectX 7 interfaces.

2010-07-20 Thread Oldřich Jedlička
Hi James, On Tuesday 20 July 2010 03:43:39 James McKenzie wrote: Austin English wrote: 2010/7/19 Oldřich Jedlička oldium@seznam.cz: The tests will be a problem, because I don't have the Windows machine as a reference. Also `make test` fails on DirectX tests for me because of r600

Re: ddraw: Allow creating back buffer for pre-DirectX 7 interfaces.

2010-07-20 Thread Oldřich Jedlička
Hi Stefan, On Tuesday 20 July 2010 00:01:13 Stefan Dösinger wrote: Am 19.07.2010 um 21:24 schrieb Oldřich Jedlička: Hi Stefan, On Monday 19 July 2010 20:56:35 Stefan Dösinger wrote: Allowing the creation of the surface is most likely not enough, the backbuffer has to be useable after

Re: ddraw: Allow creating back buffer for pre-DirectX 7 interfaces.

2010-07-19 Thread Oldřich Jedlička
Hi Henri, On Monday 19 July 2010 20:07:08 Henri Verbeet wrote: 2010/7/19 Oldřich Jedlička oldium@seznam.cz: This fixes bug #9008. Please provide a more descriptive log message, and consider writing a test. I'm also pretty sure this will conflict with http://source.winehq.org/patches

Re: ddraw: Allow creating back buffer for pre-DirectX 7 interfaces.

2010-07-19 Thread Oldřich Jedlička
have to admit that I don't know the internals of WineD3D, nor DirectX. Oldrich. Am 19.07.2010 um 19:27 schrieb Oldřich Jedlička: This fixes bug #9008. --- dlls/ddraw/ddraw.c | 25 + dlls/ddraw/ddraw_private.h |3 +++ dlls/ddraw/ddraw_thunks.c

Re: ddraw: Allow creating back buffer for pre-DirectX 7 interfaces.

2010-07-19 Thread Oldřich Jedlička
On Monday 19 July 2010 21:41:26 Henri Verbeet wrote: 2010/7/19 Oldřich Jedlička oldium@seznam.cz: I will enhance the log message, no problem here. Should I consider the referenced patch as being applied (so that I should base my patch on it)? Yeah. Ok, I will update it according