Re: dlls/x11drv/winpos.c::SWP_DoOwnedPopups()

2004-10-20 Thread Peter Riocreux
"Dmitry Timoshkov" <[EMAIL PROTECTED]> writes: > "Peter Riocreux" <[EMAIL PROTECTED]> wrote: > >> > You have to write a test case and add it to existing ones in >> > dlls/user/tests/win.c to confirm that the patch is correct. >> &

Re: dlls/x11drv/winpos.c::SWP_DoOwnedPopups()

2004-10-20 Thread Peter Riocreux
"Dmitry Timoshkov" <[EMAIL PROTECTED]> writes: > You have to write a test case and add it to existing ones in > dlls/user/tests/win.c to confirm that the patch is correct. Is something that creates a tree of windows and then makes a parent invisible and checks the visibility state of the children

Re: dlls/x11drv/winpos.c::SWP_DoOwnedPopups

2004-10-19 Thread Peter Riocreux
Peter Riocreux <[EMAIL PROTECTED]> writes: > I have a lot of WARNs from this function so I thought I would have a > shufty at it to see if it was easy to fix. > > The FIXME above it is written so as to suggest that it is a matter of > mere keystrokes to fix it up, or weeks

dlls/x11drv/winpos.c::SWP_DoOwnedPopups

2004-10-19 Thread Peter Riocreux
I have a lot of WARNs from this function so I thought I would have a shufty at it to see if it was easy to fix. The FIXME above it is written so as to suggest that it is a matter of mere keystrokes to fix it up, or weeks of work, depending on your frame of mind when you read it. Still being a be

Re: [PATCH] DrawDibDraw flag handling

2004-10-14 Thread Peter Riocreux
"Dimitrie O. Paun" <[EMAIL PROTECTED]> writes: > On Thu, Oct 14, 2004 at 05:21:41PM +0200, Andreas Mohr wrote: >> Hi, >> >> On Thu, Oct 14, 2004 at 03:53:41PM +0100, Peter Riocreux wrote: >> > if (!(wFlags & DDF_DONTDRAW) && whdd

Re: [PATCH] DrawDibDraw flag handling

2004-10-14 Thread Peter Riocreux
Andreas Mohr <[EMAIL PROTECTED]> writes: > This is rather non-obvious if handling, I'm surprised that the compiler > doesn't warn about it, or does it? It did, but I was making from the top level and it got lost amongtsh the other messages. > Could you add proper braces there? Fixed up patch be

Re: Rename Wine User Guide to Wine User's Guide?

2004-10-14 Thread Peter Riocreux
Kuba Ober <[EMAIL PROTECTED]> writes: > On niedziela 10 październik 2004 02:04 pm, Marcus Meissner wrote: >> On Sun, Oct 10, 2004 at 08:53:14AM -0400, Dimitrie O. Paun wrote: >> > On Sun, Oct 10, 2004 at 01:10:06AM -0700, Scott Ritchie wrote: >> > > I think for consistency's sake we should rename

[PATCH] DrawDibDraw flag handling

2004-10-14 Thread Peter Riocreux
I got a lot of messages from this function about a particular flag (DDF_BACKGROUNDPAL) not being handled, so I tried to handle it. The MSDN docs are at I am coming to this completely cold, so I

Building DLLs and other Qs

2004-07-23 Thread Peter Riocreux
Before I get onto my questions I would just like to say: This mail is not intended to start a flame war -- It is intended in a spirit of understanding what is the current status. First the quick question - I want to install a built-from-CVS wine on mul

Re: dlls/kernel/console.c::SetConsoleCtrlHandler() cleanup/fixup

2004-04-16 Thread Peter Riocreux
Alexandre Julliard <[EMAIL PROTECTED]> writes: > Peter Riocreux <[EMAIL PROTECTED]> writes: > >> It gives every impression of working for me, but I have only tested it >> with one application. >> >> Suggestions for better extended error codes appreciat

[Peter Riocreux] Re: dlls/kernel/console.c::SetConsoleCtrlHandler() cleanup/fixup

2004-04-16 Thread Peter Riocreux
Sorry, mistyped the wine-patches address before ... --- Begin Message --- "Dimitrie O. Paun" <[EMAIL PROTECTED]> writes: > On April 15, 2004 7:54 pm, Alexandre Julliard wrote: >> Error codes should not be based on suggestions, what you should do is >> write a small test program under Windows to f

Re: dlls/kernel/console.c::SetConsoleCtrlHandler() cleanup/fixup

2004-04-16 Thread Peter Riocreux
"Dimitrie O. Paun" <[EMAIL PROTECTED]> writes: > On April 15, 2004 7:54 pm, Alexandre Julliard wrote: >> Error codes should not be based on suggestions, what you should do is >> write a small test program under Windows to find out the real codes. > > Hopefully, this sort of thing will be easier on

Re: [PATCH] Re: help fixing up SetConsoleCtrlHandler()

2004-04-15 Thread Peter Riocreux
"Dimitrie O. Paun" <[EMAIL PROTECTED]> writes: > On Thu, 15 Apr 2004, Peter Riocreux wrote: > >> I don't know, I just had thought that Wine was attempting to be >> bug-for-bug compatible, and assumed that part of that was honouring >> all the res

Re: [PATCH] Re: help fixing up SetConsoleCtrlHandler()

2004-04-15 Thread Peter Riocreux
"Dimitrie O. Paun" <[EMAIL PROTECTED]> writes: > On April 15, 2004 7:58 am, Peter Riocreux wrote: >> Here is my first cut. >> >> Remember that this is my first patch, so go easy on me with he >> flamethrowers. I know the indenting isn't quite rig

[PATCH] Re: help fixing up SetConsoleCtrlHandler()

2004-04-15 Thread Peter Riocreux
Here is my first cut. Remember that this is my first patch, so go easy on me with he flamethrowers. I know the indenting isn't quite right. Probably easiest to review by comparing old and new rather than looking at old and patch. Comments, especially regarding more appropriate error values to u

help fixing up SetConsoleCtrlHandler()

2004-04-14 Thread Peter Riocreux
Having seen a lot of messages like: - fixme:console:SetConsoleCtrlHandler (0x41a8af,1) - no error checking or testing yet - lately, I thought I would actually see if I could fix it up and remove the FIXME. It is in dlls/kernel/console.c, and the MSDN reference is

Re: exec-shield workaround take 4

2004-04-14 Thread Peter Riocreux
With this latest (version 4) of the patch my app now gives every impression of working fine. It starts, spawns children, and appears to run correctly to completion, including dealing with a license manager on a remote machine. If used interactively, some of the fonts are a bit ropey, but I haven't

Re: exec-shield workaround take 3

2004-04-13 Thread Peter Riocreux
Mike McCormack <[EMAIL PROTECTED]> writes: >> --- >> err:virtual:map_image Image was mapped at 0x11c000: standard load address for a >> Win32 program (0x0040) not available >> err:virtual:map_image Do you have exec-shield or prelink active? >> wine: could not load L"G:

Re: exec-shield workaround take 3

2004-04-13 Thread Peter Riocreux
Mike McCormack <[EMAIL PROTECTED]> writes: > What's the problem with wineconsole? It seems to be behaving as if none of your cunning exec-shield-avoidance code is in there. The error messages certainly seem to indicate this: --- err:virtual:map_image Image was mapped at 0

Re: exec-shield workaround take 3

2004-04-13 Thread Peter Riocreux
Have tested this a little and seems alright (a few offsets versus the CVS as of 10:00 GMT, but applies cleanly). Alas our license for the tool I was testing it with is not currently available, so I can't test it out properly. It does at least load the first binary cleanly though, so that is definit

Re: inheriting exec-shield avoidance

2004-04-08 Thread Peter Riocreux
Mike McCormack <[EMAIL PROTECTED]> writes: > Yeah, I'm aware of the problem with interitance... there might be a > tricky way to fix it by setting WINELOADER to the name of a script > that runs "wld $winebinary"... otherwise wine will need to be modified. If wld knew (hardcoded or from an environ

Re: inheriting exec-shield avoidance

2004-04-08 Thread Peter Riocreux
Mike McCormack <[EMAIL PROTECTED]> writes: > Hi Peter, > > I'm not familiar with the using "setarch i386" to solve the problem... > > I've also been working on the exec-shield problem over the last couple > of days. My solution is similar to Mike Hearn's approach, but faster > and more compact, s

Re: inheriting exec-shield avoidance

2004-04-08 Thread Peter Riocreux
Peter Riocreux <[EMAIL PROTECTED]> writes: > I am intermittently trying to get Wine to play nicely with a big EDA > tool, and it is doing not too badly today with the 20040309 snapshot > on Fedora Core 1. > > The thing that I think is stopping it working is that whatever is d

inheriting exec-shield avoidance

2004-04-08 Thread Peter Riocreux
I am intermittently trying to get Wine to play nicely with a big EDA tool, and it is doing not too badly today with the 20040309 snapshot on Fedora Core 1. The thing that I think is stopping it working is that whatever is done to stack-shield by the prepending "setarch i386" on invocation is not i

Re: Working otu what is happening in a network dependent app

2004-03-15 Thread Peter Riocreux
Mike McCormack <[EMAIL PROTECTED]> writes: > Peter Riocreux wrote: > > Is there a noddy Wine app that will just print out all the > > environment it sees to I can be *absolutely* sure that my app is > > seeing it? > > run "wine wcmd", then type &qu

Working otu what is happening in a network dependent app

2004-03-12 Thread Peter Riocreux
I am trying to see if I can work out why an app that contacts a licensing daemon, doesn't. I am inexperienced at Wine debug stuff, so point me at docs if that is appropriate. 1. The host and port for the daemon are passed through an environment variable. I am *definitely* exporting this. Is th

Re: Named pipes

2004-01-28 Thread Peter Riocreux
Uwe Bonnes <[EMAIL PROTECTED]> writes: > >>>>> "Peter" == Peter Riocreux <[EMAIL PROTECTED]> writes: > > Peter> "Robert Shearman" <[EMAIL PROTECTED]> writes: > >> > warn:heap:HEAP_Validat

Re: Named pipes

2004-01-28 Thread Peter Riocreux
Mike McCormack <[EMAIL PROTECTED]> writes: > Peter Riocreux wrote: > > > fixme:ole:CoRegisterMessageFilter stub > > warn:heap:HEAP_ValidateInUseArena Heap 4022: invalid in-use arena magic for > > 402576a0 > > warn:ole:create_marshalled_proxy Could not ope

Re: Named pipes

2004-01-28 Thread Peter Riocreux
"Robert Shearman" <[EMAIL PROTECTED]> writes: > > warn:heap:HEAP_ValidateInUseArena Heap 4022: invalid in-use > > arena magic for 402576a0 > > Worrying, but your program hasn't crashed so shouldn't be a problem. Well the thing that I *think* should be on the other end of the pipe crashes wit

Named pipes

2004-01-28 Thread Peter Riocreux
[reposted because I posted not from the subscribed address - Doh! Sorry if you see it twice in the end] Using the RH9 RPM from the SF downloads area (wine-20040121-1rh9winehq.i686.rpm) This is my first serious attempt at getting a non-working app working, so if I am giving insufficient, or the wr