Re: urlmon:sec_mgr failure on XP

2011-09-10 Thread Thomas Mullaly
it will be fine (I'll be sending a patch shortly removing it). Thanks for pointing this issue out. -- Thomas Mullaly thomas.mull...@gmail.com

Re: [1/4] urlmon: Use CoTaskMemFree instead of HeapFree for memory allocated with CoTaskMemAlloc

2011-09-05 Thread Thomas Mullaly
CoTaskMemAlloc functions with HeapFree functions. -- Thomas Mullaly thomas.mull...@gmail.com

Re: Use of uninitialized variable in combine_uri()

2010-11-02 Thread Thomas Mullaly
Hi Gerald, On Tue, Nov 2, 2010 at 6:51 PM, Gerald Pfeifer ger...@pfeifer.com wrote: Hi Thomas, the following change of yours  commit bced2e21dbc548ef9d41e3ff11384d7ad964c929  Author: Thomas Mullaly thomas.mull...@gmail.com  Date:   Sat Oct 9 11:02:17 2010 -0400    urlmon: Implemented

Re: [2/7] urlmon/tests: Removed no longer needed todo_wine's

2010-09-09 Thread Thomas Mullaly
removed. So I decided (since removing the todo's just by themselves resulted in a lot of changes) to keep this patch separate from the 5/7 patch. Of course, if it's preferred, I can always merge the changes into patch 5/7 and resubmit this set. -- Thomas Mullaly thomas.mull...@gmail.com

Re: The Test Bot seems to be having issues

2010-08-20 Thread Thomas Mullaly
has been in the running state for 24+ hours already, without any progress being made. -- Thomas Mullaly thomas.mull...@gmail.com

The Test Bot seems to be having issues

2010-08-19 Thread Thomas Mullaly
of the code in the patch ;-) ). Anyways, I'm hoping that somebody in charge of the test bot might be able to fix the traffic jam it's causing. [1] https://testbot.winehq.org/JobDetails.pl?Key=4570 https://testbot.winehq.org/JobDetails.pl?Key=4570 -- Thomas Mullaly thomas.mull...@gmail.com

Re: [3/5] urlmon: Implemented canonicalization for ports in URIs

2010-07-28 Thread Thomas Mullaly
On Wed, Jul 28, 2010 at 8:14 AM, Alexandre Julliard julli...@winehq.orgwrote: Thomas Mullaly thomas.mull...@gmail.com writes: --- dlls/urlmon/uri.c | 88 +++- 1 files changed, 86 insertions(+), 2 deletions(-) It doesn't work here

Re: [6/6] urlmon/tests: Added some more test URIs (resend)

2010-07-28 Thread Thomas Mullaly
to subtle differences between the implementations of CreateUri, since these tests only failed on machines with IE7 installed and passed on the machines with IE8 installed... -- Thomas Mullaly thomas.mull...@gmail.com

Re: urlmon: CreateUri should return E_INVALIDARG for NULL args.

2010-05-13 Thread Thomas Mullaly
a new patch here shortly. -- Thomas Mullaly thomas.mull...@gmail.com

Re: [GSoC] IUri Implementations

2010-04-08 Thread Thomas Mullaly
Hi Jacek, Test should be integrated with Wine tests. See dlls/shlwapi/tests/url.c and dlls/wininet/tests/url.c for an idea of how it should be done. Thank you, shlwapi's url test was very helpful and has given me some good ideas for testing. If you have specific questions, feel free to ask

Re: [GSoC] IUri Implementations

2010-04-07 Thread Thomas Mullaly
In general, the idea looks right, that's how it probably should be implemented. This is an implementation detail through. The bigger and more important problem is URI parsing and canonicalization. That's where most of work needs to be done. In this case tests will be also very important.

[GSoC] IUri Implementations

2010-03-30 Thread Thomas Mullaly
Hi, my name is Thomas Mullaly and I am a undergraduate in the Computer Science department at Kent State University and I would very much like to participate in this years GSoC. I saw under your project ideas page that the IUri API still needs implemented and I thought that this would be a good

Re: [GSoC] IUri Implementations

2010-03-30 Thread Thomas Mullaly
You could use dynamic array for that or a list with a Uri_PROPERTY value as a key for example and a data as an offset and length. Another way is to compute each property offset only when it's requested and store it. An obvious bad case for that is a long uri. So probably one pass property