Re: [PATCH try2] cmd: Added @or_broken@ handling to test templates and use it to fix tests on win2k.

2010-03-18 Thread Yann Droneaud
hq.org/pipermail/wine-devel/2010-March/082234.html The output of echo without any parameters is localized, so it was difficult to test unknown / empty variable alone. As a workaround I've added some prefix, suffix to the pattern. Regards. -- Yann Droneaud

Re: [PATCH] cmd: removed %CD% test.

2010-03-16 Thread Yann Droneaud
Le mardi 16 mars 2010 à 11:25 -0500, Austin English a écrit : > On Tue, Mar 16, 2010 at 4:53 AM, Yann Droneaud wrote: > > %CD% seems not supported on Windows NT 4. > > > > The patch which introduce this test was based on MSDN documentation > > and only tested on

Re: [PATCH] cmd: added some expansion tests. (try 2)

2010-03-16 Thread Yann Droneaud
Le lundi 15 mars 2010 à 19:48 +0100, Paul Vriens a écrit : > On 03/09/2010 01:15 PM, Yann Droneaud wrote: > > diff --git a/programs/cmd/tests/test_builtins.cmd > > b/programs/cmd/tests/test_builtins.cmd > > index ed2b75b..e346ffa 100644 > > --- a/programs/cmd/tests/

Re: [PATCH] configure.ac: use proper quoting throughout the file

2010-03-15 Thread Yann Droneaud
Le lundi 15 mars 2010 à 13:05 +0100, Alexandre Julliard a écrit : > Yann Droneaud writes: > > >> Note: Quoting were not added for WINE macros related to Makefile generation > >> as they broke things: there are some quoting magic in aclocal.m4 not > >> fixed by

Re: [PATCH] configure.ac: use proper quoting throughout the file

2010-03-15 Thread Yann Droneaud
Hi, Le lundi 15 mars 2010 à 11:13 +0100, Yann Droneaud a écrit : > Added quoting around macro parameters as recommanded by autoconf: > http://www.gnu.org/software/autoconf/manual/html_node/Autoconf-Language.html#Autoconf-Language > > Autoconf output was checked to be the same with

Re: [PATCH] cmd: added some expansion tests.

2010-03-09 Thread Yann Droneaud
Le lundi 08 mars 2010 à 16:53 -0500, Yann Droneaud a écrit : > Test automatic variables like %CD% %ERRORLEVEL%. > Test expansion of an unknown variable. > +echo %UNKNOWN% > +Echo is OFF My test won't work on any other system : "echo is off" is localized, in French it i

re: cmd: added some expansion tests.

2010-03-09 Thread Yann Droneaud
Le lundi 08 mars 2010 à 20:58 -0800, Dan Kegel a écrit : > > + at pwd@ > > Shouldn't that be "@pwd@" ? You're reading the mailing list archive, which clobber @ :) Regards -- Yann Droneaud

Re: Bad usage of ok() macro in tests

2010-02-24 Thread Yann Droneaud
Le mercredi 24 février 2010 à 15:47 +0100, Yann Droneaud a écrit : > Hi, > > While trying to manage to fix warning about unused values, I've found a > problem about some usages of ok() macro. > > ok() macros is defined in include/wine/test.h as: > &

Bad usage of ok() macro in tests

2010-02-24 Thread Yann Droneaud
ell32/tests/autocomplete.c:if(!ok(hMainWnd != NULL, "Failed to create parent window. Tests aborted.\n")) There's only 3 case with a real problem. The fourth is something very strange: the !ok() in ./dlls/kernel32/tests/file.c seems to be a typo, or someone wanted to disable the test. Regards. -- Yann Droneaud

Re: [PATCH 0/3] Use "__asm__" keyword instead of "asm"

2009-10-27 Thread Yann Droneaud
Le lundi 26 octobre 2009 à 15:33 +0100, Yann Droneaud a écrit : > When using GCC in ansi/c99 mode, "asm" is not defined, one have > to use "__asm__" instead. > "__asm__" is already used in wine source code except in some > files. > I'm now thin

Re: [PATCH 2/2] wined3d: improved ATI Radeon HD 4xxx detection

2009-06-17 Thread Yann Droneaud
oint was to match card and sort them by "power" instead of family. But it seems not doable since OpenGL renderer string like "ATI Radeon HD 4800 Series" is not useful to distinguish between HD4890 and HD4850 :( Regards. -- Yann Droneaud

Re: [PATCH] wininet: moved cookie loading from HttpOpenRequest() to HttpSendRequest()

2008-07-03 Thread Yann Droneaud
> On Wednesday 02 July 2008 19:27:43 Yann Droneaud wrote: > >> This patch does the following: >> >> - Move cookie retrieval code to HTTP_HttpSendRequest() >> - Don't allocate memory for url if INTERNET_FLAG_NO_COOKIES is enabled >> - Be sure to not o