Re: [PATCH 1/5] wined3d: Store valid locations in the resource.

2013-10-03 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-10-03 16:05, schrieb Henri Verbeet: I don't think this patch makes sense before you actually unify the location management. In particular, after this patch you'd have location management in resources that really only does anything for

Re: winemac: Reapply display modes when switching back to app after escaping with Command-Tab.

2013-10-02 Thread Ken Thomases
On Oct 1, 2013, at 11:24 PM, Ken Thomases wrote: May fix bug http://bugs.winehq.org/show_bug.cgi?id=34475. Should fix bug http://bugs.winehq.org/show_bug.cgi?id=34209, too. -Ken

Re: kernel32: Add tests for job objects (try 3)

2013-10-02 Thread Nikolay Sivov
On 10/2/2013 12:58, Andrew Cook wrote: +if(!pCreateJobObjectW) { +win_skip(No job object support\n); +return; +} Once you checked that I suppose you don't need to check for pIsProcessInJob being null, or it still could happen? +if (option strcmp(option, wait) ==

Re: [5/5] gdi32: Don't modify output glyph metrics unless the function succeeds. (resend)

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2426 Your paranoid

Re: Assorted spelling fixes.

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2429 Your paranoid

Re: Assorted spelling fixes.

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2431 Your paranoid

Re: Re: kernel32/tests: Fix the test_waittxempty() timeout.

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2434 Your paranoid

Re: Assorted spelling fixes.

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2430 Your paranoid

Re: Assorted spelling fixes.

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2433 Your paranoid

Re: Assorted spelling fixes.

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2432 Your paranoid

I'm not sure why it was rejected

2013-10-02 Thread Akira Nakagawa
I cannnot make sure my patch 99266 was rejected.

Re: I'm not sure why it was rejected

2013-10-02 Thread Bruno Jesus
On Wed, Oct 2, 2013 at 12:17 PM, Akira Nakagawa matyapir...@gmail.com wrote: I cannnot make sure my patch 99266 was rejected. I can't really tell why it was rejected but I can tell there are mixed space/tabs in the SetLastError lines. I guess if you SetLastError to not implemented you cannot

Re: I'm not sure why it was rejected

2013-10-02 Thread Marcus Meissner
On Wed, Oct 02, 2013 at 12:26:51PM -0300, Bruno Jesus wrote: On Wed, Oct 2, 2013 at 12:17 PM, Akira Nakagawa matyapir...@gmail.com wrote: I cannnot make sure my patch 99266 was rejected. I can't really tell why it was rejected but I can tell there are mixed space/tabs in the SetLastError

Re: [PATCH 4/7] msvcr90/tests: Use the W form of CreateEvent().

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2457 Your paranoid

Re: [PATCH 2/7] qedit/tests: Use the W version of FindResource().

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2455 Your paranoid

Re: I'm not sure why it was rejected

2013-10-02 Thread Vincent Povirk
I guess if you SetLastError to not implemented you cannot return S_OK too It doesn't make sense to use SetLastError at all for functions returning HRESULT.

Re: [2/2] gdi32: Don't modify output glyph metrics unless the function succeeds. (resend)

2013-10-02 Thread Alexandre Julliard
Akihiro Sagawa sagawa@gmail.com writes: --- dlls/gdi32/freetype.c | 12 dlls/gdi32/tests/font.c |5 + 2 files changed, 13 insertions(+), 4 deletions(-) It looks like something is not quite right, this is causing strange spacing, for instance in the About dialog.

Re: [1/2] gdi32: Fix the B spacing value of empty glyph. (try 3)

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2605 Your paranoid

Re: [2/5] ws2_32: Always clear res on error in getaddrinfo/GetAddrInfoW.

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2607 Your paranoid

Re: [3/5] ws2_32: Add some tests for getpeername.

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2608 Your paranoid

Re: [4/5] ws2_32: Return an error from accept if the address buffer is too small.

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2609 Your paranoid

Re: [5/5] ws2_32: Always return the source address from WSAAccept.

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2610 Your paranoid

Looking for an icon for the Mac driver: generic program running under Wine

2013-10-02 Thread Ken Thomases
Hi, I have a need for a new icon in Wine and I'm hoping somebody with some graphics-design skills might be able to create it. The Mac driver attempts to extract an icon from the executable to use for the Dock icon of its process. This is also the icon that appears in the Command-Tab

Re: server: Set the unix file write mode bit also for FILE_APPEND_DATA access.

2013-10-02 Thread Dmitry Timoshkov
Dmitry Timoshkov dmi...@baikal.ru wrote: diff --git a/server/file.c b/server/file.c index 2ecf97c..94d3060 100644 --- a/server/file.c +++ b/server/file.c @@ -459,7 +459,7 @@ static mode_t file_access_to_mode( unsigned int access ) access = generic_file_map_access( access ); if

Re: rpcss: Convert to a service

2013-10-02 Thread Andrew Cook
Ignore this, for some reason this randomly forks a huge number of rpcss instances, and decided to not do so while i was testing it On 03/10/13 14:00, Andrew Cook wrote: --- dlls/rpcrt4/rpc_epmap.c | 40 --- programs/rpcss/Makefile.in | 2 +- programs/rpcss/rpcss_main.c

Re: ws2_32: Implement WSASendMsg() (try 3)

2013-10-01 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2414 Your paranoid

Re: [4/5] ntdll: Make asynchronous NtWriteFile on a disk file always return STATUS_PENDING.

2013-10-01 Thread Alexandre Julliard
Dmitry Timoshkov dmi...@baikal.ru writes: Alexandre Julliard julli...@winehq.org wrote: I don't see the point. Do you actually have an app that depends on this? When I started to work on this I had an app that has one of the reasons to require running under Vista+ was the difference in

oledb32: Implement IDataSourceLocator get/put hWnd (try 4)

2013-10-01 Thread Alistair Leslie-Hughes
Hi, Corrected warnings. Changelog: Implement IDataSourceLocator get/put hWnd Best Regards Alistair Leslie-Hughes From 13b8466033f24db028bfed6de609c4cd5f84b14a Mon Sep 17 00:00:00 2001 From: Alistair Leslie-Hughes leslie_alist...@hotmail.com Date: Mon, 30 Sep 2013 14:05:01 +1000 Subject:

mscoree: Implement CreateInterface

2013-10-01 Thread Alistair Leslie-Hughes
Hi, Changelog: mscoree: Implement CreateInterface Best Regards Alistair Leslie-Hughes From 6e4b9aff1f2a8776be0ad3cf6e9d0404dd5bec29 Mon Sep 17 00:00:00 2001 From: Alistair Leslie-Hughes leslie_alist...@hotmail.com Date: Tue, 1 Oct 2013 10:17:50 +1000 Subject: [PATCH 2/2] Implement

Re: Fix text rotation problem in GM_ADVANCED graphics mode caused by incorrect implementation of GetTextExtentPointW().

2013-10-01 Thread Alexandre Julliard
Ralf Habacker ralf.habac...@freenet.de writes: With other patches i have been told to implement such stuff in the dib driver. Unfortunally this do not works in this case, because in the top level function it looks like having driver specific stuff using display coordinates. It would still

Re: ntdll: Fix the version reported for 64-bit Windows XP.

2013-10-01 Thread Alexandre Julliard
Hans Leidekker h...@codeweavers.com writes: @@ -129,11 +129,19 @@ static const RTL_OSVERSIONINFOEXW VersionData[NB_WINDOWS_VERSIONS] = 4, 0, 0, VER_NT_WORKSTATION, 30 /* FIXME: Great, a reserved field with a value! */ }, /* WINXP */ +#ifdef _WIN64 +{ +

Re: [4/5] ntdll: Make asynchronous NtWriteFile on a disk file always return STATUS_PENDING.

2013-10-01 Thread Dmitry Timoshkov
Alexandre Julliard julli...@winehq.org wrote: I don't see the point. Do you actually have an app that depends on this? When I started to work on this I had an app that has one of the reasons to require running under Vista+ was the difference in overlapped IO behavior. On the other hand

Re: [4/5] ntdll: Make asynchronous NtWriteFile on a disk file always return STATUS_PENDING.

2013-10-01 Thread Alexandre Julliard
Dmitry Timoshkov dmi...@baikal.ru writes: Do you propose to leave NtWriteFile/NtReadFile in the state when they return STATUS_SUCCESS for overlapped writes and reads? But that's clearly not how Windows implements this accordingto the tests, and that would require changing all the tests to

Re: Fix text rotation problem in GM_ADVANCED graphics mode caused by incorrect implementation of GetTextExtentPointW().

2013-10-01 Thread Alexandre Julliard
Ralf Habacker r...@habacker.de writes: On 01.10.2013 12:12, Alexandre Julliard wrote: Ralf Habacker ralf.habac...@freenet.de writes: With other patches i have been told to implement such stuff in the dib driver. Unfortunally this do not works in this case, because in the top level function

Re: [4/5] ntdll: Make asynchronous NtWriteFile on a disk file always return STATUS_PENDING.

2013-10-01 Thread Dmitry Timoshkov
Alexandre Julliard julli...@winehq.org wrote: Do you propose to leave NtWriteFile/NtReadFile in the state when they return STATUS_SUCCESS for overlapped writes and reads? But that's clearly not how Windows implements this accordingto the tests, and that would require changing all the

Re: [PATCH 2/5] wined3d: Move location management into the resource.

2013-10-01 Thread Henri Verbeet
Please split this.

Re: [3/3] ws2_32: Always return the source address from WSAAccept.

2013-10-01 Thread Bruno Jesus
On Tue, Oct 1, 2013 at 6:37 AM, Hans Leidekker h...@codeweavers.com wrote: --- dlls/ws2_32/socket.c | 9 + dlls/ws2_32/tests/sock.c | 6 +++--- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c index c34de4b..6855298

Re: [3/3] ws2_32: Always return the source address from WSAAccept.

2013-10-01 Thread Hans Leidekker
On Tue, 2013-10-01 at 09:32 -0300, Bruno Jesus wrote: On Tue, Oct 1, 2013 at 6:37 AM, Hans Leidekker h...@codeweavers.com wrote: --- dlls/ws2_32/socket.c | 9 + dlls/ws2_32/tests/sock.c | 6 +++--- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git

Re: [1/3] ws2_32: Always clear res on error in getaddrinfo/GetAddrInfoW.

2013-10-01 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2419 Your paranoid

Re: [PATCH] dsound: fixup IDirectSoundCaptureBuffer_QueryInterface

2013-10-01 Thread Andrew Eikum
Seems reasonable, but could you put together some tests to show this? Andrew On Sat, Sep 28, 2013 at 10:41:15AM +0200, Maarten Lankhorst wrote: diff --git a/dlls/dsound/capture.c b/dlls/dsound/capture.c index 40f1702..0fe300c 100644 --- a/dlls/dsound/capture.c +++ b/dlls/dsound/capture.c @@

Re: [2/3] ws2_32: Return an error from accept if the address buffer is too small.

2013-10-01 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2420 Your paranoid

Re: kernel32/tests: Fix the test_waittxempty() timeout.

2013-10-01 Thread Francois Gouget
On Tue, 1 Oct 2013, Francois Gouget wrote: [...] The timeout was too short and would only work for UARTs that have a FIFO and where the trigger level was set just right. With this patch we calculate how much time sending the test data will actually take and tack on a small margin to take

Re: [3/3] ws2_32: Always return the source address from WSAAccept.

2013-10-01 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2421 Your paranoid

Re: [4/5] gdi32: Fix the B spacing value of empty glyph. (try 2)

2013-10-01 Thread Alexandre Julliard
Akihiro Sagawa sagawa@gmail.com writes: Try 2: - Get rid of redundant trace message in the last patch. --- dlls/gdi32/freetype.c |2 +- dlls/gdi32/tests/font.c |8 +++- 2 files changed, 8 insertions(+), 2 deletions(-) This is causing failures here:

Re: mscoree: Implement CreateInterface

2013-10-01 Thread Vincent Povirk
Any reason not to share code with CLRCreateInstance?

Re: imm32: ImmGetCandidateWindow should not return unset data

2013-10-01 Thread Alexandre Julliard
Aric Stewart a...@codeweavers.com writes: @@ -663,6 +663,8 @@ HIMC WINAPI ImmCreateContext(void) gl-dwSize = sizeof(GUIDELINE); ImmUnlockIMCC(new_context-IMC.hGuideLine); +memset(new_context-IMC.cfCandForm, -1, sizeof(new_context-IMC.cfCandForm)); + That's ugly. If you

Re: imm32: ImmGetCandidateWindow should not return unset data

2013-10-01 Thread Aric Stewart
Ok, fixed and resent -aric On 10/1/13 2:13 PM, Alexandre Julliard wrote: Aric Stewart a...@codeweavers.com writes: @@ -663,6 +663,8 @@ HIMC WINAPI ImmCreateContext(void) gl-dwSize = sizeof(GUIDELINE); ImmUnlockIMCC(new_context-IMC.hGuideLine); +

Re: mshtml: Added support for 'document' and 'window' script for attribute values.

2013-10-01 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2427 Your paranoid

Re: Fix text rotation problem in GM_ADVANCED graphics mode caused by incorrect implementation of GetTextExtentPointW().

2013-10-01 Thread Ralf Habacker
On 01.10.2013 12:12, Alexandre Julliard wrote: Ralf Habacker ralf.habac...@freenet.de writes: With other patches i have been told to implement such stuff in the dib driver. Unfortunally this do not works in this case, because in the top level function it looks like having driver specific

Re: Fix text rotation problem in GM_ADVANCED graphics mode caused by incorrect implementation of GetTextExtentPointW().

2013-10-01 Thread Ralf Habacker
On 01.10.2013 12:40, Alexandre Julliard wrote: Ralf Habacker r...@habacker.de writes: On 01.10.2013 12:12, Alexandre Julliard wrote: Ralf Habacker ralf.habac...@freenet.de writes: With other patches i have been told to implement such stuff in the dib driver. Unfortunally this do not works

Re: kernel32/time: Implement GetSystemTimes for linux.

2013-09-30 Thread Bernard Ladenthin
Am 29.09.2013 20:08, schrieb André Hentschel: Am 28.09.2013 21:51, schrieb Bernard Ladenthin: --- dlls/kernel32/time.c | 149 ++ 1 file changed, 149 insertions(+) Hi, please don't use C++ comments, also the rest of the coding style isn't

Re: [2/3] kernel32/tests: test CopyFileEx callback and cancellation (resend)

2013-09-30 Thread Daniel Jeliński
2013/9/30 Nikolay Sivov bungleh...@gmail.com On 9/30/2013 00:51, Daniel Jeliński wrote: +struct progress_list { +const DWORD progress_retval_init; /* value to return from progress routine */ +const BOOL cancel_init;/* value to set Cancel flag to */ +const DWORD

Re: mmdevapi/tests: test MMDevPropStore_GetAt

2013-09-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2403 Your paranoid

Re: [3/3] ws2_32: Implement WSASendMsg() (try 2)

2013-09-30 Thread Alexandre Julliard
Bruno Jesus 00cp...@gmail.com writes: @@ -2427,6 +2427,46 @@ static void WINAPI WS2_GetAcceptExSockaddrs(PVOID buffer, DWORD data_size, DWORD } /*** + * WSASendMsg + */ +int WINAPI WSASendMsg( SOCKET s, LPWSAMSG

Re: [PATCH 1/2] setupapi: Also look in datadir/fakedlls for the re-compiled fakedlls.

2013-09-30 Thread Alexandre Julliard
Huw Davies h...@codeweavers.com writes: --- dlls/setupapi/fakedll.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) I don't think that's correct. The datadir is for platform-independent files, but the fakedlls are platform specific. -- Alexandre Julliard

Re: atl90: Add new DLL

2013-09-30 Thread Zhenbo Li
2013/9/4 Zhenbo Li litime...@gmail.com: This patch could fix bug 34431, which is caused by missing atl90.dll --- configure | 1 + configure.ac | 1 + dlls/atl90/Makefile.in | 7 dlls/atl90/atl90.c | 93 ++

Increasing max_req_size and subsequent errors

2013-09-30 Thread Hugh McMaster
I need to increase the $max_req_size in tools/make_requests. A new request structure for GetConsoleScreenBufferInfoEx is 80 bytes and primarily made up of 16 unsigned long integers. This is fine, but raises the error: wineserver: request.c:755: open_master_socket: Assertion `sizeof(union

Re: [2/3] kernel32/tests: test CopyFileEx callback and cancellation (resend)

2013-09-30 Thread Juan Lang
On Sun, Sep 29, 2013 at 11:10 PM, Daniel Jeliński djelins...@gmail.comwrote: 2013/9/30 Nikolay Sivov bungleh...@gmail.com On 9/30/2013 00:51, Daniel Jeliński wrote: +struct progress_list { +const DWORD progress_retval_init; /* value to return from progress routine */ +const

Re: [2/3] kernel32/tests: test CopyFileEx callback and cancellation (resend)

2013-09-30 Thread Nikolay Sivov
On 9/30/2013 10:10, Daniel Jeliński wrote: 2013/9/30 Nikolay Sivov bungleh...@gmail.com mailto:bungleh...@gmail.com On 9/30/2013 00:51, Daniel Jeliński wrote: +struct progress_list { +const DWORD progress_retval_init; /* value to return from progress routine

Re: [3/3] ws2_32: Implement WSASendMsg() (try 2)

2013-09-30 Thread Bruno Jesus
On Mon, Sep 30, 2013 at 6:32 AM, Alexandre Julliard julli...@winehq.org wrote: Bruno Jesus 00cp...@gmail.com writes: @@ -2427,6 +2427,46 @@ static void WINAPI WS2_GetAcceptExSockaddrs(PVOID buffer, DWORD data_size, DWORD }

Re: [4/5] ntdll: Make asynchronous NtWriteFile on a disk file always return STATUS_PENDING.

2013-09-30 Thread Alexandre Julliard
Dmitry Timoshkov dmi...@baikal.ru writes: --- dlls/ntdll/file.c | 3 ++- dlls/ntdll/tests/file.c | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-) I don't see the point. Do you actually have an app that depends on this? -- Alexandre Julliard julli...@winehq.org

Re: wldap32: Use BOOL type where appropriate

2013-09-30 Thread Rico Schüller
On 01.10.2013 00:06, Frédéric Delanoy wrote: --- dlls/wldap32/init.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/wldap32/init.c b/dlls/wldap32/init.c index b5aed58..54b5b24 100644 --- a/dlls/wldap32/init.c +++ b/dlls/wldap32/init.c @@ -113,13 +113,13 @@ oom:

Re: [1/3] gdi32: Return fake BBox when requested empty glyph metrics. (try 3)

2013-09-30 Thread Bruno Jesus
On Fri, Sep 27, 2013 at 8:16 AM, Akihiro Sagawa sagawa@gmail.com wrote: Fixes bug 18440, 20847. Try 3: - Rebase to recent source. - Separate ABC metrics change. - Use conditional operator. --- dlls/gdi32/freetype.c |4 ++-- dlls/gdi32/tests/font.c | 24

Re: [4/5] ntdll: Make asynchronous NtWriteFile on a disk file always return STATUS_PENDING.

2013-09-30 Thread Dmitry Timoshkov
Alexandre Julliard julli...@winehq.org wrote: I don't see the point. Do you actually have an app that depends on this? When I started to work on this I had an app that has one of the reasons to require running under Vista+ was the difference in overlapped IO behavior. On the other hand the

RE: Increasing max_req_size and subsequent errors

2013-09-30 Thread Hugh McMaster
Solved. server/protocol.def is the correct place to adjust the request_max_size value.

Re: [2/3] kernel32/tests: test CopyFileEx callback and cancellation (resend)

2013-09-29 Thread Nikolay Sivov
On 9/30/2013 00:51, Daniel Jeliński wrote: +struct progress_list { +const DWORD progress_retval_init; /* value to return from progress routine */ +const BOOL cancel_init;/* value to set Cancel flag to */ +const DWORD progress_retval_end; /* value to return from

Re: [1/2] ws2_32/tests: Fix an ok() call comment

2013-09-28 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2387 Your paranoid

Re: add ualapi directory (try 11)

2013-09-28 Thread Marcus Meissner
On Sat, Sep 28, 2013 at 11:58:33AM +0900, Akira Nakagawa wrote: From 2ecc71fdb3406d3cf79ebcbd7f6d0c711b68d699 Mon Sep 17 00:00:00 2001 Message-Id: 2ecc71fdb3406d3cf79ebcbd7f6d0c711b68d699.1379923234.git.matyapir...@gmail.com From: Akira Nakagawa matyapir...@gmail.com Date: Mon, 23 Sep

Re: [2/2] ws2_32: Implement WSASendMsg()

2013-09-28 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2388 Your paranoid

Re: add ualapi directory (try 12)

2013-09-28 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2391 Your paranoid

Re: add ualapi directory (try 11)

2013-09-28 Thread Henri Verbeet
On 28 September 2013 09:35, Marcus Meissner mar...@jet.franken.de wrote: rest looks ok, but you really only should submit: I don't think it does, it still has e.g. the modified copyright headers I pointed out when this was still at try 1.

Re: [website] templates: More protocol relative urls

2013-09-28 Thread Jactry Zeng
Hi André, This patch seem let some urls in non-english version broken. Such as some urls in this page in Chinese: http://www.winehq.org/site/forums -[a href=http://www.winehq.org/mailman/listinfo/wine-announce (取消)订阅/a] -[a href=http://www.winehq.org/pipermail/wine-announce/;存档 1/a] +

Re: [1/3] ws2_32/tests: Fix an ok() call comment

2013-09-28 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2392 Your paranoid

Re: [3/3] ws2_32: Implement WSASendMsg() (try 2)

2013-09-28 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2393 Your paranoid

Re: add ualapi directory (try 12)

2013-09-28 Thread Bruno Jesus
I still don't understand why the copyright is different for the .c and .h file. In one file you add your first name only and in the other your full name. Regards, Bruno On Sat, Sep 28, 2013 at 4:14 AM, Akira Nakagawa matyapir...@gmail.com wrote: -- universe* god::bigbang (void); //and

Re: [2/3] gdi32: Return fake BBox when requested empty glyph metrics. (try 2)

2013-09-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2351 Your paranoid

Re: ntdll: Make asynchronous WaitCommEvent report correct number of bytes returned.

2013-09-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2356 Your paranoid

Re: [PATCH 1/3] riched20: Use codepage in ME_ToUnicode. (try 5)

2013-09-27 Thread Jactry Zeng
Hi all, I see this patch is in 'pending' now, are there anything needs to be improved? Please give me some advice. Thank you. -- Regards, Jactry Zeng

Re: [PATCH 1/2] advapi32: HKCR merge: foundation

2013-09-27 Thread Alexandre Julliard
George Stephanos gaf.stepha...@gmail.com writes: @@ -224,13 +248,138 @@ static NTSTATUS open_key( HKEY *retkey, ACCESS_MASK access, OBJECT_ATTRIBUTES *a } +static LSTATUS create_hkcr_struct( HKEY *hkey, opened_hkcr_t **hkcr ) +{ +UINT_PTR handle = nb_hkcr_handles, i; +

Re: [PATCH 1/5] wined3d: Send present operations through a command stream.

2013-09-27 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-27 00:15, schrieb Henri Verbeet: -swapchain-swapchain_ops-swapchain_present(swapchain, src_rect, dst_rect, dirty_region, flags); + wined3d_cs_emit_present(swapchain-device-cs, swapchain, src_rect, +dst_rect,

Re: [PATCH 1/5] wined3d: Send present operations through a command stream.

2013-09-27 Thread Henri Verbeet
On 27 September 2013 13:05, Stefan Dösinger stefandoesin...@gmail.com wrote: I think we should place comments like This function is called through the command stream for all functions that are called through the CS, similar to what we do for context activation. Perhaps, I'm not sure. For that

Re: [1/3] gdi32: Return fake BBox when requested empty glyph metrics. (try 3)

2013-09-27 Thread Alexandre Julliard
Akihiro Sagawa sagawa@gmail.com writes: Fixes bug 18440, 20847. Try 3: - Rebase to recent source. - Separate ABC metrics change. - Use conditional operator. It breaks the tests: ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so dib.c touch

Re: [PATCH 1/5] wined3d: Send present operations through a command stream.

2013-09-27 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-27 14:19, schrieb Henri Verbeet: Perhaps, I'm not sure. For that kind of comment to be useful it should have a clear set of implications, and I'm not sure it has that until we work out the details of the multi-threaded implementation.

Re: [PATCH 1/5] wined3d: Send present operations through a command stream.

2013-09-27 Thread Henri Verbeet
On 27 September 2013 15:23, Stefan Dösinger stefandoesin...@gmail.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-27 14:19, schrieb Henri Verbeet: Perhaps, I'm not sure. For that kind of comment to be useful it should have a clear set of implications, and I'm not sure it

Re: add ualapi directory (try 10)

2013-09-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2370 Your paranoid

Re: [PATCH 1/2] appwiz.cpl: Use the same dialog template for Mono and Gecko downloader.

2013-09-27 Thread Vincent Povirk
Isn't this going to make the caption Wine Gecko Installer in both cases?

Re: [PATCH 2/2] mshtml: Added IHTMLFormElement::sumit tests.

2013-09-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2374 Your paranoid

Re: (try 6)[3/5] imm32: use thread data from target HWND

2013-09-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2375 Your paranoid

Re: (try 6)[4/5] imm32: Restrict crossthread Association and destruction

2013-09-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2376 Your paranoid

Re: (try 6)[5/5] imm32: limit cross thread access to ImmSet* functions

2013-09-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2377 Your paranoid

Re: [2/2] ws2_32: Implement WSASendMsg()

2013-09-27 Thread Bruno Jesus
On Sat, Sep 28, 2013 at 1:50 AM, Bruno Jesus 00cp...@gmail.com wrote: Fixes bug 34005. There is a problem with this patch, I'm working on an updated version. Sorry, Bruno

Re: add ualapi directory (try 11)

2013-09-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2386 Your paranoid

Re: ntdll: Perform the offset checks also for a serial device.

2013-09-26 Thread Francois Gouget
On Thu, 26 Sep 2013, Dmitry Timoshkov wrote: [...] Obviously you need nothing to know about the test except that it works with a COM-port, so the only thing you'd need to investigate is the difference between VMs in COM-port setup, There's none. All the VMs, wxppro, w7u, w7pro64, etc have the

Re: [2/2] oledb32: Implement IDataSourceLocator get/put hWnd (try 2)

2013-09-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2338 Your paranoid

Re: ntdll: Perform the offset checks in NtWriteFile also for a serial device.

2013-09-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2339 Your paranoid

Re: dlls: Replace the remaining CONSTs.

2013-09-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2341 Your paranoid

Re: dlls: Replace the remaining CONSTs.

2013-09-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2343 Your paranoid

Re: dlls: Replace the remaining CONSTs.

2013-09-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2344 Your paranoid

Re: kernel32/tests: Add DuplicateHandle test to the file access tests.

2013-09-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2345 Your paranoid

Re: dlls: Replace the remaining CONSTs.

2013-09-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2340 Your paranoid

<    1   2   3   4   5   6   7   8   9   10   >