Re: (resend) Scroll window fix

2007-03-03 Thread Peter Oberndorfer
On Tuesday 13 February 2007 14:38, Aric Stewart wrote: > finds the case where the scrolling amount exceeds the window but still > falls within the clipping rect. This generates an additional update > region that needs to be invalidated. > includes a test > Hi, I think your patch has a problem. I

Re: (resend) Scroll window fix

2007-03-03 Thread Aric Stewart
I think you misunderstand. I wrote extensive tests _on windows_ that I used for this patch which where independent on the existing test in wine as i could not get the wine test to work properly in window, most likely, do to a lack of understand on the testing framework. After i made the patch

Re: (resend) Scroll window fix

2007-03-03 Thread Alexandre Julliard
"Dmitry Timoshkov" <[EMAIL PROTECTED]> writes: > Well, apparently the fix was based on a test (that was supposed to mimic > a real application behaviour that exposed a bug), and since the test is > wrong (since it doesn't pass on a single flavour of Windows) the fix is > wrong as well. The test f

Re: (resend) Scroll window fix

2007-03-03 Thread Dmitry Timoshkov
"Aric Stewart" <[EMAIL PROTECTED]> wrote: I did my work comparing to windows 2000. I could not get the test to run at all on my windows box so i had to try to fiddle with the test to get it to work. What exactly was the problem? I spent a lot of time working on windows 2000 to make this be

Re: (resend) Scroll window fix

2007-03-03 Thread Aric Stewart
I did my work comparing to windows 2000. I could not get the test to run at all on my windows box so i had to try to fiddle with the test to get it to work. I spent a lot of time working on windows 2000 to make this behavior the same and so feel the patch is not "obviously incorrect" and mos

Re: (resend) Scroll window fix

2007-03-02 Thread Dmitry Timoshkov
"Aric Stewart" <[EMAIL PROTECTED]> wrote: +SetRect( &rc, 0,40, 100,60); +SetRect( &cliprc, 0,0, 100,100); +ScrollWindowEx( hwnd1, 0, -25, &rc, &cliprc, hrgn, &rcu, SW_INVALIDATE); +SetRectRgn( tmprgn, 0,15,98,35); +CombineRgn( exprgn, exprgn, tmprgn, RGN_OR); +SetRectRgn(