Re: (try2)[PATCH 1/2] d3d10: Add a function to initialize the null variables.

2010-01-05 Thread Alexandre Julliard
Henri Verbeet writes: > 2010/1/5 Alexandre Julliard : >> That's not much of an improvement, static initialization is nicer. >> > In general yes, but it makes adding fields to d3d10_effect_variable or > changing their order a bit of a pain. C99 struct initialization would > help a bit there, but I

Re: (try2)[PATCH 1/2] d3d10: Add a function to initialize the null variables.

2010-01-05 Thread Henri Verbeet
2010/1/5 Alexandre Julliard : > That's not much of an improvement, static initialization is nicer. > In general yes, but it makes adding fields to d3d10_effect_variable or changing their order a bit of a pain. C99 struct initialization would help a bit there, but I doubt it's an option.

Re: (try2)[PATCH 1/2] d3d10: Add a function to initialize the null variables.

2010-01-05 Thread Alexandre Julliard
Rico Schüller writes: > +static void d3d10_null_effect_variable_init(struct d3d10_effect_variable *v, > struct ID3D10EffectVariableVtbl *vtbl) > +{ > +v->vtbl = vtbl; > +v->buffer = &null_local_buffer; > +v->type = &null_type; > +} > + > +void d3d10_null_effect_variable_init_all() >