2009/8/18 Henri Verbeet :
> 2009/8/18 Matteo Bruni :
>> constructs, single instructions, ...) but it seems to be quite a work
>> and in any case the resulting patch needs to have a working lexer,
>> parser, bytecode writer and the glue among them, so it can't be made
>> smaller than so much, I beli
2009/8/18 Matteo Bruni :
> constructs, single instructions, ...) but it seems to be quite a work
> and in any case the resulting patch needs to have a working lexer,
> parser, bytecode writer and the glue among them, so it can't be made
> smaller than so much, I believe.
I don't think that's reall
> The assembler requires quite some code to be at least minimally
> working (i.e. to implement a somewhat working D3DXAssembleShader
> function).
Is it not possible to implement enough to support some small subset of
the language? If it's not at all possible, then we'll just have to
live with it.
> Step 4) really comprises many small patches, and will often comprise
> the bulk of the patchset. It's important to make each commit atomic
> and useful. So, for example, adding a bunch of declarations that
> aren't used to a private header isn't useful, though it is atomic.
Hi Juan,
while in p
> Well, to be true all the first 12 patches add code which is
> effectively used only from patch 13 onwards. But I couldn't find a
> better way to split the patches in manageable pieces while avoiding
> these kind of issues.
I tend to agree with Vincent here: adding a bunch of dead code that
all
Am Sunday 16 August 2009 19:50:54 schrieb Matteo Bruni:
> This is a long patch series that implements the D3D shader assembler
> and D3DXAssembleShader function. The first part has already passed a
> couple of rounds of review in wine-devel.
The patches look ok for applying to me.
I didn't look de
2009/8/16 Vincent Povirk :
> Don't send patches that only add unused code.
>
Well, to be true all the first 12 patches add code which is
effectively used only from patch 13 onwards. But I couldn't find a
better way to split the patches in manageable pieces while avoiding
these kind of issues.
Don't send patches that only add unused code.
On Sun, Aug 16, 2009 at 12:50 PM, Matteo Bruni wrote:
> This is a long patch series that implements the D3D shader assembler
> and D3DXAssembleShader function. The first part has already passed a
> couple of rounds of review in wine-devel.
>
>
>
>
-
