Re: [1/2] comctl32/tests: Added tests for mouse events handling (try 3)

2012-04-15 Thread Bruno Jesus
On Sun, Apr 15, 2012 at 07:38, Daniel Jelinski wrote: > Hello, > ... > Bug 19222 makes using MS SQL Server management studio a pain. The > application displays database structure in a tree view, and most > actions are executed from a context menu displayed by right-clicking > on a relevant positio

Re: [1/2] comctl32/tests: Added tests for mouse events handling (try 3)

2012-04-15 Thread Daniel Jelinski
Hello, I see that my patch hasn't been accepted yet. Well if some explanation could help it through, here goes: Bug 19222 makes using MS SQL Server management studio a pain. The application displays database structure in a tree view, and most actions are executed from a context menu displayed by ri

Re: [1/2] comctl32/tests: Added tests for mouse events handling (try 5)

2012-04-10 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1 Your paranoid android

Re: [1/2] comctl32/tests: Added tests for mouse events handling (try 4)

2012-04-10 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17772 Your paranoid android

Re: [1/2] comctl32/tests: Added tests for mouse events handling (try 3)

2012-04-09 Thread Daniel Jeliński
Dnia 09-04-2012 o 04:13:44 Vitaliy Margolen napisał(a): On 04/08/2012 01:44 PM, Daniel Jelinski wrote: Hardware messages are an alternative, but I couldn't find any relevant examples, so I followed the path of least resistance. These tests you wrote won't work. Emulating mouse up/down events w

Re: [1/2] comctl32/tests: Added tests for mouse events handling (try 3)

2012-04-08 Thread Vitaliy Margolen
On 04/08/2012 01:44 PM, Daniel Jelinski wrote: Hardware messages are an alternative, but I couldn't find any relevant examples, so I followed the path of least resistance. These tests you wrote won't work. Emulating mouse up/down events with anything other then hardware messages will not exercis

Re: [1/2] comctl32/tests: Added tests for mouse events handling (try 3)

2012-04-08 Thread Daniel Jelinski
2012/4/8 Dmitry Timoshkov : > Daniel Jelinski wrote: > >> Skipping tests on WinNT - older versions of comctl send a different >> set of events. > > Then you need to figure out what is different, and make the tests pass > there as well (there is 'optional' flag for that), otherwise you risk > break

Re: [1/2] comctl32/tests: Added tests for mouse events handling (try 3)

2012-04-08 Thread Dmitry Timoshkov
Daniel Jelinski wrote: > Skipping tests on WinNT - older versions of comctl send a different > set of events. Then you need to figure out what is different, and make the tests pass there as well (there is 'optional' flag for that), otherwise you risk breaking applications written for NT. > +

Re: [1/2] comctl32/tests: Added tests for mouse events handling

2012-04-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17721 Your paranoid android