Re: [1/2] msi: Don't try to install or remove ODBC drivers if the component is disabled.

2010-12-09 Thread Joris Huizer
Hello, I noticed in this patch, exactly the same lines are added in all the functions; wouldn't it be better to add a(n) (inline) function isComponentEnabled(rec,package) to reduce the repetition? HTH, Joris

Re: [1/2] msi: Don't try to install or remove ODBC drivers if the component is disabled.

2010-12-09 Thread Hans Leidekker
On Thu, 2010-12-09 at 07:52 -0800, Joris Huizer wrote: I noticed in this patch, exactly the same lines are added in all the functions; wouldn't it be better to add a(n) (inline) function isComponentEnabled(rec,package) to reduce the repetition? I'm not opposed to consolidating the check in