Re: [1/3] d3dx9: Partial implementation of D3DXAssembleShader function. [try 3]

2010-02-08 Thread James Mckenzie
>> Well, in 2010 I've only done little changes. The real development on >> this was in 2009. What's the policy in these cases? I believe I can >> put the 2010 safely. >I have seen people adjust the years for simple fixes, although I don't know if >there is a formal >policy. Since your patches are

Re: [1/3] d3dx9: Partial implementation of D3DXAssembleShader function. [try 3]

2010-02-08 Thread Stefan Dösinger
Am 08.02.2010 um 21:51 schrieb Matteo Bruni: > In this case the '{' should go on its own line, sure. In general in > shader.c I tried to keep the style already used there, while in the > shader assembler files the style is different (although it should be > consistent on itself). > Let me know if

Re: [1/3] d3dx9: Partial implementation of D3DXAssembleShader function. [try 3]

2010-02-08 Thread Matteo Bruni
2010/2/8 Stefan Dösinger : > > Am 08.02.2010 um 16:33 schrieb Matteo Bruni: > >> Other than the things Henri last mentioned, there are some more small >> changes (make some struct const/static, whitespace fixes, remove some >> useless cruft, ...) particularly in patches 2 and 3. >> <0001-d3dx9-Part

Re: [1/3] d3dx9: Partial implementation of D3DXAssembleShader function. [try 3]

2010-02-08 Thread Stefan Dösinger
Am 08.02.2010 um 16:33 schrieb Matteo Bruni: > Other than the things Henri last mentioned, there are some more small > changes (make some struct const/static, whitespace fixes, remove some > useless cruft, ...) particularly in patches 2 and 3. > <0001-d3dx9-Partial-implementation-of-D3DXAssembleS