RE: [1/5] WineD3D: Get some vertex pipeline infrastructure in place

2008-11-17 Thread Stefan Dösinger
> Can we fix that? I think I would prefer it if > primitiveDeclarationConvertToStridedData() handled all that, and just > returned whether we can use the fast draw function, or have to use the > slow one. We never call primitiveDeclarationConverToStridedData() with drawPrimitiveStrided. We could o

Re: [1/5] WineD3D: Get some vertex pipeline infrastructure in place

2008-11-17 Thread Henri Verbeet
2008/11/17 Stefan Dösinger <[EMAIL PROTECTED]>: >> 2008/11/17 Stefan Dösinger <[EMAIL PROTECTED]>: >> > -} else if (fixup || >> > +} else if (device->vertex_pipe->can_convert_d3dcolor || fixup || >> Shouldn't this be redundant if you already handle color conversion in >> IWineD3DVertexBuffe

RE: [1/5] WineD3D: Get some vertex pipeline infrastructure in place

2008-11-17 Thread Stefan Dösinger
> 2008/11/17 Stefan Dösinger <[EMAIL PROTECTED]>: > > -} else if (fixup || > > +} else if (device->vertex_pipe->can_convert_d3dcolor || fixup || > Shouldn't this be redundant if you already handle color conversion in > IWineD3DVertexBufferImpl_FindDecl()? Not all vertex data comes from a ve

Re: [1/5] WineD3D: Get some vertex pipeline infrastructure in place

2008-11-16 Thread Henri Verbeet
2008/11/17 Stefan Dösinger <[EMAIL PROTECTED]>: > -} else if (fixup || > +} else if (device->vertex_pipe->can_convert_d3dcolor || fixup || Shouldn't this be redundant if you already handle color conversion in IWineD3DVertexBufferImpl_FindDecl()? > -} else { > +} else if(!device->ve