Re: [1/5] user32: Added tests for DrawIcon and DrawIconEx

2009-06-06 Thread Paul Vriens
Joel Holdsworth wrote: GetVersion() is not a problem in itself but we make an effort to decide what to test based on behavior not version. If it absolutely can not be avoided (and you will see some examples in the code) GetVersion() is accepted. I think this is the case here. DrawIcon[Ex]'s b

Re: [1/5] user32: Added tests for DrawIcon and DrawIconEx

2009-06-06 Thread Joel Holdsworth
> GetVersion() is not a problem in itself but we make an effort to decide > what to test based on behavior not version. If it absolutely can not be > avoided (and you will see some examples in the code) GetVersion() is > accepted. I think this is the case here. DrawIcon[Ex]'s behaviour has evo

RE: [1/5] user32: Added tests for DrawIcon and DrawIconEx

2009-06-06 Thread Rolf Kalbermatter
Joel Holdsworth [mailto:j...@airwebreathe.org.uk] > However, you're saying GetVersion is a problem. Why is that? > And how else is one supposed to cope with GdiAlphaBlend not > being present in pre-XP systems, as well as old-style > dithering differences? Wine tests try to not depend on a par

Re: [1/5] user32: Added tests for DrawIcon and DrawIconEx

2009-06-06 Thread Paul Vriens
Joel Holdsworth wrote: I've run your new tests on Win95, Win98 and NT4 (all VMware): Is there another way you can detect whether some XP (and up) tests can be run? We generally try not to use GetVersion() in our tests. It turns out that the reason for the Win95 errors is that it calculates

Re: [1/5] user32: Added tests for DrawIcon and DrawIconEx

2009-06-05 Thread Joel Holdsworth
> I've run your new tests on Win95, Win98 and NT4 (all VMware): > Is there another way you can detect whether some XP (and up) tests can > be run? We generally try not to use GetVersion() in our tests. > It turns out that the reason for the Win95 errors is that it calculates true-colour -> 16-b

Re: [1/5] user32: Added tests for DrawIcon and DrawIconEx

2009-06-04 Thread Joel Holdsworth
On Thu, 2009-06-04 at 08:43 +0200, Paul Vriens wrote: > Joel Holdsworth wrote: > > > > > > > > > Hi Joel, > > I've run your new tests on Win95, Win98 and NT4 (all VMware): > > Win95: > == > cursoricon.c:1013: Test fai

Re: [1/5] user32: Added tests for DrawIcon and DrawIconEx

2009-06-04 Thread Henri Verbeet
2009/6/4 Paul Vriens : > Is there another way you can detect whether some XP (and up) tests can > be run? We generally try not to use GetVersion() in our tests. > Just a guess, but XP's screen color depth of 32bpp might be significant here. If that's the case you'd also expect the tests to fail on

Re: [1/5] user32: Added tests for DrawIcon and DrawIconEx

2009-06-03 Thread Paul Vriens
Joel Holdsworth wrote: Hi Joel, I've run your new tests on Win95, Win98 and NT4 (all VMware): Win95: == cursoricon.c:1013: Test failed: Overlaying Mask 0 on Color 00A0B0C0 with DrawIcon. Expected 3163. Got