Re: [2/2] d3dx9: Implement D3DXLoadMeshHierarchy for basic mesh hierarchy.

2011-05-19 Thread Joris Huizer
On 05/19/2011 06:34 PM, Dylan Smith wrote: On Thu, May 19, 2011 at 6:16 AM, Joris Huizer wrote: Hello, I found a possibly memory leak in the patch. In this function: +static HRESULT parse_mesh(IDirectXFileData *filedata, struct mesh_data *mesh_data, DWORD provide_flags) These may leak the

Re: [2/2] d3dx9: Implement D3DXLoadMeshHierarchy for basic mesh hierarchy.

2011-05-19 Thread Dylan Smith
On Thu, May 19, 2011 at 6:16 AM, Joris Huizer wrote: > > Hello, > > I found a possibly memory leak in the patch. > In this function: > >> +static HRESULT parse_mesh(IDirectXFileData *filedata, struct mesh_data >> *mesh_data, DWORD provide_flags) > > These may leak the allocated blocks: >> >> + >>

Re: [2/2] d3dx9: Implement D3DXLoadMeshHierarchy for basic mesh hierarchy.

2011-05-19 Thread Joris Huizer
Hello, I found a possibly memory leak in the patch. In this function: +static HRESULT parse_mesh(IDirectXFileData *filedata, struct mesh_data *mesh_data, DWORD provide_flags) These may leak the allocated blocks: + +mesh_data->vertices = HeapAlloc(GetProcessHeap(), 0, +mesh_da