Re: [2/3] winex11.drv: Don't modify current state if glXMakeCurrent fails.

2011-03-29 Thread Roderick Colenbrander
The first part of the patch was fine, the only concern is the error code. Since there is no WGL standard, the error codes thrown by different drivers can be inconsistent :( I'm not sure if it is better to set an error code at all or not. I'm not sure what I would prefer... Roderick On Tue, Mar 29

Re: [2/3] winex11.drv: Don't modify current state if glXMakeCurrent fails.

2011-03-29 Thread Matteo Bruni
2011/3/29 Roderick Colenbrander : > I'm not sure if the only value error wglMakeCurrent should return is > INVALID_HANDLE. What if glXMakeCurrent fails because of an invalid > context? The return value may be similar, but don't remember for sure. > > Roderick Practically speaking it seems to be ve

Re: [2/3] winex11.drv: Don't modify current state if glXMakeCurrent fails.

2011-03-29 Thread Roderick Colenbrander
I'm not sure if the only value error wglMakeCurrent should return is INVALID_HANDLE. What if glXMakeCurrent fails because of an invalid context? The return value may be similar, but don't remember for sure. Roderick On Tue, Mar 29, 2011 at 7:42 AM, Matteo Bruni wrote: > > > > >