On 16 February 2010 14:59, Stefan Dösinger wrote:
>
Patch 1:
> if (!pData || !dwSize) return S_OK;
...
> +if (data)
This should be unnecessary, since you already checked "pData" above.
Otherwise the patch looks reasonable.
Patch 4:
> +GLenum gl_ret = GL_EXTCALL(glClientWaitSync(
On 27 January 2010 13:07, Stefan Dösinger wrote:
> Am 27.01.2010 um 11:19 schrieb Henri Verbeet:
>> You shouldn't need that. It only flushes for the current context anyway.
> From section 5.2.2 in the extension:
>> If the sync object being blocked upon will not be signaled in finite
>> time
Am 27.01.2010 um 11:19 schrieb Henri Verbeet:
>> The only deeper change in patch 3 is that I am passing
>> GL_SYNC_FLUSH_COMMANDS_BIT. I think this is reasonable when we're waiting
>> for drawing to complete.
>>
> You shouldn't need that. It only flushes for the current context anyway.
>From se
On 26 January 2010 20:22, Stefan Dösinger wrote:
> Patch 2 moves the event query faking out of the way. That allows me to remove
> all GL extension checks, and the buffer code just checks if it can create a
> d3d event query. (Patch 1 removes some dead code I ran into). Once Mesa
> supports ARB
On 26 January 2010 13:42, Stefan Dösinger wrote:
> If I let the buffer code create a wined3d_event_query then I'll have to
> create internal functions like this for _Issue and _GetData as well, and the
> real IWineD3DEventQueryImpl_Issue and IWineD3DEventQueryImpl_GetData would
> just be simple
Am 26.01.2010 um 12:44 schrieb Henri Verbeet:
> On 26 January 2010 11:51, Stefan Dösinger wrote:
>> +HRESULT wined3d_event_query_finish(IWineD3DQuery* iface) {
> Please don't create function prototypes (or other code) by copy/paste.
> Also, why does this take a IWineD3DQuery pointer in the first
On 26 January 2010 11:51, Stefan Dösinger wrote:
> +HRESULT wined3d_event_query_finish(IWineD3DQuery* iface) {
Please don't create function prototypes (or other code) by copy/paste.
Also, why does this take a IWineD3DQuery pointer in the first place?
You only really access wined3d_event_query fiel
