Re: [2/5] gdi32: Introduce a list of font file/data.

2012-04-24 Thread Alexandre Julliard
Kusanagi Kouichi writes: > On 2012-04-24 13:01:04 +0200, Alexandre Julliard wrote: >> Kusanagi Kouichi writes: >> >> >> You can't compare files this way, different paths can point to the same >> >> file. >> > >> > This function finds font path, not file. So find_font_path would be >> > more app

Re: [2/5] gdi32: Introduce a list of font file/data.

2012-04-24 Thread Kusanagi Kouichi
On 2012-04-24 13:01:04 +0200, Alexandre Julliard wrote: > Kusanagi Kouichi writes: > > >> You can't compare files this way, different paths can point to the same > >> file. > > > > This function finds font path, not file. So find_font_path would be > > more appropriate name. > > What's the point

Re: [2/5] gdi32: Introduce a list of font file/data.

2012-04-24 Thread Alexandre Julliard
Kusanagi Kouichi writes: >> You can't compare files this way, different paths can point to the same >> file. > > This function finds font path, not file. So find_font_path would be > more appropriate name. What's the point of doing this if it doesn't catch identical files? -- Alexandre Julliar

Re: [2/5] gdi32: Introduce a list of font file/data.

2012-04-23 Thread Kusanagi Kouichi
On 2012-04-23 12:11:06 +0200, Alexandre Julliard wrote: > Kusanagi Kouichi writes: > > > @@ -962,6 +972,22 @@ static Family *find_family_from_any_name(const WCHAR > > *name) > > return NULL; > > } > > > > +static Font *find_font_file(const char *file) > > +{ > > +if (file != NULL) >

Re: [2/5] gdi32: Introduce a list of font file/data.

2012-04-23 Thread Alexandre Julliard
Kusanagi Kouichi writes: > @@ -962,6 +972,22 @@ static Family *find_family_from_any_name(const WCHAR > *name) > return NULL; > } > > +static Font *find_font_file(const char *file) > +{ > +if (file != NULL) > +{ > +Font *font; > + > +LIST_FOR_EACH_ENTRY(font, &font