Re: [2/5] ntdll: Make NtWriteFile handle special offset -2 same way as -1. Resend.

2013-09-10 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Alexandre Julliard wrote: > >> Why do you need that? It doesn't look to me like an improvement. > > IMO it simplifies the code and avoids using two different code paths > for normal files. At the cost of two extra seeks, plus introducing race conditions. I don't thin

Re: [2/5] ntdll: Make NtWriteFile handle special offset -2 same way as -1. Resend.

2013-09-10 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > Why do you need that? It doesn't look to me like an improvement. IMO it simplifies the code and avoids using two different code paths for normal files. -- Dmitry.

Re: [2/5] ntdll: Make NtWriteFile handle special offset -2 same way as -1. Resend.

2013-09-10 Thread Alexandre Julliard
Dmitry Timoshkov writes: > --- > dlls/ntdll/file.c | 31 +++ > 1 file changed, 15 insertions(+), 16 deletions(-) Why do you need that? It doesn't look to me like an improvement. -- Alexandre Julliard julli...@winehq.org