Re: [3/5] d3dx9: Implement D3DXSaveSurfaceToFileW.

2012-05-03 Thread Henri Verbeet
On 3 May 2012 15:48, Józef Kucia wrote: > Thanks for the review. > > On Thu, May 3, 2012 at 1:08 PM, Henri Verbeet wrote: >>> +    memcpy(&wic_pixel_format, pixel_format_guid, sizeof(GUID)); >>> +    hr = IWICBitmapFrameEncode_SetPixelFormat(frame, &wic_pixel_format); >>> +    d3d_pixel_format =

Re: [3/5] d3dx9: Implement D3DXSaveSurfaceToFileW.

2012-05-03 Thread Józef Kucia
Thanks for the review. On Thu, May 3, 2012 at 1:08 PM, Henri Verbeet wrote: >> +    memcpy(&wic_pixel_format, pixel_format_guid, sizeof(GUID)); >> +    hr = IWICBitmapFrameEncode_SetPixelFormat(frame, &wic_pixel_format); >> +    d3d_pixel_format = wic_guid_to_d3dformat(&wic_pixel_format); > What

Re: [3/5] d3dx9: Implement D3DXSaveSurfaceToFileW.

2012-05-03 Thread Henri Verbeet
On 2 May 2012 23:32, Józef Kucia wrote: > +        if(wic_pixel_formats[i].d3dformat == format) Missing whitespace. > +HRESULT WINAPI D3DXSaveSurfaceToFileW(LPCWSTR dst_filename, > D3DXIMAGE_FILEFORMAT file_format, "LPCWSTR" -> "const WCHAR *" > +    TRACE("(%s, %d, %p, %p, %p)\n", > +        w