Re: [4/5] ddraw: Extend the lifetime of the IDirect3D7::EnumDevices strings beyond function scope.

2011-06-01 Thread Stefan Dösinger
Am 31.05.2011 um 18:00 schrieb Andrew Nguyen: > No, I simply defined the structure there to be consistent with the role > of the unused structure definitions I removed earlier. I can certainly > move the definition to ddraw.c. Yes, please. And yeah, the existing code could use some improvement in

Re: [4/5] ddraw: Extend the lifetime of the IDirect3D7::EnumDevices strings beyond function scope.

2011-05-31 Thread Andrew Nguyen
On 05/31/2011 10:47 AM, Stefan Dösinger wrote: > Does the enum_device_entry structure have to be in ddraw_private.h? I > think you can just declare it in ddraw.c because it is used only there. No, I simply defined the structure there to be consistent with the role of the unused structure definitio

Re: [4/5] ddraw: Extend the lifetime of the IDirect3D7::EnumDevices strings beyond function scope.

2011-05-31 Thread Stefan Dösinger
Does the enum_device_entry structure have to be in ddraw_private.h? I think you can just declare it in ddraw.c because it is used only there. At some point we'll want to get rid of the ddraw device type strings and call wined3d_get_adapter_identifier - but that needs more work and some more test