Re: [4/5] ddraw: Get rid of ICOM_INTERFACE.

2009-01-21 Thread Henri Verbeet
2009/1/21 Rob Shearman : > You're also relying on the IDirect3DDevice7 vtable field being the > first field on the impl struct, so you should add a big comment to the > impl struct warning that bad things will happen if the > IDirect3DDevice7 vtable field isn't the first one. > Sure, but I'd say it

Re: [4/5] ddraw: Get rid of ICOM_INTERFACE.

2009-01-21 Thread Rob Shearman
2009/1/21 Henri Verbeet : > 2009/1/21 Stefan Dösinger : >>> I don't see the point. IDirect3DDevice7 is the primary vtable and >>> that's not going to change, ever. We also do things like this about >>> everywhere else, and I don't think ddraw should be special in that >>> regard. >> I don't see any

Re: [4/5] ddraw: Get rid of ICOM_INTERFACE.

2009-01-21 Thread Henri Verbeet
2009/1/21 Stefan Dösinger : >> I don't see the point. IDirect3DDevice7 is the primary vtable and >> that's not going to change, ever. We also do things like this about >> everywhere else, and I don't think ddraw should be special in that >> regard. > I don't see any 'primary' vtable in any ddraw ob

RE: [4/5] ddraw: Get rid of ICOM_INTERFACE.

2009-01-21 Thread Stefan Dösinger
> I don't see the point. IDirect3DDevice7 is the primary vtable and > that's not going to change, ever. We also do things like this about > everywhere else, and I don't think ddraw should be special in that > regard. I don't see any 'primary' vtable in any ddraw object, but that's just my personal

Re: [4/5] ddraw: Get rid of ICOM_INTERFACE.

2009-01-21 Thread Henri Verbeet
2009/1/21 Stefan Dösinger : > I think it would be better to access IDirect3DDevice7 via explicit > specifying the vtable, or an inline function for consistency and to avoid > hardwiring the assumption that the IDirect3DDevice7 vtable is the first > member of the object > I don't see the point. IDir

RE: [4/5] ddraw: Get rid of ICOM_INTERFACE.

2009-01-21 Thread Stefan Dösinger
> -Original Message- > From: wine-patches-boun...@winehq.org [mailto:wine-patches- > boun...@winehq.org] On Behalf Of Henri Verbeet > Sent: Wednesday, January 21, 2009 10:01 AM > To: wine-patc...@winehq.org > Subject: [4/5] ddraw: Get rid of ICOM_INTERFACE. &